The following patch addresses the following issues:

+ fixed logout

+ removed several unused functions

+ removed 60* from install file

+ properly documented functions

+ offer multiple button texts

+ fix login button (only worked in auto mode)

+ fix login size in admin screen

+ Remove login button from user_login form (it is not part of that form) and moved it to a block

+ fix inconsistencies with auto mode

+ removed "ask" setting in login / logout mode as it wasn't in use

+ updated README file

+ removed "logo" setting:

open graph doesn't support it anymore: https://developers.facebook.com/docs/reference/api/photo/

+ removed unnecessary css

As well as
#1243534: Facebook Connect with fb_social
#1291924: Fix typo allready > already
#1287502: De-couple "login" from "register"

Sorry this is so big. I could try and break these out into more issues if necessary.

CommentFileSizeAuthor
#3 fbconnect-cleanup-1296370-3.patch46.48 KBdoka
#1 fbconnect-cleanup.patch28.12 KBacouch
fbconnect-cleanup.patch28.02 KBacouch

Comments

acouch’s picture

acouch commented
StatusFileSize
new fbconnect-cleanup.patch28.12 KB

Fixed one element with the button settings.

giorgio79’s picture

giorgio79 commented
Status: Active » Needs review

Awesome, subs.

doka’s picture

doka commented
StatusFileSize
new fbconnect-cleanup-1296370-3.patch46.48 KB

This patch adds on top of #1 the following patches as well:

#1294020: add Library API support: integrates the Library API (http://drupal.org/project/libraries)
#1262450: wrong db_select in fbconnect_invite.module and #1261866: serveral warning once the "Facebook Friends" block is activated and #1262458: cache error in FB invite block cause 500 HTTP Internal Server Error: correct few errors in the invite module
#1291920: Allow auto linking existing user to FB: Allow auto linking existing user to FB
#1291696: Linked account profile field is incorrect for Drupal 7: correct unlink in user settings form
#1290612: Set explicit weights on the User settings form: Giving the FBConnect items explicit 'normal' weights, and correct the settings link
#1291836: Fixes for fbconnect_stream_publish: fixes for stream publish

Simple apply this patch over the 7.x-2.x-dev version of 2011-Sep-23.

doka’s picture

doka commented

or use this drush makefile (https://doka@github.com/doka/fbconnect_f.git) to get the Facebook SDK PHP 3.1.1 library, the fbconnect module, as well as the #3 patch downloaded and applied in one run into your /site/all folder.

drush make https://raw.github.com/doka/fbconnect_f/master/fbconnect_f.make --no-core demo
amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented

@doke, thank you but lets keep this issue's scope clear. The patch to review is in #1

hadi farnoud’s picture

hadi farnoud commented

I get error 500 on /admin/config/people/fbconnect/apperance and fbconnect/register/create

also I get

Facebook PHP sdk Not installed
Fbconnect : Facebook PHP library not found. See README.txt

on status

hadi farnoud’s picture

hadi farnoud commented

#3 not applying on 23rd

doka’s picture

doka commented

you have to install the Facebook PHP SDK library as well, not just the fbconnect module and the patch.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Fixed

I've committed #3 with some tweaks, mostly an updated .install file to delete all of the variables.

Of the half dozen issues in #3, can someone go mark them as fixed accordingly?

http://drupalcode.org/project/fbconnect.git/commit/7c1d439e717d7219b4907...

giorgio79’s picture

giorgio79 commented

Of the half dozen issues in #3, can someone go mark them as fixed accordingly?

Done

Tim, could you also commit these patches waiting here
http://drupal.org/project/issues/fbconnect?text=&status=Open&priorities=...

Given we never had a stable 7 release I think we can go ahead since it is still in dev. :)

kpitcher’s picture

kpitcher commented

I just tried to install this on 7.8

Module installs according to module list but if it's active I get a 500 error when I try to go to configuration.
If I disable it things are back fine.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

@giorgio79 Can you mark RTBC the ones that are ready?

kpitcher’s picture

kpitcher commented

I had a few other modules that I think were conflicting. (Some chaos tools but I was no longer using them)
Once I removed those it installed enough to allow going to configuration.

Now I'm getting the Fbconnect : Facebook PHP library not found. The libraries sql table shows it does know where facebook-php-sdk is located. The manual module install and also the drush install both gave the same error so not sure what else to try to resolve this.

giorgio79’s picture

giorgio79 commented

@kpitcher: raised a separate issue #1318004: Fatal error: Call to a member function getUser() on a non-object in sites/all/modules/fbconnect/fbconnect.module on line 408 looks like the library api patch by doka needs some work

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.