BIRT (Business Intelligence Reporting Tools) is an open source software project that provides reporting and business intelligence capabilities for rich client and web applications, especially those based on Java and Java EE. BIRT is a top level software project within the Eclipse Foundation, an independent not-for-profit consortium of software industry vendors and an open source community.
The application is a BIRT Open Source Engine integration as a Drupal module for dynamic, BIRT data-driven content pages. It allows multiple BIRT designs to be integrated as its own Drupal content type which are displayable on the developer’s site. Developers can use this module to display BIRT Reports on their Drupal site.
This is a unique module as no other modules allow you to display BIRT charts/reports on your Drupal site.

It can be found at: http://www.birt-exchange.com/be/marketplace/app-showcase/

Under the name: BIRT OS Drupal 6 Module

In this module packaging contains a User Guide, Screenshots, Installation Video, Overview Video and the actual module itself.

I believe this here is the git link: MoMoney8181@git.drupal.org:sandbox/MoMoney8181/1259928.git

or

http://git.drupal.org/sandbox/MoMoney8181/1259928.git birt_open_source_drupal_6_module

Project Page link:

http://drupal.org/sandbox/MoMoney8181/1259928

This module is for Drupal 6.

Comments

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Needs work
  • project page name: "BIRT Open Source Drupal 6 Module" all code on drupal.org is free software (GPL), so no need to add this to the title. Also "Drupal 6 Module" is quite useless in the title.
  • git release branch missing, see http://drupal.org/node/1015226
  • README.txt is missing
  • code is missing - have pushed all your commits? See the project application workflow: http://drupal.org/node/1011698
MoMoney8181’s picture

MoMoney8181 commented

Hello,

I believe I have made all the necessary changes to the project. I have put the code on the 6.x-1.x branch. The README.txt and the code is in that branch as well. Please let me know if anything else needs to be added or changed as I am new to Git and Drupal submission.

Thanks,
Mohit

MoMoney8181’s picture

MoMoney8181 commented

Hello,

I just wanted to follow up on this project and see if anyone has got a chance to look at this.

Thanks,
Mohit

patrickd’s picture

patrickd commented
Status: Needs work » Needs review

If you want a review you need to change this to needs review

drupaledmonk’s picture

drupaledmonk commented
Status: Needs review » Needs work

Hi Mohit,
Please look into this and clean up your code.

There are still files other than README.txt in the master branch, make sure to remove them. See also step 5 in http://drupal.org/node/1127732
Review of the 6.x-1.x branch:

./birtos.module: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming

function birtos_node_info() {
function birtos_access($op, $node, $account) {
function birtos_perm() {
function birtos_admin() {
function birtos_menu() {
function birtos_form(&$node) {
function birtos_insert($node) {
function birtos_update($node) {
function birtos_nodeapi(&$node, $op, $teaser, $page) {
function birtos_delete($node) {
function birtos_load($node) {
function birtos_view($node, $teaser = FALSE, $page = FALSE) {
function birtos_theme() {
./birtos.install: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming

function birtos_install() {
function birtos_uninstall() {
function birtos_schema() {
Remove all old CVS $Id tags, they are not needed anymore.

birtos.install:2:// $Id: birtos.install,v 1.10.2.1 07/08/2010
birtos.module:2:// $Id$
Run coder to check your style, some issues were found (please check the Drupal coding standards). See attachment.
Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.
This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Go and review some other project applications, so we can get back to yours sooner.


Severity minor, Drupal Commenting Standards, Internationalization, Drupal Security Checks, Drupal SQL Standards, Drupal Coding Standards

sites/all/modules/pareview_temp/test_candidate/./birtos.install:
+2: [minor] Commits to the Git repository do not require the CVS $Id$ keyword in each file.

Status Messages:
Coder found 1 projects, 1 files, 1 minor warnings, 0 warnings were flagged to be ignored

FILE: ...pal-7-pareview/sites/all/modules/pareview_temp/test_candidate/GPLv2.txt
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
339 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

FILE: ...al-7-pareview/sites/all/modules/pareview_temp/test_candidate/README.txt
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 31 WARNING(S) AFFECTING 31 LINE(S)
--------------------------------------------------------------------------------
7 | WARNING | Line exceeds 80 characters; contains 129 characters
8 | WARNING | Line exceeds 80 characters; contains 126 characters
14 | WARNING | Line exceeds 80 characters; contains 129 characters
15 | WARNING | Line exceeds 80 characters; contains 129 characters
16 | WARNING | Line exceeds 80 characters; contains 127 characters
17 | WARNING | Line exceeds 80 characters; contains 130 characters
18 | WARNING | Line exceeds 80 characters; contains 81 characters
29 | WARNING | Line exceeds 80 characters; contains 149 characters
31 | WARNING | Line exceeds 80 characters; contains 189 characters
33 | WARNING | Line exceeds 80 characters; contains 152 characters
35 | WARNING | Line exceeds 80 characters; contains 112 characters
37 | WARNING | Line exceeds 80 characters; contains 148 characters
39 | WARNING | Line exceeds 80 characters; contains 121 characters
45 | WARNING | Line exceeds 80 characters; contains 151 characters
47 | WARNING | Line exceeds 80 characters; contains 129 characters
49 | WARNING | Line exceeds 80 characters; contains 205 characters
55 | WARNING | Line exceeds 80 characters; contains 118 characters
62 | WARNING | Line exceeds 80 characters; contains 120 characters
64 | WARNING | Line exceeds 80 characters; contains 123 characters
65 | WARNING | Line exceeds 80 characters; contains 91 characters
67 | WARNING | Line exceeds 80 characters; contains 123 characters
68 | WARNING | Line exceeds 80 characters; contains 95 characters
74 | WARNING | Line exceeds 80 characters; contains 133 characters
75 | WARNING | Line exceeds 80 characters; contains 142 characters
76 | WARNING | Line exceeds 80 characters; contains 138 characters
78 | WARNING | Line exceeds 80 characters; contains 142 characters
80 | WARNING | Line exceeds 80 characters; contains 144 characters
81 | WARNING | Line exceeds 80 characters; contains 111 characters
93 | WARNING | Line exceeds 80 characters; contains 91 characters
102 | WARNING | Line exceeds 80 characters; contains 123 characters
107 | WARNING | Line exceeds 80 characters; contains 153 characters
--------------------------------------------------------------------------------

FILE: ...-pareview/sites/all/modules/pareview_temp/test_candidate/birtos.install
--------------------------------------------------------------------------------
FOUND 14 ERROR(S) AND 4 WARNING(S) AFFECTING 12 LINE(S)
--------------------------------------------------------------------------------
2 | ERROR | You must use "/**" style comments for a file comment
2 | ERROR | There must be no blank line following an inline comment
15 | ERROR | Whitespace found at end of line
28 | WARNING | Line exceeds 80 characters; contains 89 characters
41 | ERROR | Whitespace found at end of line
43 | WARNING | Format should be "* Implements hook_foo()." or "Implements
| | hook_foo_BAR_ID_bar() for xyz_bar."
51 | WARNING | Format should be "* Implements hook_foo()." or "Implements
| | hook_foo_BAR_ID_bar() for xyz_bar."
60 | WARNING | Format should be "* Implements hook_foo()." or "Implements
| | hook_foo_BAR_ID_bar() for xyz_bar."
69 | ERROR | Spaces must be used to indent lines; tabs are not allowed
69 | ERROR | Array indentation error, expected 8 spaces but found 3
69 | ERROR | Whitespace found at end of line
83 | ERROR | Array indentation error, expected 4 spaces but found 8
83 | ERROR | Array closing indentation error, expected 4 spaces but found 8
83 | ERROR | Whitespace found at end of line
87 | ERROR | Array indentation error, expected 4 spaces but found 6
87 | ERROR | Array closing indentation error, expected 4 spaces but found 6
88 | ERROR | Array closing indentation error, expected 2 spaces but found 6
90 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

FILE: ...7-pareview/sites/all/modules/pareview_temp/test_candidate/birtos.module
--------------------------------------------------------------------------------
FOUND 122 ERROR(S) AND 20 WARNING(S) AFFECTING 92 LINE(S)
--------------------------------------------------------------------------------
1 | ERROR | Missing file doc comment
1 | ERROR | "require_once" is a statement not a function; no parentheses
| | are required
2 | ERROR | There must be no blank line following an inline comment
13 | ERROR | Whitespace found at end of line
22 | ERROR | Expected 1 space(s) before asterisk; 0 found
25 | ERROR | Expected 1 space(s) before asterisk; 0 found
26 | ERROR | Expected 1 space(s) before asterisk; 0 found
26 | ERROR | There must be an empty line before the parameter block
26 | ERROR | Doc comment for var which does not match actual variable name
| | $path at position 1
26 | ERROR | Parameter comment must be on the next line at position 1
27 | WARNING | Line exceeds 80 characters; contains 87 characters
27 | ERROR | Expected 1 space(s) before asterisk; 0 found
27 | ERROR | Last parameter comment requires a blank newline after it
27 | ERROR | Doc comment for var array does not match actual variable name
| | $arg at position 2
27 | ERROR | Parameter comment must be on the next line at position 2
28 | ERROR | Expected 1 space(s) before asterisk; 0 found
28 | ERROR | Return comment must be on the next line
29 | ERROR | Expected 1 space(s) before asterisk; 0 found
30 | ERROR | Line indented incorrectly; expected 0 spaces, found 2
31 | ERROR | No space before comment text; expected "// declare your output
| | variable" but found "//declare your output variable"
31 | ERROR | Inline comments must start with a capital letter
31 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
31 | ERROR | Comments may not appear after statements.
32 | ERROR | Line indented incorrectly; expected 2 spaces, found 4
33 | ERROR | Line indented incorrectly; expected 4 spaces, found 6
34 | ERROR | Concat operator must be surrounded by spaces
34 | ERROR | Concat operator must be surrounded by spaces
35 | ERROR | Break statement indented incorrectly; expected 8 spaces, found
| | 6
38 | ERROR | Closing brace indented incorrectly; expected 2 spaces, found 0
38 | ERROR | Inline comments must start with a capital letter
38 | ERROR | There must be no blank line following an inline comment
41 | WARNING | Format should be "* Implements hook_foo()." or "Implements
| | hook_foo_BAR_ID_bar() for xyz_bar."
71 | WARNING | A comma should follow the last multiline array item. Found: )
76 | WARNING | Format should be "* Implements hook_foo()." or "Implements
| | hook_foo_BAR_ID_bar() for xyz_bar."
98 | WARNING | Format should be "* Implements hook_foo()." or "Implements
| | hook_foo_BAR_ID_bar() for xyz_bar."
101 | WARNING | Line exceeds 80 characters; contains 81 characters
115 | WARNING | Format should be "* Implements hook_foo()." or "Implements
| | hook_foo_BAR_ID_bar() for xyz_bar."
118 | WARNING | Line exceeds 80 characters; contains 81 characters
118 | ERROR | Whitespace found at end of line
120 | ERROR | Function doc comment must end on the line before the function
| | definition
123 | ERROR | Spaces must be used to indent lines; tabs are not allowed
123 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1
125 | ERROR | Spaces must be used to indent lines; tabs are not allowed
125 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1
126 | ERROR | Spaces must be used to indent lines; tabs are not allowed
127 | ERROR | Spaces must be used to indent lines; tabs are not allowed
128 | ERROR | Spaces must be used to indent lines; tabs are not allowed
129 | ERROR | Spaces must be used to indent lines; tabs are not allowed
130 | ERROR | Spaces must be used to indent lines; tabs are not allowed
131 | ERROR | Spaces must be used to indent lines; tabs are not allowed
132 | ERROR | Spaces must be used to indent lines; tabs are not allowed
132 | WARNING | A comma should follow the last multiline array item. Found:
| | TRUE
133 | ERROR | Spaces must be used to indent lines; tabs are not allowed
133 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1
134 | ERROR | Whitespace found at end of line
134 | ERROR | Spaces must be used to indent lines; tabs are not allowed
135 | ERROR | Spaces must be used to indent lines; tabs are not allowed
135 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1
136 | ERROR | Whitespace found at end of line
139 | WARNING | Format should be "* Implements hook_foo()." or "Implements
| | hook_foo_BAR_ID_bar() for xyz_bar."
146 | ERROR | Spaces must be used to indent lines; tabs are not allowed
146 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1
148 | ERROR | Spaces must be used to indent lines; tabs are not allowed
148 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1
149 | ERROR | Spaces must be used to indent lines; tabs are not allowed
150 | ERROR | Spaces must be used to indent lines; tabs are not allowed
151 | ERROR | Spaces must be used to indent lines; tabs are not allowed
152 | ERROR | Spaces must be used to indent lines; tabs are not allowed
153 | ERROR | Spaces must be used to indent lines; tabs are not allowed
154 | ERROR | Spaces must be used to indent lines; tabs are not allowed
155 | ERROR | Spaces must be used to indent lines; tabs are not allowed
155 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1
156 | ERROR | Whitespace found at end of line
156 | ERROR | Spaces must be used to indent lines; tabs are not allowed
157 | ERROR | Spaces must be used to indent lines; tabs are not allowed
157 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 1
158 | ERROR | Whitespace found at end of line
161 | WARNING | Format should be "* Implements hook_foo()." or "Implements
| | hook_foo_BAR_ID_bar() for xyz_bar."
178 | WARNING | A comma should follow the last multiline array item. Found: 5
187 | WARNING | A comma should follow the last multiline array item. Found: 4
193 | WARNING | Format should be "* Implements hook_foo()." or "Implements
| | hook_foo_BAR_ID_bar() for xyz_bar."
203 | WARNING | Format should be "* Implements hook_foo()." or "Implements
| | hook_foo_BAR_ID_bar() for xyz_bar."
209 | ERROR | Inline comments must start with a capital letter
219 | WARNING | Format should be "* Implements hook_foo()." or "Implements
| | hook_foo_BAR_ID_bar() for xyz_bar."
235 | WARNING | Format should be "* Implements hook_foo()." or "Implements
| | hook_foo_BAR_ID_bar() for xyz_bar."
245 | WARNING | Format should be "* Implements hook_foo()." or "Implements
| | hook_foo_BAR_ID_bar() for xyz_bar."
257 | WARNING | Format should be "* Implements hook_foo()." or "Implements
| | hook_foo_BAR_ID_bar() for xyz_bar."
272 | WARNING | Format should be "* Implements hook_foo()." or "Implements
| | hook_foo_BAR_ID_bar() for xyz_bar."
293 | ERROR | Whitespace found at end of line
293 | ERROR | Spaces must be used to indent lines; tabs are not allowed
294 | ERROR | Line indented incorrectly; expected at least 2 spaces, found 0
294 | ERROR | There must be no blank line following an inline comment
296 | ERROR | Whitespace found at end of line
298 | ERROR | Whitespace found at end of line
300 | ERROR | Variable "imageURLPrefix" is camel caps format. do not use
| | mixed case (camelCase), use lower case and _
302 | ERROR | Whitespace found at end of line
306 | ERROR | Variable "birtReportEngine" is camel caps format. do not use
| | mixed case (camelCase), use lower case and _
310 | ERROR | Line indented incorrectly; expected at least 4 spaces, found 2
310 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
311 | ERROR | Line indented incorrectly; expected at least 4 spaces, found 2
311 | ERROR | Variable "reportFolder" is camel caps format. do not use mixed
| | case (camelCase), use lower case and _
313 | ERROR | Line indented incorrectly; expected at least 4 spaces, found 2
313 | ERROR | Variable "birtReportEngine" is camel caps format. do not use
| | mixed case (camelCase), use lower case and _
314 | ERROR | Line indented incorrectly; expected at least 4 spaces, found 2
314 | ERROR | Variable "birtReportEngine" is camel caps format. do not use
| | mixed case (camelCase), use lower case and _
315 | ERROR | Line indented incorrectly; expected at least 4 spaces, found 2
315 | ERROR | No space before comment text; expected "//
| | $task->setParameterValue("Top Count", new
| | java("java.lang.Integer", 6));" but found
| | "//$task->setParameterValue("Top Count", new
| | java("java.lang.Integer", 6));"
315 | ERROR | There must be no blank line following an inline comment
317 | ERROR | Line indented incorrectly; expected at least 4 spaces, found 2
317 | ERROR | Variable "taskOptions" is camel caps format. do not use mixed
| | case (camelCase), use lower case and _
318 | ERROR | Line indented incorrectly; expected at least 4 spaces, found 2
318 | ERROR | Variable "outputStream" is camel caps format. do not use mixed
| | case (camelCase), use lower case and _
319 | ERROR | Line indented incorrectly; expected at least 4 spaces, found 2
319 | ERROR | Variable "taskOptions" is camel caps format. do not use mixed
| | case (camelCase), use lower case and _
319 | ERROR | Variable "outputStream" is camel caps format. do not use mixed
| | case (camelCase), use lower case and _
320 | ERROR | Line indented incorrectly; expected at least 4 spaces, found 2
320 | ERROR | Variable "taskOptions" is camel caps format. do not use mixed
| | case (camelCase), use lower case and _
321 | ERROR | Line indented incorrectly; expected at least 4 spaces, found 2
322 | ERROR | Line indented incorrectly; expected at least 4 spaces, found 2
322 | ERROR | Variable "taskOptions" is camel caps format. do not use mixed
| | case (camelCase), use lower case and _
324 | ERROR | Line indented incorrectly; expected at least 4 spaces, found 2
324 | ERROR | Variable "taskOptions" is camel caps format. do not use mixed
| | case (camelCase), use lower case and _
324 | ERROR | Variable "imageURLPrefix" is camel caps format. do not use
| | mixed case (camelCase), use lower case and _
325 | ERROR | Line indented incorrectly; expected at least 4 spaces, found 2
325 | ERROR | Variable "taskOptions" is camel caps format. do not use mixed
| | case (camelCase), use lower case and _
327 | ERROR | Line indented incorrectly; expected at least 4 spaces, found 2
327 | ERROR | Space after opening parenthesis of function call prohibited
327 | ERROR | Variable "taskOptions" is camel caps format. do not use mixed
| | case (camelCase), use lower case and _
327 | ERROR | Space before closing parenthesis of function call prohibited
328 | ERROR | Line indented incorrectly; expected at least 4 spaces, found 2
329 | ERROR | Line indented incorrectly; expected at least 4 spaces, found 2
332 | ERROR | No space before comment text; expected "// "Error Calling
| | BIRT";" but found "//"Error Calling BIRT";"
332 | ERROR | Comments may not appear after statements.
333 | ERROR | Spaces must be used to indent lines; tabs are not allowed
333 | ERROR | Closing brace indented incorrectly; expected 2 spaces, found 1
334 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
335 | ERROR | Variable "outputStream" is camel caps format. do not use mixed
| | case (camelCase), use lower case and _
337 | ERROR | Inline comments must start with a capital letter
338 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
340 | ERROR | Inline comments must start with a capital letter
340 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
342 | ERROR | Closing brace indented incorrectly; expected 2 spaces, found 4
--------------------------------------------------------------------------------

Source: http://ventral.org/pareview - PAReview.sh online service
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.