Helper module for creating payment methods for Estonian banks. Creates signatures and forms wich other modules can use. http://drupal.org/sandbox/kaido24/1297894
Version: 6.x

Comments

sreynen’s picture

sreynen commented

Hi kaido24,

Ubercart projects often take a long time to be approved because few people know enough about Ubercart to do reviews. You may want to post on the Ubercart forum and request that people familiar with Ubercart come here and review your work.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Needs work

* Have you considered to add the functionality to an existing ubercart module? What are the differences to similar other modules and where do they overlap?
* Git release branch missing, see http://drupal.org/node/1015226
* README.txt missing
* module file: @file doc block is missing, see http://drupal.org/node/1354#files
* function documentation should not use '//' but '/**", see http://drupal.org/node/1354#functions
* info file: your module should specify its dependencies (ubercart, and others?)
* i think your module will need the PHP openSSL module, right? If so you should add hook_requirements() to indicate that dependency

kaido.toomingas’s picture

kaido.toomingas commented

Thanks for pointing those things. I started this project and after I saw this is much bigger than this looks.. I could use this more than one country thats the first thing..
Seems there are so many things to wich I should look.. I thought this throught.. This module shouldnt be even a module this would be better as library. If there is no general module wich could do the same. When I started I couldnt find.. Maybe there is.. And the main module wich I would like give to community is ubercart payment for Estonia.. Still it seems to be harder to share than I thought and maybe I'LL quit becouse this means me a lot and this is mentaly hard to wait and so un... :p.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

hi Kaido24. I'm sorry this process feels hard - I agree it's harder than it should be or could be for everyone involved. However these quality checks help ensure that the modules on drupal.org meet some important requirements which helps us all in the end.

I encourage you to fix the items klausi mentioned. The suggestion to look for ways to merge is just a suggestion and not a requirement. If it can't be joined then don't do it.

elc’s picture

elc commented

There are plenty of UberCart modules for the various payment gateways available around the world. If the Estonian banks use a different one to any of the already available ones, then this module would be quite useful to your fellow Estonians. Just being the Estonian payment gateway UC module can certainly be enough if it has a niche to fill.

Do these payment gateways (krediidipank, nordea, sampo, seb, swedbank) have some kind of name they give to their gateway protocol? My google foo and my non-existent Estonian speaking skills are failing me at present and I can't find this out myself. eg. Some Australian banks use MIGS - http://drupal.org/project/uc_migs

I don't have access to any Estonian bank gateways to completely test any of this out but I can look over the code to see how it ties in UberCart as I have a UC dev site I can repeatedly destroy. I can't give a timeline on that at present though.

Don't give up! We just want your contribution to be the best it can be so that your fellow Estonian UberCart developers will have the confidence that your module had the time and effort taken to ensure that it is the best.

kaido.toomingas’s picture

kaido.toomingas commented

Anwser for you both Greggles and ELC.. :)
Now after more digging I see this shouldn't be a module becouse this would really work for Estonian, Latvian and Lihtuanian banklink (payment method) systems.
2. This wouldn't change if Ubercart 7 or Drupalcommerce is in use. I mean only the info file will be changed.

About this uc_migs. This wouldn't work its kind of similar but doesnt do anything the same.. The form input naming isnt the same and there is no security settings stuff at this one.
I can give little review and say how these work.
For Estonian, and some Latvian and Lihtuanian banks we have to create forms into checkout review page with some fields wich are named the same for these banks. We should make post / get query for these banks (This module makes 2 different forms). Of cource these query should be secured and for this case we will generate some keys and stuff.
If you digg into code and look the documentation (wich is included later) you should understand this is very simple module (Im quite sure I'll take it off and make this as a library).
I would like to see you all digging this related module after I'll make the required changes and some other stuff. Ill make this for UC as I started. Separated module for Estonian people and maybe later, if this will be reviewed and so un Ill make this for Latvian and Lihtuanian also (for those wich I understood and got documentation from web).
Link for documentation example code from Latvia http://www.swedbank.lv/eng/pakalp/jr_3_7.php

elc’s picture

elc commented

The uc_migs was just an example of a payment gateway module that is needed to talk to Australian banks, and any others that use the MIGS protocol.

It sounds very much like your module does the same thing for the Estonian banks. If the Estonian banks also need all of this signing/encryption for that to work, it should be in the module or in a separate API module.

If my assumptions are correct, surely there is a place for your module as an Estonian payment gateway module for Ubercart?

jthorson’s picture

jthorson commented
Status: Needs work » Closed (duplicate)

It appears that there have been multiple project applications opened under your username:

Estonian payment API: http://drupal.org/node/1297942
Simple and fast facebook likebox: http://drupal.org/node/1225014

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue.

With this in mind, I have marked your secondary applications as 'closed(duplicate)', and left one application open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one I that I have left open, then please feel free to close the 'open' application as a duplicate, and re-open one of the other project applications which I had closed.

Thanks in advance for your patience and understanding!

Andreyy’s picture

Andreyy commented

Hi
Is module "Estonian payment API" already available for download ?

kaido.toomingas’s picture

kaido.toomingas commented

No and never will be.. This project is quite dead.. If you need estonian payment integration then you can send me a letter :)
Of course there is another project wich can do some good for you.. http://drupal.org/sandbox/kaido24/1297908

kaido.toomingas’s picture

kaido.toomingas commented
Issue summary: View changes

added version nr

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Estonian payment API » [D6] Estonian payment API
Issue summary: View changes
Related issues: +#1225014: [D6] Simple and fast facebook likebox