Closed (fixed)
Project:
EVA: Entity Views Attachment
Version:
7.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
4 Oct 2011 at 09:15 UTC
Updated:
14 Aug 2012 at 02:51 UTC
I've created a field collection with two fields of type text and float. If I add at least one value to it, I get the following error when rendering the corresponding node:
The website encountered an unexpected error. Please try again later.
If I disable eva, all works.
This looks similar to http://drupal.org/node/1292976, but I don't use node references, nor I get the WSOD. So I decided to create another issue.
Comments
Comment #1
akamaus commentedforgot to mention, site uses
Drupal-7.8
eva-7.x-1.1
entity-7.x-1.0-beta10
Comment #2
mirian commentedI've the same problem using Drupal 7.9. Have you find any solution?
It would help me too....
Comment #3
akamaus commentedYou may try to overcome this using panels. You can override node view template in page manager. Then you can add view on the resulting panel. I guess it should work.
Comment #4
tim.plunkettI couldn't track it down in field collection, moving to EVA for now.
Comment #5
kenyangzj commentedlooks like the code is incorrect on line 148 of eva.module
Notice that the variable $entity is never defined within the function, so return $entity don't seem to make sense here.
And after changing the line to return $build['#entity']; it works.
can someone verify my solution and make this as a patch?
Comment #6
mobonobomo commentedlooks like #5 worked for me, still reviewing - thanks ken!
Comment #7
jurriaanroelofs commentedI was just about to post this problem and fix in #5 but I see it won't be necessary. #5 fixed by Drupal commerce site that Im filling with an ubercart migration.
Comment #8
dropchew commentedAny plans to release this patch?
Comment #9
clashar commentedpatch #5 worked for me as well,
would be nice to commit it to dev.
Comment #10
clashar commentedkenyangzj, thank you!
Comment #11
tim.plunkett#5 is not a patch that can be committed, can someone create one?
See http://drupal.org/patch/create
Comment #12
Shellingfox commentedI see the author is add the code of #5 to the dev branch.
Current, using the dev version will fix this problem.
Comment #13
tim.plunkettThis was fixed in #1278742-5: Notice: Undefined variable: entity and EntityMalformedException, commit http://drupalcode.org/project/eva.git/commitdiff/77069a9e
That was 6 months ago.
Comment #14
tim.plunkettActually, let's leave this open, since this fix was the ONLY thing committed after 7.x-1.1, and there could probably be a 7.x-1.2 just to prevent more issues from being filed.
Comment #15
johnpitcairn commented2011-Sep-20 dev version (with this committed) fixes this problem for me.
To the maintainer: hey, how about a release with this fix?
Comment #16
quantos commentedI'm getting this error to trying to upgrade to the latest version too:
Undefined variable: entity in _eva_extract_entity_from_build()
PS Noobee (only 2 years lol) question is how to I upgrade to the 7.x-1.x-dev version? When I try I get the message that EVA is already installed. I have multiple, nested dependencies of EVA so I would have to uninstall the whole lot which isn't really feasible. I have backups so I guess I could roll-back and skip the EVA 7.x-1.1 version and go straight for the dev version?
The problem site/set-up here is an Omage/delta/context/Commerce build that uses EVA and Features.
Comment #17
mkadin commentedThe dev and 1.1 versions are close enough that you don't need to really uninstall anything. Simply delete the eva module directory and replace it with the dev files.
Comment #18
quantos commentedAh. Thanks mkadin. I didn't know you could do that. Much appreciated.
Comment #19
jnorell commentedI agree with the sentiments to release 7.x-1.2 with the fix for this.
Having just spent a good bit of time/frustration and finally tracking the issue to EVA, I was about to file an issue on this, as it breaks numerous places/modules on my site. I haven't even used EVA yet, I just had it installed because I intended to use it later.
I can confirm that the latest dev build fixed this error in the places I was seeing it.
This was fixed 10 months ago, please post a stable release to avoid this for others.
Comment #20
mkadin commentedI understand your frustration. This module has been essentially unmaintinaed for a good while, and I just recently became its maintainer. With so many sites using the module, I want to get a lot of testing in on the dev branch before releasing a new 1.2 release. If you feel so strongly about a new release, please help me and other EVA users by testing out some of the patches in 'needs review' and trying out the dev release and looking for bugs. A new release is coming soon, but I need everyone's help to make sure the release is stable enough for the 8000+ EVA installations.
Comment #21
tim.plunkettThe current dev code is infinitely more stable than the current release. The 7.x-1.2 should be tagged now, and the new patches can go into 7.x-1.3.
As a maintainer of many modules that get bogus bug reports because of this specific issue, please wait no longer.
Comment #22
mkadin commentedTim seems confident in the changes :) New release has been set up.