[meta] Media Browser Plus 1.0

I'm definitely in. I use folders branch of this module on few production websites, and I'd love to see this being a bit more stable and supported.

I also created a sandbox out of this, to add filters also on popup browser widget: http://drupal.org/sandbox/slashrsm/1294592. I'm prepared to create a patch out of it, if we want to pull this back.

Media is reimplementing it's browser with views. We could think about doing the same, if we decide that it's better this way. Any opinion about that?

Since we could keep folders branch a part of this module, I also think that we could move it to a separate module. I think that "advanced folders browser" support does not need Media browser plus to work properly. I would definitely support that, if it turns out that can we make progress faster this way.

I'm very excited about this!

I'm still very interested in this module. Happy to test, do UX-design, some patching if I can.
But for now I can't even get the latest version from Sebastian.Buesing's git to work with Media 1.x rc1, no folder creations anymore?

Try with sandbox from #1. It works for me.

I'm wondering, why aren't you on the list of "Committers"? http://drupal.org/node/952172/committers I've been using your module for months, and it's awesome! I just hope you know how much we appreciate your work.. :)

I'd like to help too.

#3 can't check it out: git warning: remote HEAD refers to nonexistent ref, unable to checkout. Could you look into it, I'm willing to test

It works for me. How do you clone it?

git clone --branch folders http://git.drupal.org/sandbox/slashrsm/1294592.git media_browser_plus

That sounds great. I think we should consider using tasks, that are originally accessible from drop-down above the browser. This tasks can be implemented using hooks AFAIK. In that case we implement really cool UI and allow other developers to easily add own actions to that.

How do you plan to go on with this? Will you merge folders branch to 7.x-1.x of media_browser_plus or start 2.x branch? I will probably start working on more flexible implementation on filters, that would allow one to search on any field. I was also considering to integrate it with Search API. That would allow us to use Solr or something similar for that.

It will be great if you start merging your code into this module, so I can prepare patches for thing I work on.

And the work will be based on media 1.x or 2.x?

In my humble opinion if you want to start from scratch, start based on 2.x media branch. (we could do a lot more things there since there is views integration)
For the 1.x branch just release the github version..its stable enough:)

slashrsm, thanks for your response, I posted my findings in your sandbox issue queue.

I can maybe look into the icons (#8), I'll keep you posted.

A stable version for media 1 would be useful, but I share the idea of rootatwc that 2.x has more potential for new features.

I'd like to see a simple View's-based browser. In our case in D7 we've added some taxonomy to our media nodes and would like to filter based upon those. Since this will be site specific, just being able to select a custom view to display/select media would be useful. Not sure if that is outside the scope, or maybe a different project. But it's something I'm looking into for Media 1.x integration.

Hi Sebastian, could you please give an update on the status of development? From what I read, development has been scattered all over the places. Some things can be found in sandboxes, others, like your repo, are on github. It's very hard to keep track. How about moving your development from github and other places to drupal.org, here we have full Git support after all, and it would make things a lot easier for people who want to use and contribute.

At this point I installed Media Browser Plus 7.x-1.0-beta3 along with Media 7.x-1.0-rc2, without effect. Did I do something wrong?

Why is there no 7.x-1.x branch and dev-release. In the repository browser I see 4 heads:

• master
• mbp-pre-1.0-stable
• mbp-pre-1.0-unstable
• folders

The last commit in that repo is from effulgentsia 4 months ago (2011-06-29). Your last commit on github was on 2011-09-22. Why not move development to drupal.org, this would enable everyone else to follow and maybe contribute. Everything unstable could go in a 7.x-1.x branch, everything depending on Media 7.x-2.x would go in a 7.x-2.x branch. I think this would make a massive difference and would make contributing a lot easier.

Creating those dev-branches and merging in code from github and the like, should be a matter of minutes. I'd also recommend updating the project page, maybe adding a link to the Media project and stating the dependencies of the current beta release (7.x-1.0-beta3) in respect to Media, i.e. 7.x-1.0-rc2 or whatever it is.

Thanks you all for the great work!

Hi again! Thank you for the feedback, I really appreciate it. I hope my noise included some signal too! ;-) I'm looking forward to your answers.

I completely agree with Pisco. I plan to develop some pathces soon and currently I do not have any solid repo to create patch upon and no place to pusblish it.

I could develop in my sandbox, but the more I do this, the harder it will be to merge my code back.

Should github branch work with file_entity versions of media?

How stable is github branch? Do you already have any list of critical bugs, that should be solved to make that branch stable?

Hi Sebastian

Thanks for the update, that's good news!

Instead of using names like github or mbp-pre-* I would strongly recommend adopting the Drupal naming conventions. A good source of information for module maintainers is the module maintainer's guide.

I've had a look at the current repo, turns out that these branches point to exactly the same version:

• master
• mbp-pre-1.0-stable
• mbp-pre-1.0-unstable

They all point to the version tagged as 7.x-1.0-beta3. This means that there are 3 different branches for exactly the same thing. I'm absolutely sure that there is no need for that. I suggest creating a 7.x-1.x branch, which should probably point at the version from the github branch. I'd then get rid of the master, mbp-pre-1.0-stable and mbp-pre-1.0-unstable branches. You absolutely don't need them and they are just distracting noise.

If you need help with that, don't hesitate asking.

Another thing I noticed while looking at your last commit from github, is that you really should follow the Drupal Coding Standards. If noticed a lot of trailing whitespaces, most code editors can be configured to remove trailing whitespaces when you save a file. I recommend turning that feature on!

Last but not least: two thumbs up for your work!

It should be great to see 2 dev version on this module home page

• 7.x-1-x.dev: Last dev version of slashrsm from its sandbox http://drupal.org/sandbox/slashrsm/1294592 compatible with Media 7.x-1.x
• 7.x-2.-x.dev: Branch actually named github from Sebastian compatible with Media 7.x-2.x

Actually i'm still using the Media 7.x-1.x-dev version to use the nice integration of plupload which gives the possibility to upload several files but also multi select ! in node edition from uplaod tab or "media browser" tab.

http://drupal.org/sandbox/pp/1244926

If you know an alternative which works also for Media-7.x-2.x-dev will be glad to know about it...

Any updates on this?

*I shall not post comments while travelling by train*

*I shall not post comments while travelling by train*

*I shall not post comments while travelling by train*

Here we go - I've worked through the whole code.
There were many essential violations of the Drupal coding-standards.
I tried to fix all of those, at least all I know of ;)
Besides this "cosmetic" changes there were and are some essential points related to best-practice and architecture.
Please scan the patch / changed code for the added @todo tags. I've pointed out some important stuff using these task-tags.

I think we need further refactoring to keep the code future-proof and maintainable.
I'm willing to help get this done - but I can't promise how much time I'm actually able to spend rewrite code.

Edit: Sorry for messing up the thread :|

Hello Sebastian

I'm more than happy to help with the short- and mid-term tasks. I know das-peter fairly well I think we could push the project a big step into the right direction. So I recommend you give both das-peter and me, at least temporary, commit rights. I think the first steps would be to adopt the Drupal naming conventions, so that a dev releases is available as soon as possible. I'm sure people will then start getting involved. Next step would be to get a (dev?) release that works with Media 7.x-1.0-rc2, also as soon as possible. I think if das-peter and I can help, it's way better than if nothing happens.

Thanks das-peter for the huge patch, I had to look through it with

to ignore the whitespace noise. Man, CRLF (Windows) line endings are a real no go. Looks good to me!

I have tested the github branch with the patch from #28 and it works well for me with Media 7.x-1.0-rc2. I think this should become the 7.x-1.x-dev branch. Thank you das-peter, you must have spent a hell lot of time reviewing the code!

@das-peter: Just a little remark, I don't agree with your syntax in

line 48. I think this

if (!media_browser_plus_access('media list view')
  || !media_browser_plus_access('media grid view')
) {
  unset($form['switch']);
}

should be written like this:

if (!media_browser_plus_access('media list view')
  || !media_browser_plus_access('media grid view')) {
  unset($form['switch']);
}

I also use das-peter's way and there is no reference on this in Drupal coding standards docs.
About the branches, yeah the naming conventions should be fixed asap,its ultra-confusing right now.
7.x-1.x for the current github version and 7.x-2.x a branch to work on,against media 7.x-2.x-dev

@Pisco & @rootatwc: Thanks for the feedback. Btw. Pisco is right, there is such a definition: http://drupal.org/coding-standards#linelength
Seems another check sneaked into the drupalcs - I'll fix that asap. :)

@Sebastian.Buesing: Sorry, but are you seriously nagging about the fact that I didn't recognize about an uncommitted change you made in a different issue?
The last change in the branch "github" was this one: http://drupalcode.org/project/media_browser_plus.git/commit/d2ff7b8 (Sun, 6 Nov 2011 13:39:51 +0000 (14:39 +0100))

We talked already a year ago - when we sponsored the development of this branch - about the coding standards. I'd bet we would find a internal ticket where this is mentioned.
But because this is a long time ago and I didn't do a detailed code review so far, my solely intention was to provide constructive feedback and thus bring a patch right away instead telling you RTFM again.

If there are open changes they have to be handled separate. I'm still willing to do reviews etc. but please don't expect miracles - as well as you are, I'm very busy too.

@Sebastian.Buesing: Thanks for the fast reaction and the clarification.

If the goal of this meta ticket is to find open issues / features I'd like to mention that the installation routine of the media module collides with the standard installation profile.
The media_browser_plus module is installed before standard_install() is executed. This means the taxonomy vocab "Tags" is already created by media_browser_plus which leads to an error in standard_install().
I'm not sure how we could fix that atm.

As far as I know we currently depend on this, still not committed, media patch: #1174374: Use a more specific selector to replace the add file link in the admin ui

I've just re-rolled the code style patch to fix the multiline if statements and pushed it into the "github" branch.

Two thumbs up for that! Waiting for #1174374: Use a more specific selector to replace the add file link in the admin ui to create the dev-branch. Then we can start filing issues against that version.

No need to wait this patch..thats why i opened and got this commited #1268672: Change remove() to hide() in media.admin.js.just use .show() and use the patch in mbp's js,till its commited in media (not to mention that it will take a while to have an media-7.x-1.0rc3 , imo)

and here is the patch

After Sebastian having pushed his patch, I replaced the Windows line endings (CRLF) with Unix line endings (LF) in all the JavaScript files. I also refactored and pushed rootatwc's patch from #43, which is a workaround for #1174374: Use a more specific selector to replace the add file link in the admin ui. After that I created a new branch named 7.x-1.x which should be published as a 7.x-1.x-dev release within the next 12 hours. I also updated the module description page: I added links to the Media module, and assigned Media Browser Plus to the Media category of modules.

We should soon start thinking about releasing an 7.x-1.0-beta4 release, but let's discuss that in a dedicated ticket as soon as the dev-release is out.

I suggest that we normalise the development and and bugfixing process by setting this ticket to fixed or closed as soon as the dev-release gets published. From then on, new tickets shall be opened as usual. Patches shall be provided for the 7.x-1.x branch. This should make things easier and hopefully encourage others to contribute.

@rootatwc: Thanks for the patch
@Pisco: Thanks for the organisation :) Sound like we've a plan now!

Yay!!
thanks Pisco:))

lets attack 7.x-1.x now:)

The 7.x-1.x-dev release from 2011-Nov-17 has been released. I'm setting this ticket to “fixed” and suggest opening new tickets for bugs, feature request and everything else that might pop up.

Great great news !!!

Good work all! Thank you!