Download & Extend
Homebox » Issues

Widths aren't printed in TPL if custom column widths are not set in homebox config.

Posted by lasac on October 5, 2011 at 7:34pm
Project:Homebox
Version:6.x-3.x-dev
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:reviewed & tested by the community

Issue Summary

There seems to be an error in the javascript:

Fout: $(this).parent(".homebox-column-wrapper").attr("style") is undefined
Bronbestand: http://dev.##.nl/sites/all/modules/homebox/homebox.js?x
Regel: 83

Seems to be already an issue with this but that is getting to cluttered. I will try to look in to this, but can not guarantee a fix.

Login or register to post comments

Comments

#1

Posted by brianV on October 5, 2011 at 7:41pm

Thank you for opening the new issue *as asked by the module maintainer*.

#2

Posted by brianV on October 5, 2011 at 7:48pm
Priority:critical» normal

Can you attach an export of you homebox?

My suspicion is that your column widths aren't properly defined, which is causing them not to print, creating the above JS failure.

Also downgrading priority as this works correctly on a stock Drupal site and my test sites.

#3

Posted by lasac on October 5, 2011 at 8:17pm
Priority:normal» critical

i have not defined widths, is that crucial? If so then that is a strange restriction since we then can not use css to alter the width.

#4

Posted by lasac on October 5, 2011 at 8:19pm

The settings page states that it is a optional feature:
Optionally set custom widths for each available region

defining widths does fix this, but this should be an option and not necessary.

#5

Posted by brianV on October 5, 2011 at 9:03pm
Version:6.x-3.0-beta5» 6.x-3.x-dev
Status:active» needs review

lasac:

I agree - that's not how it should work.

The expected behavior is that if width isn't defined, then it should default to (100/num_regions)% width for each column.

The attached patch should implement that - can you please test it?

AttachmentSize
1300656-set-default-column-widths.patch 536 bytes

#6

Posted by brianV on October 5, 2011 at 9:10pm
Title:attr("style") is undefined» Widths aren't printed in TPL if custom column widths are not set in homebox config.

#7

Posted by lasac on October 5, 2011 at 9:12pm
Title:Widths aren't printed in TPL if custom column widths are not set in homebox config.» attr("style") is undefined

No does not fix it.

Another issue is that we can not use decimals. But since we don't use pixels but percentage then decimals should work. 33.3% should be a valid width.

#8

Posted by brianV on October 5, 2011 at 9:21pm
Title:attr("style") is undefined» Widths aren't printed in TPL if custom column widths are not set in homebox config.

Looks like we cross posted.

Try this patch for the default case where no custom column widths are entered.

AttachmentSize
1300656-set-default-column-widths-rev2.patch 588 bytes

#9

Posted by brianV on October 5, 2011 at 9:22pm

lasac: I've created a new issue for decimals in column widths at #1300758: Custom column widths don't accept / preserve non-integer widths.. I've included a patch in that issue; I would appreciate it if you wouldn't mind testing it.

#10

Posted by lasac on October 5, 2011 at 9:37pm
Status:needs review» reviewed & tested by the community

latest patch fixes this.

#11

Posted by rbosscher on October 13, 2011 at 10:59am

#8 Fixed it for me too

#12

Posted by slybud on October 25, 2011 at 1:50pm

Patch in #8 also made my day and solved the issue : +1 for it

#13

Posted by foxtrotcharlie on March 1, 2012 at 4:18pm

Patch in #8 works for me too. Thanks @brianV