Hi there,

I've attached a patch with some small fixed. They resolve the following issues:
- #1289812: Images are saving as .tmp files instead of proper name
- #1300286: Titles are all the same (comment #1)
- Use $form[$key]['#access'] = FALSE instead of unset($form[$key]);

Regarding the option to edit fields after uploading, I found a small bug that deletes all setting when you change a node type.
_upload_nodes_rebuild_targets() did a if (isset($managed_target[$key]['settings'])) where it should be if (isset($managed_target['settings'])), as we're already in for loop (and thus $key is not known).

Solves the notice (http://drupal.org/node/1300286#comment-5080192) too

CommentFileSizeAuthor
#2 minor_improvements.patch24.96 KBBarisW
minor_improvements.patch2.87 KBBarisW

Comments

BarisW’s picture

BarisW commented

Oh, and I removed the PHP closing tags as well. They are not needed in PHP5.

BarisW’s picture

BarisW commented
StatusFileSize
new minor_improvements.patch24.96 KB

This is a better patch. I used the Coder module to make the code reflect the Drupal Coding Guidelines (uses of spacing, escaping, etc). Please use this one.

pyrollo’s picture

pyrollo commented
Status: Needs review » Fixed

Hello,

This patch is now committed !

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Link to http://drupal.org/node/1300286#comment-5080192