First off, thank you for taking up this project again.

The inclusion of a makefile certainly makes things easier, but in general, it's better not to specify a core at all. What you're publishing here is a profile, not a distribution. Check out how Open Atrium and Hostmaster do it. You just specify the required projects.

Once you publish a release, the d.o packaging scripts should bundle a core into the tarball, turning the profile into a distribution. By not specifying a core, you can then include multiple profiles on the same platform (code base), or swap out vanilla Drupal for something like Pressflow. See how Aegir builds a platform using the Hostmaster profile here, or my somewhat more complicated Open Atrium stub makefile using Pressflow here.

CommentFileSizeAuthor
#6 screenshot18.png115.55 KBrobloach

Comments

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
commented

Also, by just specifying just the projects that need to be included, they'll be put in the profile's modules folder (/profiles/drupalbin/modules/...), which will override those in /sites/all/modules, which is what you want for a profile.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented

@ergonlogic, thank you for the clear explanations. I carefully read again http://drupal.org/node/642116 and decided to go with multiple makefiles (http://drupal.org/node/642116#multiple-makefiles).

I removed Drupal core and the references to the profile itself from Drupalbin.make but left the geshi library.

I provided a drupal-org.make that bundles the distribution for downloading on the release page once a release is done.
This required to remove the geshi library because of the d.o license and redistribution restrictions.

Thank you for catching this issue!

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Assigned: Unassigned » robloach
Status: Active » Needs work

The commit can be seen here: http://drupalcode.org/project/drupalbin.git/commit/f3c0ee8c58833b93f8da7...

Rob, should we recreate the 6.x-1.x-dev release for testing this?

BTW, if it works, we could call it 6.x-1.0 and work on new features on 7.x-1.x ;-)

robloach’s picture

robloach
he/him
commented

The -dev release updates every night, I believe :-) . Been working on cleaning up the DrupalBin profile for 7.x by bringing in Features via http://drupal.org/project/drupalbin_feature . This way the configuration is persistent across different DrupalBin sites. Might help the build process...

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented

Ok, the dev release it's done and it rocks! http://drupal.org/node/241876

Just downloaded it, installed it, and once the user downloads the geshi libs works fine.

Now, let's port this to 7.x-1.x.

robloach’s picture

robloach
he/him
commented
StatusFileSize
new screenshot18.png115.55 KB

Check out drush make drupalbin.make...
screenshot18.png

Should definitely get drupal-org.make into the 7 branch though...

core = 7.8
api = 2
projects[drupalbin_feature][subdir] = contrib
projects[drupalbin_feature][version] = 1
ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
commented

Thank for working on this folks!

robloach’s picture

robloach
he/him
commented

Not sure why the Drupal 7 release isn't being built... The drupal-org.make isn't working for some reason...
http://drupalcode.org/project/drupalbin.git/blob/refs/heads/7.x-1.x:/dru...

robloach’s picture

robloach
he/him
commented
Assigned: robloach » Unassigned
Issue summary: View changes
robloach’s picture

robloach
he/him
commented
Status: Needs work » Closed (outdated)

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.