Evaluate and refactor exposed sorts on /groups listing

Glad that patch #228510 is no longer used. It introduced a bug breaking random sort.
See: http://drupal.org/node/228510#comment-5302740

Looks like we missed the groups_main_listing view. If subgroups are enabled, the view that was altered and committed, subgroups_main_listing, takes over the previously-mentioned view. So, things will seem fine, until subgroups are disabled.

Attached is a patch that fixes groups_main_listing, removes the broken handler from subgroups_main_listings as well as the unneeded sort criteria (since the table settings handle the sorts), and fixes a few other little things.

This patch will most likely conflict with #1272620: Remove unnecessary distinct from views, add caching to Views blocks.

In this patch maybe it's worth adding back the link you can see in comment #2 'Subgroups: 0' (i.e. groups/sub/%) into the subgroups main listing, in the transition to a table display it got overlooked.

Note the breadcrumbs in this view are a mess though - see http://drupal.org/node/1265636#comment-5358714

Also, it looks like you've put the leave link back into a separate column, was this intentional?

@@ -590,7 +557,6 @@ function commons_subgroups_views_default_views() {
       'description' => 'description',
       'created' => 'created',
       'subscribe' => 'subscribe',
-      'leave_group' => 'subscribe',

@ligthsurge: I'm not sure what you're talking about. There was a broken handler on both views which I removed. Is that what you're referring to? You are right, there is no child group count/link on there, but I see that's how it was before this patch as well - so I'm not sure where it belongs, if I were to re-add it. As for the "leave" field, is that the custom field we used to have in commons, which was a patch for OG, that's no longer in here?

lol I don't know what you're talking about either... what broken handler? I didn't see one last time I built commons from 2.x after the subgroup view was patched with this and then #1332352: Group directory buttons are inconsistently sized/placed, although there was one user in the latter issue who mentioned problems which might be something completely unrelated.

The patch in this thread was earlier than patch in #1332352 and just established the group directory as a table display (so if there were any sorts left behind then removing them is good).

The "leave" field is just the link to leave a group? Unless the subscribe/leave links are now the same and some sort of switch? News to me though.

Plus before the patch in this issue was committed, there was a child group count/link as seen in the screenshot in #2.

It looks like, as I suspected early in this thread, is that with 2.x, the patch that I originally created for OG, to add the "leave_group" views field, is now gone.

Here's a grep of 1.7:

$ grep -ri "leave_group" . --include=*.views.inc
./drupal_commons/modules/contrib/og/modules/og_views/og_views.views.inc:      'og_views_handler_field_og_leave_group' => array(
./drupal_commons/modules/contrib/og/modules/og_views/og_views.views.inc:  $data['og_uid']['leave_group'] = array(
./drupal_commons/modules/contrib/og/modules/og_views/og_views.views.inc:      'handler' => 'og_views_handler_field_og_leave_group',

And a grep of the current code:

$ grep -ri "leave_group" . --include=*.views.inc

Here's the issue/patch: http://drupal.org/node/1128492

What's strange now, is that this patch is in the drupal_commons.make file, but appears to not appear after the build.

And here's the PATCHES.txt inside og after the build, and it only lists:

/profiles/drupal_commons/modules/contrib/og$ cat PATCHES.txt 
The following patches have been applied to this project:
- http://drupal.org/files/issues/og-DRUPAL-6--2.views-constants.0.patch

This file was automatically generated by Drush Make (http://drupal.org/project/drush_make).

And this keeps getting weirder (at least for me).. I tried to manually apply the patch now, just to see what happens, and I get:

profiles/drupal_commons/modules/contrib/og$ patch -p0 < og_views-add-leave-group-field.patch 
The next patch would create the file b/modules/og_views/includes/og_views_handler_field_og_leave_group.inc,
which already exists!  Assume -R? [n] 

But, that file doesn't already exist..

Regardless of broken handlers, let's at least iron out the decisions that need to be made:
1) Which views, if any, should have the "leave group" field, and where, exactly?
2) Should, and if so, where, should the subgroup count and link be for the subgroups_main_groups view?

I just did a complete rebuild based on instructions from commons.acquia.com.

See attached.

I see the view include file that creates the field, the problem is that og_views.views.inc is *missing* the definition for it. Perhaps that portion of the patch is not applying correctly.

It shows empty because the view throws an SQL error, caused by the leftover functionality from the now-removed patch that provided exposed sorts. It's not shown because Commons defaults to printing errors only to the log. My patch fixes that issue.

Now that we've figured out the missing handler bit, I'll work that back into a new patch so it remains. And I'll figure out the best place to put the subgroups link.

Patch coming shortly.

New patch attached.

All the fixes from #6, added the missing "leave group" field to both views, and added subgroup column to listings.

I can never remember to change the status..