This is a part update to what I thought was happening yesterday (http://drupal.org/node/1305408)

You can repeat quickly doing:

  1. Create new content using the default Article content type in Drupal.
  2. On the node edit page, add a free-tag word using the default ‘Tags’ field.
  3. When you save the node, the Tag isn’t assigned to the node (however the Term is being created in Taxonomy).

If in Domain/Taxonomy settings ‘Vocabularies without domain access rules’ is set, the term should be indexed to the node? So it seems something isn’t being updated on the node edit form when submitted to attach the term ID to the node ID? (Unless this is the way it was designed?! Can you check?).

The other issue I will address later is for tags that HAVE domain access rules set. However the problem here is more urgent to address as it seems broken in not being able to add even basic Tags (that are excluded from the access rules and should work bypassing Domain Taxonomy?).

Have tested this on version 1 and 3 with same situation.

Cheers, Tim.

CommentFileSizeAuthor
#7 1054616-domain-taxonomy.patch569 bytesNick Lewis

Comments

Tim Jones Toronto’s picture

Tim Jones Toronto commented
Priority: Major » Critical

To update on this Tags issue above -

All terms being created in the Taxonomy CANNOT be deleted once created!

If you go into the Taxonomy and 'edit' the term, and hit 'Delete' the form just returns with the term edit page again. It DOESN'T delete the term!

The only info in the logs is 'page not found' - taxonomy/term/13. But the term is STILL in taxonomy!

It's like the terms became somehow orphaned with no index to delete them or display them either. So, again, suspect something 'missing' in the taxonomy of a tagged term (that isn't even set to use Domain Taxonomy in this case).

Hope this helps so far.

Tim Jones Toronto’s picture

Tim Jones Toronto commented

Regarding #1 - I think with all the stress testing I simply broke my system LOL.

So, with a clean version I will re-test and try to recreate the deletion of Taxonomy issue I was getting.

The priority however is some *basic* tests with the module and look at the orphaned Terms (ie. having no domain info set) which will fix a lot of the errors happening.

Tim Jones Toronto’s picture

Tim Jones Toronto commented

Hi, I wonder if you have had chance to check #1 out since creating free tagging where ‘Vocabularies without domain access rules’ doesnt work at all making this quite a serious error for even *basic* use in its current state.

Cheers, Tim.

Vyoma’s picture

Vyoma commented

@Tim, no, I have been a bit busy with hectic schedule at my day job.

Getting free tagging to work with domain access rules in play is tricky and that will take quite some time for me to figure out how to code it.

I agree that to get free tagging to work, having "Vocabularies without domain access rules" settings is required at the minimum. Unfortunately I cannot give any ETA yet.

Tim Jones Toronto’s picture

Tim Jones Toronto commented

Okay, no problem Vyoma.

The "Vocabularies without domain access rules" I am hoping is something fairly straightforward in the bypassing section of the code.

Tim Jones Toronto’s picture

Tim Jones Toronto commented

Any update on this?

Nick Lewis’s picture

Nick Lewis commented
StatusFileSize
new 1054616-domain-taxonomy.patch569 bytes

Was running into simliar problem. All vocabs seemed to get domain access rules even though I was checking them with "Vocabularies without domain access rules." I dug down into the code and found that the query function as inner joining with the domain_taxonomy tid table preventing any tid without a record from being returned. This patch simply changes the query to a left join.

This small change *appears* to have made this module usable again.

Nick Lewis’s picture

Nick Lewis commented
Status: Active » Needs review

patch above.

Tim Jones Toronto’s picture

Tim Jones Toronto commented

Thanks a lot Nick, will test it out.

skizzo’s picture

skizzo commented

Thanks Nick. Patch in #7 works for me (had to apply it manually due to "git diff header lacks filename information when removing 1 leading pathname components (line 5)" error. Please set issue to RTBC if you deem that everything is OK.

josebrito’s picture

josebrito commented

Patch in #7 works form me too. It should be included on next maintenance release.
Thank you.

Nick Lewis’s picture

Nick Lewis commented
Status: Needs review » Reviewed & tested by the community

Hate to bump my own patch, but seems appropriate. Fix is as easy as replacing the method "->join" with the method "->leftJoin" on line 567.

As stated above, ->join creates an inner join which limits results to terms with records in {domain_taxonomy} (in my circumstance, that was the vast minority terms). Using leftJoin removes that issue. There's still other issues, such as on admin pages, but that's another matter imo. This patch has no effect on those.

Tim Jones Toronto’s picture

Tim Jones Toronto commented

Confirmed patch in #7 works - thanks again Nick.

I have not heard anything from the maintainer, Vyoma, on this project since December 2011 btw.

Nick Lewis’s picture

Nick Lewis commented
Status: Reviewed & tested by the community » Fixed

Am now a maintainer. Patch committed to 7.x-3.x dev.

Tim Jones Toronto’s picture

Tim Jones Toronto commented

>Am now a maintainer.

Cool Nick, thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.