Hello,

I noticed your commits and wanted to give some feedback.

First, you don't need a license file so that should be removed. Also, you've got your .cvsignore file in there which can be removed.

Finally, your commit messages are a little bit brief. You should provide history always and credit where applicable - see http://drupal.org/node/52287

Comments

mtolmacs’s picture

Version: » 5.x-1.x-dev
Status: Active » Fixed

Mods have been made. I hope it is OK by now. Thank you for your feedback!

mtolmacs’s picture

Assigned: Unassigned » mtolmacs
Status: Fixed » Closed (fixed)
greggles’s picture

ok, one more bit of feedback...

Issues will automatically be moved from "fixed" to "closed" by a script that runs periodically. Once an issue has been left as "fixed" for a certain period of time (about two weeks) it gets moved to "closed" status.

People generally leave them as "fixed" state and let this script move them to closed because "fixed" issues will show up in the tracker. That way people who come to the issue queue for a project see things that have been recently fixed which can prevent them from submitting a duplicate.