When using the Link module with views the query string and fragment are not outputted the way expected. The reason this happens is because of a call to check_plain() that was added in this release. The line that was changed is line 412 in link.module

$item['url'] = check_plain($url);

Should be: 

$url = check_plain($url);

Or even better the check should be moved above the fragment and query string substr() calls.
The reason for this is because $item is passed in by reference so it screws up when hook_token_values() is called.

CommentFileSizeAuthor
#18 1309658-link-url-building-went-crazy.patch1009 bytesbarraponto
#4 1309658-query-fragment-missinng-from-token-5168680.patch853 bytespheme

Comments

pheme’s picture

pheme commented
Priority: Critical » Normal
dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented
Version: 7.x-1.0-beta1 » 7.x-1.x-dev

thanks for info, aris. can U pls re-check err with latest dev? = always better for committing to next release and preventing double commits.

pheme’s picture

pheme commented

Hi Digidog,
Thanks for your reply and sorry for mine being so late :) I have checked the code in the latest 1.0 release and dev version. The bug is still present. Please take a look at line 438:

$item['url'] = check_plain($url);

The above line should be moved to line 424 before the substr() calls are made.
Thanks,
Aris

pheme’s picture

pheme commented
StatusFileSize
new 1309658-query-fragment-missinng-from-token-5168680.patch853 bytes

Attaching a patch that fixes the problem. It's my first patch so please forgive any mistakes.

pheme’s picture

pheme commented
Issue summary: View changes

Updated because on second thought the check should probably be moved before the substring calls so the $item['url'] still benefits from the check

lsolesen’s picture

lsolesen commented
Priority: Normal » Major

Moving status to critical as a lot of the link is removed after ?. However, the patch does not solve the problem when there is & or other stuff in the link, as check_plain() will convert all & to &.

It is not only a problem with tokens. It disappears from all links.

dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented
Priority: Major » Normal

please stop tagging issues as major randomly here as along as there is no data loss or WSOD.

lsolesen’s picture

lsolesen commented

But there is loss of data. Lhe last part of the link is lost. Hence I think this should be tagged as a major issue - the last portion of a link like this is lost and not saved in the database.

http://example.com/index.php?menu=10&id=20

It happens when workbench_moderation is enabled. It saves correctly in revision_field_register_at when just saving the first time. When I hit publish the last portion of the link is removed in revision_field_register_at. And also in field_register_at.

Very strange!

summit’s picture

summit commented

Hi, patch http://drupal.org/files/1309658-query-fragment-missinng-from-token-51686... Solved for me also issue: http://drupal.org/node/1397978

May be you can look to the problem of #7, and then commit the patch please?
Thanks a lot in advance for your reply.
greetings, Martijn

ErikU’s picture

ErikU commented

The patch from #8 worked for me!

zach harkey’s picture

zach harkey commented
Status: Active » Reviewed & tested by the community

+1 Patch from #8 worked great for me too. I tried everything — kept thinking it was a views issue. Please commit this patch, query strings are an important part of a URL.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Committed to 8.x-1.x: http://drupalcode.org/project/link.git/commit/777434d581f4fe53ea16426cc5...

greenskunk’s picture

greenskunk
Location Great Valley, NY
commented

Are there plans for this patch to be committed to Drupal 7?

naeluh’s picture

naeluh commented

My issue is similar to this one but after applying this patch a new issue has begun

I have used this patched the link module with this patch

http://drupal.org/files/1309658-query-fragment-missinng-from-token-51686...

I have urls that are now working properly as far as the query and fragment not being trimmed

here is the url I am using - which appears fine in the field -

http://www.facebook.com/permalink.php?story_fbid=418032621562946&id=1323...

But when the link field is used anywhere it adds amp; after all the &

So now everywhere on the site

The url above appears as

http://www.facebook.com/permalink.php?story_fbid=418032621562946&id=1323...

As you can see it adds the amp;

It seems like its not encoding the &s properly ?

Please help !

I can provide any info that might be helpful thanks !!!!

I have opened this issue in a separate issue here http://drupal.org/node/1688420

Please let me know if I can provide any info that would be helpful thanks again!!

jcfiala’s picture

jcfiala commented
Status: Reviewed & tested by the community » Needs work

Yeah, the patch breaks links with querystrings, because the & in the querystring goes through check_plain and gets turned into &.

As such, I'm turning this back to needs work, and I suggest that sun take another look at the patch he accepted up there. :)

That said, I'm going to whip up a quick test and poke at this problem to see what's going wrong here.

jcfiala’s picture

jcfiala commented
Title: Fragment and query string disappear from tokens » Fragment and query string disappear from views tokens
Status: Needs work » Fixed

Okay, after battering around the issue for a bit and pouring through the code, I've got this fixed up in 7.x-1.x. Please have a look.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Committed corresponding follow-up to 8.x-1.x:
http://drupalcode.org/project/link.git/commitdiff/b1a7b0e1d35493e87ed2b4...

jcfiala’s picture

jcfiala commented

And... look! I managed to create a bug when the url was a relative link on the site. Because it was going through url() twice.

Yeah, so... new change updated.

Man, I wish I could get the simpletest to work on this windows box. I'm going to have to do some heavy testing when I get my hands on one of my virtual machines.

barraponto’s picture

barraponto
he / him
commented
Status: Fixed » Needs review
StatusFileSize
new 1309658-link-url-building-went-crazy.patch1009 bytes

Hm, in my experience, this bug makes the output repeat the fragments and queries. I think this is an easy patch, but let's try it out.

rallycivic’s picture

rallycivic commented

That patch fixed most of what I posted here:
http://drupal.org/node/1728098

Thanks very much!

The only problem left is that relative links come out like this in the node display:
...crm/event/participant%3Freset%3D1%26amp%3Bid%3D25%3Freset%3D1%26id%3D25

barraponto’s picture

barraponto
he / him
commented

@rallycivic can you try the patch at #1645640: Since <front> isn't implemented, take it off the project page until it is.? It probably fixes your other issue as well.

rallycivic’s picture

rallycivic commented

Yes, that patch solves it all - Thanks.

jcfiala’s picture

jcfiala commented
Status: Needs review » Fixed

I've pushed the fix on #1645640 up to the 7.x branch, so I think this will now be fixed as well.

Again, thanks, barraponto!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes