Even is the user has no (correct) IP_login-address, the auto-login link is shown. This is not necessary.
And when the link is used, an error appears.
Attache patch corrects this, including a micro-optimisation.

CommentFileSizeAuthor
ip_login_autologinblock.patch3.85 KBjohnv

Comments

jim kirkpatrick’s picture

jim kirkpatrick commented

As per #1303620: When correct IP-address is set, there is no auto-login, but only link 'Log in automatically'. something is broken in D7 it appears, but D6 is the 'master' for behaviour as it stands... Need to test both fully and see what the issue stems from.

In the mean time, thanks Johnv.

jim kirkpatrick’s picture

jim kirkpatrick commented

I've applied this with some corrections to form API bits...

Committed in D7 = 00c9240 and D6 = 065dd02, together with your work in #1303620: When correct IP-address is set, there is no auto-login, but only link 'Log in automatically'. and my work to add a new IP Login link-only block.

Thanks!

jim kirkpatrick’s picture

jim kirkpatrick commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.