This a Drupal 7 module meant for personal websites, where the webmasters wish to list their personal wishlists. It will only list an aggregate wishlist for the entire website and not user-specific wishlists.

The module will add the following to a Drupal 7 website:

  • 1 Node Type: Wishlist Item, which is used to create nodes to be displayed in /wishlist. The node type has fields for Product Type (Taxonomy), More Details (URL), Price (Text), Title, Description, Box Art, Banner Image, and Your level of desperation.
  • 1 View, with a Page display, which is used at /wishlist to display the list. It currently lists all your wishlist item according to your level of desperation.
  • 2 Image styles: 1 each for wishlist item's box art and in-page banner.
  • 1 Link item in the Main Menu
  • 1 Taxonomy called Product Type

More details at http://drupal.org/sandbox/kinshuksunil/1180102
Git repository at:
git clone --branch master kinshuksunil@git.drupal.org:sandbox/kinshuksunil/1180102.git wishlist

Comments

sreynen’s picture

sreynen commented
Status: Needs review » Needs work

Hi kinshuksunil,

How does this differ from http://drupal.org/project/wishlist? Please add a description of differences to your project page to help users select the most appropriate module. Also, remove the license from both the Git repository and the project page. Everything on Drupal.org has the same license, and that license is added automatically to all downloadable packages. Set this back to "needs review" when that's all fixed.

kinshuksunil’s picture

kinshuksunil commented
Status: Needs work » Needs review

I have made the necessary changes:

  • removed all license information.
  • Also added a section about "Difference from other wishlist modules" on the module page.

For reference, including that section here as well:

Difference from Other Wishlist Modules

  • This module is for Drupal 7
  • Meant for Personal websites or niche user websites (Family, very specific community)
  • simple listing of wishlist, no ecommerce involved
  • easy to maintain: you just keep creating nodes
  • extensible: since this theme works with basic drupal blocks like nodes, views and taxonomies, this module is very easy to build over and add workflows and functionalities
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Needs work
  • It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
  • Readme.txt should be README.txt, see http://drupal.org/node/447604
  • lines in README.txt should not exceed 80 characters
  • wrong line breaks in README.txt ('\r' but should be unix style '\n')
  • If you do not want to cooperate with the existing wishlist module you need a different module short name. "wishlist" is already taken, so you would have to rename all your files and functions.
kinshuksunil’s picture

kinshuksunil commented
  • created a branch 7.x-1.x and moved all development to it
  • Renamed and updated the readme file to README.txt and made it more readable
  • Fixed line length in README.txt to 80 characters
  • Fixed line breaks in README.txt: '\r' to '\n'
  • I am not a developer and cannot really contribute to existing wishlist modules. I am Drupal Administrator and since I needed a wishlist feature, created the functionality for myself and exported it for deployability through the Features package. I am now submitting it as a community contributed module hoping that others with D7 might find it useful too, esp for personal websites.

Will soon commit new codebase with a new project shortname. is "personal_wishlist" available?

kinshuksunil’s picture

kinshuksunil commented
Status: Needs work » Needs review
  • Moved project to shortname 'personal_wishlist'.
  • Made branch master empty and added notice in branch master pointing to clone branch 7.x-1.x
  • Branch 7.x-1.x updated to latest.

Please review for further changes.

13rac1’s picture

13rac1 commented

Reviewers: What is the community's stance on Features as projects?

kinshuksunil’s picture

kinshuksunil commented

IMHO Features are a good way to begin custom modules by non-programmers (like me), plus they really add deployability to functionalities. I think the concern should be more about the functionality and re-usability of the feature provided by this Feature/Module.

If this module can solve a purpose, why should it matter if it was exported through Features and not written from scratch as a module.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Postponed (maintainer needs more info)

Review of the 7.x-1.x branch:

  • Run coder to check your style, some issues were found (please check the Drupal coding standards):
    Severity minor, Drupal Commenting Standards, Internationalization, Drupal Security Checks, Drupal SQL Standards, Drupal Coding Standards

sites/all/modules/pareview_temp/test_candidate/personal_wishlist.features.user_permission.inc:
 +8: [minor] Comment should be read "Implements hook_foo()."

sites/all/modules/pareview_temp/test_candidate/personal_wishlist.features.taxonomy.inc:
 +8: [minor] Comment should be read "Implements hook_foo()."

sites/all/modules/pareview_temp/test_candidate/personal_wishlist.features.inc:
 +8: [minor] Comment should be read "Implements hook_foo()."
 +18: [minor] Comment should be read "Implements hook_foo()."
 +78: [minor] Comment should be read "Implements hook_foo()."

sites/all/modules/pareview_temp/test_candidate/personal_wishlist.features.field.inc:
 +8: [minor] Comment should be read "Implements hook_foo()."

sites/all/modules/pareview_temp/test_candidate/personal_wishlist.features.menu_links.inc:
 +8: [minor] Comment should be read "Implements hook_foo()."

sites/all/modules/pareview_temp/test_candidate/personal_wishlist.features.menu_custom.inc:
 +8: [minor] Comment should be read "Implements hook_foo()."

sites/all/modules/pareview_temp/test_candidate/personal_wishlist.views_default.inc:
 +8: [minor] Comment should be read "Implements hook_foo()."

Status Messages:
 Coder found 1 projects, 8 files, 9 minor warnings, 0 warnings were flagged to be ignored
  • Remove "version" from the info file, it will be added by drupal.org packaging automatically.
  • Remove "project" from the info file, it will be added by drupal.org packaging automatically.

This automated report was generated with PAReview.sh, your friendly project application review script. Please report any bugs to klausi.

In my opinion it is totally ok to have Features projects on drupal.org. The only problem that I see: how can we approve people that auto-generated the code of their project? How do we check that they are aware of http://drupal.org/writing-secure-code ? I opened a discussion at http://groups.drupal.org/node/186879 , until we reach a solution for this I mark this issue as "needs info".

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Title: Wishlist » Personal Wishlist
13rac1’s picture

13rac1 commented

I accept Features as Projects, but I don't believe we can safely give Project Promote ability based on auto-generated code. Further discussion on the group.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Component: module » feature
Status: Postponed (maintainer needs more info) » Needs review

assigning new component "feature".

espirates’s picture

espirates commented

Change Wishlist to Panhandling, that's what it really is lol hate it when people put up those lists. You want the items on the list buy them yourself. So sick of people begging for stuff on the internet, asking for donations for their cheesey blogs and such.

kinshuksunil’s picture

kinshuksunil commented

espirates: I find your comment personally offending. But right now, I am not interested in inciting a flame war, and so would refrain from replying to it.

klausi: what is the next step?

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented

The next step is a review from someone who sets it to "needs work" or RTBC.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Needs work

issues from comment #8 are still present.

misc’s picture

misc commented

@kinshuksunil has been contacted to ask if the application is abandoned.

After ten weeks with a status of needs work: the applicant may be contacted by a reviewer to determine whether the application was indeed abandoned. The action taken by the reviewer should be documented in the project application issue.

http://drupal.org/node/894256

misc’s picture

misc commented
Status: Needs work » Closed (won't fix)

The application has been closed. If you would like to reopen it, you are free to do so.
See http://drupal.org/node/894256#abandonedtwoweekscontact

prashantgoel’s picture

prashantgoel commented
Status: Closed (won't fix) » Needs review

the issues in comment http://drupal.org/node/1310702#comment-5177296 have been resolved and I am reopening this issue for personal wishlist to get reviewed.

Miszel’s picture

Miszel commented

Hi prashantgoel

Please change git repository in the Issue Summary to show the right branch.

After a quick look at http://ventral.org/pareview/httpgitdrupalorgsandboxkinshuksunil1180102git I can see that you still have a few minor issues. In particular:

Remove "version" from the info file, it will be added by drupal.org packaging automatically.
Remove "project" from the info file, it will be added by drupal.org packaging automatically.

Review of the 7.x-1.x branch:

  • Remove "version" from the info file, it will be added by drupal.org packaging automatically.
  • Remove "project" from the info file, it will be added by drupal.org packaging automatically.

FILE: ...view_temp/test_candidate/personal_wishlist.features.user_permission.inc
--------------------------------------------------------------------------------
FOUND 5 ERROR(S) AFFECTING 5 LINE(S)
--------------------------------------------------------------------------------
 13 | ERROR | Inline comments must end in full-stops, exclamation marks, or
    |       | question marks
 19 | ERROR | Inline comments must end in full-stops, exclamation marks, or
    |       | question marks
 25 | ERROR | Inline comments must end in full-stops, exclamation marks, or
    |       | question marks
 31 | ERROR | Inline comments must end in full-stops, exclamation marks, or
    |       | question marks
 37 | ERROR | Inline comments must end in full-stops, exclamation marks, or
    |       | question marks
--------------------------------------------------------------------------------


FILE: ...sites/all/modules/pareview_temp/test_candidate/personal_wishlist.module
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 7 | ERROR | "include_once" is a statement not a function; no parentheses are
   |       | required
--------------------------------------------------------------------------------


FILE: ...odules/pareview_temp/test_candidate/personal_wishlist.views_default.inc
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 13 | ERROR | Calling class constructors must always include parentheses
--------------------------------------------------------------------------------

Please help with the application queue to get a review bonus (http://drupal.org/node/1410826) so we can come back to your application sooner.

Miszel’s picture

Miszel commented
Status: Needs review » Needs work
patrickd’s picture

patrickd commented

@ Marcin Pajdzik please don't paste these ugly reports in here, a link is absolutely enough,
thanks for participation.

sureshG-1’s picture

sureshG-1 commented
Component: feature » module
Assigned: Unassigned » sureshG-1

Hai Guys , I choose ,PHP+DRUPAL Technology for my final year project ,so ucan u please suggest some ideas :)

patrickd’s picture

patrickd commented
Component: module » feature
Assigned: sureshG-1 » Unassigned

@sureshG
this is definitely the wrong place to ask for support.
please have a look at http://drupal.org/support

prashantgoel’s picture

prashantgoel commented

Hi Marcin Pajdzik and patrickd
Just followed the coding standards and now test run reports show no errors.
Kindly approve this feature.

sreynen’s picture

sreynen commented
Status: Needs work » Needs review

prashantgoel, be sure to update the status on issues.

ayushjn’s picture

ayushjn commented
Status: Needs review » Needs work

Hi, the module works fine. The following is my suggestion.
Please see that the name of the field in the content type Wishlist Item should not be "Category", it should rather be "Product Type" because "Product Type" has been used in the taxonomy and not "Category". Also add some documentation that we need to add taxonomy Product Category first and only then create the wishlist item; it is not self explanatory. No code related issues found, passed the automated review cleanly. Also, the URL field being compulsory is not self-explanatory, please add some description below describing its purpose.

ayushjn’s picture

ayushjn commented

Also, please change your git repository location detail from
git clone --branch master kinshuksunil@git.drupal.org:sandbox/kinshuksunil/1180102.git wishlist
to git clone http://git.drupal.org/sandbox/kinshuksunil/1180102.git wishlist.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.