Reviewed & tested by the community
Project:
Hide submit button
Version:
7.x-2.x-dev
Component:
User interface
Priority:
Normal
Category:
Support request
Assigned:
Unassigned
Reporter:
Created:
18 Oct 2011 at 13:33 UTC
Updated:
21 Feb 2018 at 01:02 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
optalgin commentedCheck the advanced tab under /admin/settings/hide-submit/settings
there is an option to "Exclude unlisted forms"
Comment #2
josebc commentedlooks like there is not implemented in the 7.x branch, i can work on it if no work is already beeing done
Comment #3
josebc commentedpatch for 7.x-2.x
Comment #4
josebc commentedComment #5
gregglesI like this approach in general, thanks for your work!
I wonder about "exclude unlisted forms" as a way to describe what the feature does. Maybe it could be described as "Only affect listed forms"? And then the text area description would have to change to be just something like "Form id list" so that it avoids the word "exclusion".
Comment #6
josebc commentedyeah i agree, here is a new patch with the changes
Comment #7
skyredwangI followed @greggles's breadcrumb from #1939426: I cannot Create new filter group , however #6 patch doesn't solve the original problem; tested on simplelytest.me
Comment #8
greggles@skyredwang - after you applied this patch did you configure it so it would be disabled in the views admin area?
Comment #9
skyredwang@greggles, no, I didn't. Not sure what form ID(s) I should use to exclude all Views. Maybe this feature can provide some common defaults?
Comment #10
gregglesI agree it should have some good defaults, especially for the views admin form.
It looks like the main views editing form is views_ui_edit_form.
Comment #11
josebc commentedactually i think we should add an "exclude from admin pages" checkbox that should be checked by default, since it will be hard to cover all the admin form cases
Comment #12
gregglesAs I was looking through views I saw a lot of forms where hide_submit would be valuable - the cache clearing, importing an exported view. I don't think "all of admin" is a good idea.
Comment #13
josebc commentedRe-roll for latest dev and fix possible xss issue, @greggles could you please provide a list of what could be considered as common defaults .
Comment #14
sumthief commentedHi all,
Reroll of patch from #13.
Fixed some moments (incorrect condition in hide_submit_form_alter()) and add some additional logic for real per form id functional.
Comment #15
sumthief commentedReroll of patch from #14. (Fix problem with features export).
Comment #16
qzmenkoComment deleted (wrong)
Comment #17
sumthief commentedReviewed and tested on clean Drupal installation and for me it works good.
Also there is small rework for the last patch.
Comment #18
sumthief commentedAdd inter diff.
Comment #19
philyThanks lot, patch #17 works with Drupal 7.56 and Hide Submit 7.x-2.4
I haven't tested it on many sites but it might be the time to port it ;-)
Comment #20
chaseonthewebPatch #17 doesn't work with the 'disable button' mode because of hide_submit.js:63:
'i' was the name of the variable holding the form id, and it's been clobbered in the .each() callback. The attached patch cleans up the ambiguously named 'i' variable.
Comment #21
mrpeanut commentedPatch from #20 works for me. Thanks!