Hi,

I have tried this with 5.x-1.x and 1.0. When adding an image via image assist, if I specify a custom size it overwrites the thumbnail, instead of creating a new derivative image. The image linked / displayed on the page's body is /files/images/picture.thumbnail.JPG, instead of /files/images/picture.img_assist_custom.jpg (which is the behavior in 4.7.x).

The result is a thumbnail that breaks the gallery page. I can regenerate the thumbnail by resubmitting the image node, but then that breaks the page containing the inline image.

thanks,
Dylan

CommentFileSizeAuthor
#3 thumbnail_clobber.patch745 bytesgrendzy

Comments

jaredwiltshire’s picture

jaredwiltshire commented

Yeah I have the same problem. Cept I dont think the thumbnail regenerates for me.

I would be very happy if this worked. Very useful feature.

travist’s picture

travist commented

I am also having this problem! It completely makes the gallery a mess.... this priority should be higher than normal.

grendzy’s picture

grendzy commented
Status: Active » Needs review
StatusFileSize
new thumbnail_clobber.patch745 bytes

I think I fixed it. Please test this patch and let us know how it goes.

tormu’s picture

tormu commented
Status: Needs review » Reviewed & tested by the community

I had the same problem:
I made a custom size (300x300 max) and uploaded an image (img.jpg) - it made the image for that custom size, img.topstory.jpg.
Then I viewed the same image with a bigger size tag, that had the width like over 400px.. but it made a new version of that img.topstory.jpg replacing the old one, and as said - breaks the layout wherever that custom size is used.

At least on my case this patch fixes it, thanks :)

jaredwiltshire’s picture

jaredwiltshire commented

Yep, this fixes the bug.

The whole way the custom size option is implemented could probably do with an overhaul though.

profix898’s picture

profix898 commented

This really needs to be committed. Pushing ...

ashtonium’s picture

ashtonium commented

RTBC

fairly straightforward & fixes the bug, thanks.

any possible re-working should probably be a separate issue, so that this bug-fix doesn't get held back any further.

zoo33’s picture

zoo33 commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks guys!

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)