When I do a fresh install, I get the following errors:
- Object of class stdClass could not be converted to string in /****/themes/garland/page.tpl.php
- Object of class stdClass could not be converted to string in /****/themes/garland/page.tpl.php
This is because $language is an object. Atached is a patch to adjust it to $language->language.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | garland_lang_0.patch | 856 bytes | dmitrig01 |
| garland_lang.patch | 734 bytes | dmitrig01 |
Comments
Comment #1
blakehall commentedfixes the issue for me too... > RTBC
Comment #2
Steven commentedThis change is not mentioned in the theme update docs:
http://drupal.org/update/theme
Is there a reason for this change? Why can't we just alter phptemplate.engine to compensate?
Comment #3
dmitrig01 commentedHere is a patch to phptemplate.engine
Comment #4
gábor hojtsySteven, as far as I see, it is important that themes have the full details of the current language used. At least they need the language code used and the direction of the language used. I could easily imagine that they might also need the language name and/or native name to display on the page. Even if Garland/Minelli themselfs are not made RTL-aware, other themes should not be without the opportunity. We can add distinct variables for every possible language property we envision to get used, but as far as I see, we are better off with passing on the language object.
Patch folded into http://drupal.org/node/128866 as per Dries' request. Steven, please follow up there. I can update the theme upgrade docs, once the final approach gets decided.