Apparently, og_subgroups places a "Members" pulldown select list on the group edit page. I've not found any settings for subgroups. Is there a way to remove the "Members" pulldown select list from this page?

CommentFileSizeAuthor
#2 og_subgroups_0.patch5.93 KBswood

Comments

swood’s picture

Currently, there is no way to turn that feature off. It probably should be added and given only to those with proper access. I'll look at making that change for the next update.

swood’s picture

StatusFileSize
new5.93 KB

I have added a 'edit subgroups members' access control permission to the og_subgroups module. This will allow you to define which roles can modify the member list. This controls both the members section on the edit form and also the members tab. I have committed new code but have also attached a patch (additional changes as well) that will address this issue.

somebodysysop’s picture

The real problem isn't who can add/remove subscribers, in my opinion. The problem is that every time you create a new group, EVERY user in the system is highlighted in this menu. So, you have to unhighlight them. This is relatively easy, but should not be necessary at all.

swood’s picture

I see the problem. The code that is building the form isn't paying attention to the group id. It is supposed to select those for the group if already defined, but when creating a new group it selects everything. In the og_subgroups_form, a test needs to be made for setting '$selected'. Here is the revised code. I will be issuing a new version in the next few days.


function og_subgroups_form($node) {
  $form = array();
  
  if (user_access('edit subgroups hierarchy')) {
    $selected = array();
	if (isset($node->nid)) {
      $selected = og_subgroups_get_parents($node->nid);
	}
	$form['parents'] = og_subgroups_parents_select(t('Parent(s)'), 'parents', $selected, $node->nid, array($node->nid));
  }
  
  if (user_access('edit subgroups members')) {
    $selected = array();
    if (isset($node->nid)) {
      $selected = og_subgroups_get_users('names',$node->nid,0);
	}
    $form['members'] = og_subgroups_members_select($selected);
  }
  
  return $form;
}


swood’s picture

Assigned: Unassigned » swood
Status: Active » Fixed

Fixed in og_subgroups 5.x-2.0

Anonymous’s picture

Status: Fixed » Closed (fixed)