Closed (duplicate)
Project:
Forward
Version:
7.x-1.2
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
24 Oct 2011 at 19:23 UTC
Updated:
11 Nov 2011 at 03:24 UTC
The forward (send to a friend) link grabs the wrong path for pages that are actually taxonomy terms. I am seeing this using the Service Links Module with Forward so I am not completely sure where the problem lies.
Example wrong path: mysite.com/forward?=taxonomy/cities-and-towns/dallas
Correct path should be: mysite.com/forward?=cities-and-towns/dallas
Since the link is wrong, the actual link that gets sent in the email is also wrong, so when the recipient tries to follow it, they get a 404.
The link seems to be correct for every other type of entity. Only taxonomy entities seem to affected by this incorrect path.
Comments
Comment #1
john.oltman commentedOk, I will check this out and see what is happening.
Comment #2
john.oltman commented@swirt, can you provide a little more info - are these nodes you want to forward, or non-node pages? If possible, a link to your site where I could see the problem would be helpful. Thanks!
Comment #3
jenlampton@john.oltman taxonomy term listings are non-node pages.
Comment #4
john.oltman commentedHi @jenlampton, yes, reading this again it seems clear Dallas is a term and not a node teaser being listed on a term page. Thanks, I will take another look.
Comment #5
john.oltman commentedThe Service Links module doesn't appear to output a link on a taxonomy term page. It will output a link for each listed node or node teaser, but it doesn't output a single non-node link that would forward the term page as a whole. If you have such a link on your site, it most likely means that you have a custom page template for taxonomy term pages that includes custom code to generate a forward link for the term. You should inspect that code to see what it is doing - my guess is it incorrectly includes arg(0) when it is building the path for the forward link. You basically want to do a drupal path alias lookup for the taxonomy term path and use that.
If the link in question is generated by the Forward: Form block, please install the latest version of Forward, version 7.x-1.2. It has important fixes for the Forward blocks.
If you have information that differs from the above, please re-open this issue and post the site URL or some sample code from the page template or any additional info that would help. Thanks.
Comment #6
jenlampton@john.oltman the service links module has a block "Service links for non-node pages" that can be placed onto any page on your site. That, plus the "forward services" module allows you to add forward links on non-node pages (like taxonomy term pages).
Comment #7
john.oltman commentedOk, now we're in business. I see the Service Links block. The issue is in the Service Links module. Please report this in the Service Links issue queue so the module maintainer can work it over there.
Comment #8
jenlamptonIt looks like there's already a patch for review at #1317300: Forward from a term page link is incorrect
Comment #9
john.oltman commentedThanks, marking this one as a duplicate.
Comment #10
john.oltman commented@jenlampton, let me know how that other patch works out. If it exhibits the issue with the forwarded page title not displaying properly, I will re-title this issue and reopen it.