| Project: | HTTP Parallel Request & Threading Library |
| Version: | 7.x-1.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
#997648: drupal_http_request() always calls fread() one more time than necessary
#164365-12: drupal_http_request() does handle (invalid) non-absolute redirects
#205969-11: drupal_http_request() assumes presence of Reason-Phrase in response Status-Line
#371495: Error message from drupal_http_request() not UTF8 encoded
#193073-11: drupal_http_request - socket not initialized
#106506-8: drupal_http_request() does not handle 'chunked' responses
#1096890-15: drupal_http_request should return error if reaches max allowed redirects
#875342-21: drupal_http_request() should pick up X-Drupal-Assertion-* HTTP headers
#965078-31: HTTP request checking is unreliable and should be removed in favor of watchdog() calls
#336367: HTTP client should protect commas when folding (compatibility with legacy HTTP/1.0)
#45338: log fsockopen errors to watchdog
Comments
#1
This patch is for #193073-11: drupal_http_request - socket not initialized
#2
http://drupalcode.org/project/httprl.git/commitdiff/d616895ef9e10e3dd437...
http://drupalcode.org/project/httprl.git/commitdiff/fa3cdb5a6f9404bb138c...
#1 has been committed. Keeping open for other issues.
#3
Patch that is inspired by #164365-12: drupal_http_request() does handle (invalid) non-absolute redirects
#4
Patch that is inspired by #371495: Error message from drupal_http_request() not UTF8 encoded
#5
patch inspired by #205969-11: drupal_http_request() assumes presence of Reason-Phrase in response Status-Line
#6
patch inspired by #1096890-15: drupal_http_request should return error if reaches max allowed redirects
#7
#3, #4, #5, and #6 have all been committed.
What's left:
#997648: drupal_http_request() always calls fread() one more time than necessary
#106506-8: drupal_http_request() does not handle 'chunked' responses
#875342-21: drupal_http_request() should pick up X-Drupal-Assertion-* HTTP headers
#336367: HTTP client should protect commas when folding (compatibility with legacy HTTP/1.0)
#45338: log fsockopen errors to watchdog
#8
forgot a semicolon in one of the last patches that was committed. This patch has been committed.
#9
patch inspired by #336367: HTTP client should protect commas when folding (compatibility with legacy HTTP/1.0)
#10
#9 has been committed and I've created #1357482: Handle chunked and compression.
#11
follow up for #10 that fixes a php notice. This patch has been committed.
#12
Automatically closed -- issue fixed for 2 weeks with no activity.