Closed (fixed)
Project:
Project issue tracking
Version:
5.x-2.x-dev
Component:
Issues
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
20 Nov 2004 at 15:27 UTC
Updated:
17 Oct 2007 at 02:11 UTC
Jump to comment: Most recent file
Comments
Comment #1
killes@www.drop.org commentedI am pretty sure this is a project module bug. Maybe even by design.
Comment #2
gábor hojtsyWell, it would be quite sad, if this would be by design... People are interested in issues they "replied to", much like they are interested in content they replied to.
Comment #3
tangent commentedThe problem, apparently, is that the project module has its own comments table. Why this is the case is not clear (presumably it was the only solution when developed). It seems like it would be best to refactor issue comments into the comments table.
Comment #4
tangent commentedA negative side-effect of having issue comments (or "followups" in project terminology) in a separate table is that replies can be "commented on" unless the option is disabled in the workflow settings or in the "user comments" settings of the issue.
Comment #5
tangent commentedI just realized that issue comments were implemented this way so that file attachments may be added to them.
I have reached the conclusion that comments should be implemented as nodes and use node relationships instead of existing in a separate table (not *just* for this issue). This is off topic though so I will leave it at that for now.
It would take hacking the tracker module to support issue comments or adding a hook of some sort to resolve this issue without refactoring the project module greatly. I guess this issue should be either postponed or wontfixed.
Comment #6
junyor commented@tangent: Shouldn't the file attachments be handled by upload.module? If it doesn't allow attachments to comments, it should be extended to do so. Then, project comments could go into the comments table and this problem would be solved.
Comment #7
tangent commentedI'm not sure I agree with extending upload.module to support file attachments for comments. This would solve the symptom but I think the fact that comments are treated as a different kind of submission is the root problem.
Comment #8
pfaocleDuplicate of http://drupal.org/node/27430. This is down to Project module using its own code for 'follow-ups' instead of using Drupal core's comments.
Comment #9
tangent commentedBecause this issue is much older and actually documents the reason that project.module is designed the way it is, this issue is NOT a duplicate. The other issue is the duplicate. Please don't change the status.
Comment #10
dwwfor what it's worth, this is a major drupal.org usability problem in my view. i'm not a core drupal developer, so i can't fix this myself, or install a patched version of tracker.module on drupal.org. ;) but, i'd like to add a +1 for fixing this one way or another. i've been doing a fair bit of following issues in a few of the modules i'm making heavy use of on my own site, uploading patches, etc. it's a huge pain that my "track" tab only shows issues i started, not issues someone else started that i replied to, attached a patch to, etc, etc. if there's anything i can do to actually help get this resolved, i'd be willing to help. i just need someone in a position to do something about this to say what actually needs to be done, and then i could take a stab at a patch for it.
thanks,
-derek
Comment #11
nedjoAs tangent noted, the issue comes from the fact that project.module uses its own version of comments, rather than the core comment.module. Tracker checks for recent posts where either the node or one of its comments (read: records in the comment table, put there by comment.module) is by a given user. So the (non-core) project module comments don't register.
There's not an obvious, easy solution. Tangent has noted some possible approaches, which would take some work.
Comment #12
nedjoWe already have a 'My issues' link in the contributors block, but I'm thinking it only shows issues the user has started. We could simply extend this to include issues the user has participated in too. (And, optionally, we could add a local task/tab to tracker, leading to this 'My issues' page.)
Comment #13
tangent commentedIf tracker.module is updated to handle issue comments (which is probably the best/only short term solution) then I think it makes more sense to add logic to handle project.module comments instead of adding another tab to the profile page.
Comment #14
junyor commentedI'd really just prefer we change project.module so it doesn't need its own comment system. I think the big problem there is making it so comments can have file attachments. I hope that will happen in 4.8.
Comment #15
dwwthe project module's "follow up" comments have other differences from regular comments aside from the ability to attach files. for example, in a follow-up, you can change the status, category, priority, etc of the issue you're commenting on. it's a weird mix of a comment on the original text, and ways to edit the underlying node (issue in this case). so, i'm not sure how easy it would be to get all of that working again with the default node comment type, which has no notion of changing the node it belongs to (for good reason).
however, it sounds like some of y'all are talking about only starting to fix this issue in 4.8. not knowing much about the drupal release cycle, i'm guessing it'll be at least months, if not over a year from now before drupal.org is actually running a 4.8 version of itself. that seems like far too long to put this off. i'd definitely vote in favor of extending tracker.module to know about project/issue/followups in the mean time.
i agree w/ tangent that it should just be handled in the regular "track posts" subtab under "track", not as a separate "my issues" tab. i don't think the average user cares much if their comments were in a forum, a book, or project issue, they just want to see them all in one place. ;)
never having looked at the tracker.module code at all, i have no idea how much work it'd be to get it to understand followups. i'd be happy to try, but i suspect other, more tracker-clueful people around here could do a better job in less time. however, i'm already wasting a fair bit time doing my own out-of-band tracking of issues i've replied to. so, in the long run, it'd save my own time if i could spend a few hours and get this working (maybe that's an overly optimistic estimate). are there any tracker experts here who a) agree this needs to be addressed now and b) are willing to work on the patch? i'd be more than happy to help in whatever ways i could (testing, whatever). if no one steps forward, i'll see how much progress i can make in a few hours and reply here.
thanks,
-derek
Comment #16
tangent commentedHere's a preliminary attempt at patching tracker to handle issue comments. Unfortunately, I can't really test it that well since I believe drupal.org is using a custom project.module. If someone can test this in a sandbox running the drupal.org code that would be nice.
Comment #17
tangent commentedI shouldn't have added t() to the class argument :-)
Comment #18
nedjoThanks for the patch tangent, it's a good model for a solution. As a rule we don't test for non-core module support in core. We would need to find a way to do this less intrusively in tracker.module. I've tried to think of one, but not come up with anything yet. Possibilities:
* introduce a new hook
* use db_rewrite_sql() to alter the query
The best solution, it seems, would be to move forward with refactoring project.module to use core comments. This refactoring could be done right away (provided it didn't require changes to core).
Comment #19
gábor hojtsyIt is absolutely unlikely that a core patch now goes in for tracker module, adding a new feature. The best someone can do now is to add that new tab to the user page where one can review the issues and followups he made. It is not ideal, it is not the most user friendly solution, but it should work, and it is possible to do. Patching tracker now, and especially including such code in the 4.7 release is impossible.
Comment #20
tangent commentedTo be honest, I don't think anyone cares if the module gets updated in core. I don't. It's the code running on Drupal.org that is causing the pain. It is my understanding that Drupal.org is already running customized code and not release code so adding this patch on the live site won't change that.
For all the rest, I agree with everyone's statements that this isn't an appropriate solution. However, I think that living with this problem for the next 1-2 years until the ideal solution can be implemented in project.module is a bit much to expect.
Comment #21
gábor hojtsyYes, this is why someone should add that new tab in project.module without touching other code. Asking for the project module to use comments to solve this problem is what is much IMHO. This was asked so many times in the last *years*, and nothing happened. Someone needs to take the helm.
Drupal.org is not supposed to use customized code, and IMHO it is not doing so. It surely extends Drupal at several points, but not modifying code. The tradition is that drupal.org runs on latest Drupal code. Now the upgrade is a bit more complicated given all the form api hassles.
Comment #22
pfaocle[My Issues now shows](http://drupal.org/node/52617) all issues both posted and replied too now, which is the best we're going to get until issue follow-ups become 'real' comments.
Comment #23
dwwthere's not really a patch here that can be considered for review anymore. this problem is basically blocked on the task of converting project to use comment.module. see http://drupal.org/node/18920 for extended discussion on that.
Comment #24
dww(those weird special characters in the title were driving me nuts). ;)
Comment #25
jarea commentedI take it that even with the supposed changes mentioned in http://drupal.org/node/13221 that this is not going to be implemented for drupal.org?
Comment #26
dwwi don't follow your last comment. you're linking to this same issue (#13221).
this *will* happen, even on drupal.org. however, as i explained above, it's just blocked on some other tasks. hence the status "postponed". ;)
-derek
Comment #27
jarea commentedDerek - sorry I meant node/52617
I do now see that I cannot see issues initiated by others where I have posted on the "My Recent Posts" tab, but I can see the last 12 issues, regardless of who initiated the issue on the My Issues link to the side. It would be nice to see farther back than 12 items, but that lament has already be posted.
Jim
Comment #28
dwwjarea: if you go to http://drupal.org/project/issues/user you can see all the issues. the "pager" links at the bottom all work, so you can scroll back through as many of them as you want -- there's no limit of 12.
the main thing that doesn't work yet is that you can't filter with the UI elements at the top of the page and still retain the fact that you only want to see *your* issues. see http://drupal.org/node/56200 for more on this.
that said, i'm still planning to convert issue followups to become real comments (as discussed earlier in this thread) so that issues you participate in *will* show up directly in your user/xxx/track page, as well.
Comment #29
jarea commentedDWW - thanks for the clarification. I guess I just have 12 issues to track - newbie.
Comment #30
aren cambre commentedHi, all. Just wanted to say that this remains a problem almost 3 years after it was reported. Just letting you know so that the issue still remains relevant. A duplicate at http://drupal.org/node/174265 was closed out.
Comment #31
dwwComment #23 above points to http://drupal.org/node/18920 which is the real change needed -- that issue is under active development as one of the most important patches for project*. That's where you can be helpful.
Comment #32
aren cambre commentedhttp://drupal.org/node/18920 has been resolved. That should allow progress on this issue to resume.
Comment #33
dwwCheck out http://scratch.drupal.org/tracker/46549
s.d.o is running the latest 5.x-2.x-dev code, now that http://drupal.org/node/18920 was committed. You'll see the tracker behaves exactly as you'd expect, even for issues that other people created which you replied to...
There's nothing more to do here -- now that followups *are* comments, the tracker Just Works(tm).
Of course, there's still a little more work to do before 5.x-2.x-dev is deployed on d.o itself, but there's no reason to keep this issue open anymore. If you want to help, test s.d.o...
Comment #34
gábor hojtsyWoooow! Thanks for making this happening finally :)
Comment #35
dwwMost of the praise should go to chx and hunmonk... ;)
Comment #36
aren cambre commentedhttp://scratch.drupal.org/tracker/97356 and http://scratch.drupal.org/user/97356/track do not show this issue even though I have replied to it.
Comment #37
dwwsorry, s.d.o is temporarily broken while we re-sync the database for a final test of the DB upgrade that converts issue followups to real comments. but, trust me, this issue is fixed, and will be visible on d.o soon...
Comment #38
aren cambre commentedCorrect. YAY!!!
Comment #39
(not verified) commented