It would be nice for theming if there were CSS classes on the pause button that indicate the current active state (playing or paused). This would be handy if the buttons are themed with play/pause images.

CommentFileSizeAuthor
#1 1322780-1-views_slideshow-pause_button_classes.patch1.57 KBpfrenssen

Comments

pfrenssen’s picture

pfrenssen
Location Sofia
commented
Title: Provide CSS classes for pause button that toggle on click » Provide CSS classes to indicate the status of the pause button
StatusFileSize
new 1322780-1-views_slideshow-pause_button_classes.patch1.57 KB

This simple patch adds the class 'playing' or 'paused' to the button. My javascript-fu is not exactly stellar, so I'd be glad if someone could give it a look.

pomliane’s picture

pomliane commented
Status: Active » Needs review

#1353994: Add "paused" class to controls for theming marked as duplicate of this issue.

ckng’s picture

ckng
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Tested and the code looks fine.

scottrouse’s picture

scottrouse commented

I can also verify that this works. I'd love to see this in dev.

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented

Worked for me too. Thanks.

robwithhair’s picture

robwithhair commented

Patch works for me. Would be good to see this in the release.

cwithout’s picture

cwithout commented
Status: Reviewed & tested by the community » Closed (fixed)

Appears there's a fix for this in the current dev using classes "views-slideshow-controls-text-status-pause" and "views-slideshow-controls-text-status-play".

pfrenssen’s picture

pfrenssen
Location Sofia
commented

This has been fixed in Commit 3de5104d9: Add a class to the pause/play control to know what the status is.

Jance’s picture

Jance commented
Version: 7.x-3.x-dev » 7.x-3.0

I see this is working on the Dev side, but I was wondering if there was a possibility that this code could get pushed out to the production trac.