Closed (fixed)
Project:
ShareBar
Version:
6.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
28 Oct 2011 at 04:28 UTC
Updated:
4 Jan 2014 at 01:11 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
carvalhar commentedi need it too
Comment #2
nmudgal commentedI have created the version 6.x of this module ... It is in working condition. Attached the patch. All one has to do is to assign the block to the region & it will be shown up ... It may or may not have security risks though but it's a work in progress. Since I have created block for it & have put so did some css changes so the given configuration options related to css in settings are not currently working as they are being overridden.
Please let me know any concerns.
Thanks
Comment #3
carvalhar commentedthanks! it worked. i had to comment the if on line 155 and edit the css
Comment #4
nmudgal commentedOkay cool. In which file you had to comment if? What exactly your requirements were with css you had to tweak [screenshot will be helpful to understand ...]
Thanks
Comment #5
carvalhar commentedat sharebar.module, line 155 the if that detects which service should be printed (nothing was being printed).
my css was edited to position better the block and the ul as absolute, i think this part is specif of my install.
thanks
Comment #6
rastarr commentedUmmm, no idea about getting .diff files to work. Way too techo for me unfortunately.
Any help with a set of install files?
Does this iteration also do the hover while the page scrolls?
I'm wanting this now more than ever for v6 :)
Comment #7
nmudgal commentedThis may help, just follow the instructions http://drupal.org/project/diff/git-instructions
Didn't really get what you mean by this?
This patch is little buggy, yeah that was in my queue [ install files ]
Thanks.
Comment #8
rastarr commentedI'll check out the instructions link - thank you for that.
On the hover thing, I notice in the example on the SocialSEO page that the entire toolbar remains in the same place on the page, despite scrolling the page. Is this a part of the module as well as working in the v6 diff?
Comment #9
nmudgal commentedno that's not part of either v6 or v7. but can be done by tweaking sharebar.css file easily ...
but can be achieved by fixing position & making some changes according to your requirement where you want it to be fixed.
I have something like this :
Hope this helps.
Thanks.
Comment #10
rastarr commentedSweet!
Thank you so much for that - I hadn't gotten to sussing that part out since the module was only v7.x - nice to know it is easy to do though.
I'll be really interested when you get to the install files though - that whole diff thing is something outside my skills, didn't really understand which is fine. I'll use a little patience.
It's a fantastic looking module.
Comment #11
rastarr commentedWell, I finally sorted out the Git stuff successfully :)
Added the block to a nav bar and nothing displays except for a small horizontal line.
Is the line 155 thing suggested at http://drupal.org/node/1324470#comment-5222512 by carvalhar have any impact at all?
I also note that Google+ isn't included in the package nor is there any radio buttons for choosing the content types that ShareBar is activated within. I'm unsure whether these are simply not included in the current Git release or whether they were removed or changed in the diff, in some way.
Any help, as always, very appreciated.
Martin
Comment #12
nmudgal commented@rastarr may be that is because of some css issue. You may need to tweak css according to your requirement. Don't think that line would be causing any impact for you. Yes google+ wasn't included as this wasn't in d7 release & neither was feature to choose content type so didn't put them in d6 release too.
If you could give me more details of issue than probably I can help.
Thanks.
Comment #13
rastarr commentedHey thanks heaps for helping.
The module is a direct install with no file changes.
I've tried adding in some of your CSS but that makes no difference. I can see the CSS file is loaded, I've cleared the cache too. I'm a little stumped at this point. You can see the grey line in the small image attachment.
I've added the sharebar block to forum pages so you're able to see this weirdness and where I snapped the attached snippet over on my site HERE
As for Google+, that would certainly be a great addition to the bar options. Is that an option that can be added, do you know?
Again, really appreciate your help. The Sharebar looks fantastic for increasing sharing and therefore engagement.
Comment #14
nmudgal commented@rastarr thanks for pointing out issue. I had a deep look, while values were being printed it had some issue, missed something actually. So resolved that & attached is patch. You might have to revert the last patch [ how to -> http://drupal.org/patch/reverse ]. You may still need to tweak css according to your requirements.
Let me know any issues you face.
Thanks.
Comment #15
rastarr commentedthere's something weird with that diff file in trying to download it - it might be the # in the filename
Comment #16
nmudgal commentedAh my bad!
Comment #17
rastarr commentedThat's a better diff :)
I still need to determine the CSS rubbish which will be cumbersome as I stumble around in the dark
That said, is your FB Like count showing up on all pages with the same number? Mine's 41 which I think is polling the site's root URL as opposed to the page URL.
Comment #18
rastarr commentedFurther, the Sharebar Facebook uses a variable of
[url]for the URL string. I've tried a Token in there which wasn't recognised ... dammit :)The Digg button was absent as well. There was a minor typo in the Medium button code where the 'SCRIPT' was mistyped as 'SCRIPT\ ... works now.
Still no luck on CSS or Floating the bar yet. Any help on that would be appreciated too
Comment #19
nmudgal commentedYou can change the fb code from here if you like http://developers.facebook.com/docs/reference/plugins/like/
Digg button is theret. you can configure the codes of button from admin/settings/sharebar/setting
And to float it on every page you will need to define some region or something in your theme & fixing it's position irrespective of page scrolling via css. The code I pasted in comment will help.
And yeah this modules needs lots of work :-P
Comment #20
rastarr commentedYeah, I think I'll ditch this module, for the moment.
Way too much to do to get it working and it appears the developer isn't active at all, which is a pity as it looks like a great little module.
Comment #21
didiercastelnau commentedI just discovered this ShareBar at ThemeSnap.com and now in D6 project... Great! very happy to see some people worked on that, as it's great for UX and very common with wordpress. I'll test it asap.
Comment #22
SocialSEO commentedHi,
My apologies for being away and not in some way active in this thread. We built the Drupal 7.x ShareBar module and was contacted by user nmudgal as a courtesy to let us know he was working on a Drupal 6.x port of this module as well. Originally, we were only working on the Drupal 7.x version of this module to actively support and did not have plans to maintain an older Drupal 6.x version.
However, I do have the code for the Drupal 6.x version we use on ThemeSnap.com and SocialSEO.com. I'll message nmudgal and allow him to have the code to compare against with his version. We'll be updating the Drupal 7.x version very soon -- most likely by later this week with the option to display or not display the ShareBar on any content type. It was brought up that we left this option out of the D7 version even through we do have it in our local D6 version running on a few sites.
Hope I can be more active here and for this module and our Drupal SEO Pack module, also contributed around the same time.
Thanks!
Comment #23
summit commentedHi SocialSEO,
COuld you put the working D6 module in zipcode here may be?
Would be great if we could use it also! The module seems great, so would love to test it on D6!
Thanks a lot in advance for your reply.
Greetings, Martijn
Comment #24
mattwmc commentedI'm looking for something like this, too.
Presently I'm using service links module and made a fixed "sharebar" with just css.
However, mine is at the same position throughout the entire page, and doesn't "spring" back up to the top of the page when scrolling.
I've noticed at other sites their bars "move" from absolute positioning to fixed. Is that done with JQuery?
Comment #25
nmudgal commented.scroll function of jquery can be useful. something like below but may be helpful
Except it, had a discussion with project owner & he accepted my request to maintain it with him, so hopefully, I will be making a release this weekend [ Should've done this earlier but got so busy with stuff. ]
Comment #26
mattwmc commentedGreat! Can't wait for this.
I'm seeing this up at lots of site, must be using wordpress.
Comment #27
nmudgal commentedPorted & released to 6.x, it's in working condition but have bugs which needs to be tackled :-) I have mentioned one or two in readme, release notes etc. So would be looking at them.
Also marking this issue as fixed as it is related to porting mainly. So please feel free to submit patches, bugs etc in separate thread :-)
Thanks