refactor google geocoding [#132541]

Comment	File	Size	Author
#16	location.fr_.inc_.txt	637 bytes	BobLouis
#15	geocode_google.inc_.txt	2.23 KB	BobLouis
#1	location-geocode-google-refactor-1.patch	12.81 KB	ray007

Comment #1

ray007 commented 2 April 2007 at 09:31

Status	File	Size
new	location-geocode-google-refactor-1.patch	12.81 KB

Since there were no replies I decided to go a slightly different route for now.
The attached patch
- introduces a new file supported/geocode_google.inc
- defines function location_geocode_google() and location_geocode_google_settings($cc = NULL) in there
- calls those 2 function for the specific function for 'us' and 'ca'
- adds similar code to provide geocoding and maplink with google for countries 'at' and 'de'

I think we need to define a "global service provider" that can be referenced from several countries, but this solution is good enough for me for now.

Comments?

Log in or register to post comments

Comment #2

ray007 commented 2 April 2007 at 10:46

Title:	location_latlon_exact()	» refactor google geocoding
Status:	Active	» Needs review

changed status and renamed issue to more proper title

Log in or register to post comments

Comment #3

ray007 commented 18 April 2007 at 09:39

Is there anything wrong with my patch?
I had been hoping for some feedback ...

Log in or register to post comments

Comment #4

nicolash commented 18 April 2007 at 10:12

+1 for this. Gmaps is by far the most widely adopted mapping and geocoding service outside of the US...I believe pretty much all of Europe and certainly Australia are included...not sure about Asia.

Log in or register to post comments

Comment #5

BachusII commented 18 April 2007 at 10:13

You can add 'nl' to the list of countries which can be geocoded by google.

Log in or register to post comments

Comment #6

JohnG-1 commented 18 April 2007 at 13:16

+1 AFAIK google maps is currently the best option. It makes sense to run with this until a better service appears, and then switch over to that one! Internationalisation of location.API is long overdue. Nice one Ray :)

Log in or register to post comments

Comment #7

ray007 commented 5 May 2007 at 08:47

is there anything I can do for this patch to be considered for inclusion?

Log in or register to post comments

Comment #8

Ian Ward commented 25 May 2007 at 18:48

There are limitations with just using google, so maybe finding a clean way to allow for failovers would be good too. I write about the shortcomings of using just any one service over here - http://www.developmentseed.org/blog/geocoding/geonames

Ian

Log in or register to post comments

Comment #9

ray007 commented 26 May 2007 at 07:20

I do not doubt that a solution allowing the use of arbitrary geocoding-services would be preferable, but

- google seems to work for most situations where there's nothing working out of the box now
- i have a patch making it work with google right now

those of you living in the usa or canada may not feel the lack of a solution covering the rest of the world, but the rest of the world does ...

Log in or register to post comments

Comment #10

BobLouis commented 31 May 2007 at 21:30

Ray, it seems that your patch is exactly what I needed, but for France (I was looking here before: http://drupal.org/node/147037).

How should I proceed to implement your patch? Does it work like this? Or do I have to replace "de" for Germany, by "fr" for France for example in your patch?

Thank you anyway for the job!

Log in or register to post comments

Comment #11

ray007 commented 31 May 2007 at 22:02

copy one of the country include files to location.fr.inc and change everything in the file that looks like the country code to 'fr'. remove the province list (if there is one) or write one for france and chances are pretty good it will work then ;-)

Log in or register to post comments

Comment #12

BobLouis commented 1 June 2007 at 11:40

What I did:
- applied your patch, which created a "geocode_google.inc" file that I copied to the "modules/location/supported/" directory.
- already had a "location.fr.inc" file in that directory

What do I need to do next to get geocoding working ?

Log in or register to post comments

Comment #13

ray007 commented 1 June 2007 at 12:25

look at the file location.at.inc

You will probably copy over and adapt to country code 'fr' the following functions:
- location_map_link_*
- location_geocode_*

don't forget to require_once('geocode_google.inc'); and see what happens ;-)

Log in or register to post comments

Comment #14

ibnhafsun commented 5 June 2007 at 12:45

It works with Spain but not the proximity searches.

Any suggestions? Does proximity search work with other countries (at, fr, de, nl)?

Log in or register to post comments

Comment #15

BobLouis commented 5 June 2007 at 19:18

Status	File	Size
new	geocode_google.inc_.txt	2.23 KB

Ray, I done what you said ;)
Now I have the following error message at the top of the submit form when trying to add a location enabled event:

warning: Cannot modify header information - headers already sent by (output started at ***/modules/location/supported/location.fr.inc:1) in ***/includes/common.inc on line 141.

Would you have time to look at them, I attach:
- geocode_google.inc (I added "txt", uploading "inc" files is not allowed), since I am not sure to have performed the patch correctly
- location.fr.inc. (in the next comment)

Thank you anyway for your instructions.

Log in or register to post comments

Comment #16

BobLouis commented 5 June 2007 at 19:20

Status	File	Size
new	location.fr_.inc_.txt	637 bytes

and here is "location.fr.inc"

Log in or register to post comments

Comment #17

ray007 commented 5 June 2007 at 19:35

your location.fr.inc file seems completely broken.
re-create it again starting from location.at.inc (or one of this others using google_geocode.inc)

Log in or register to post comments

Comment #18

BobLouis commented 9 June 2007 at 15:00

I applied the patch from my PC (windows) and uploaded the results to my host. For some reason, patching from my PC didn't work properly (although I used Unxutils as explained here : http://drupal.org/node/60179).
Then I tried to apply the patch directly from my host, using Putty. And it worked !

So thank you very much for your help Ray!

Just one question now: is there a way to display the map associated with the node instead of a "See map: Google Maps" link (the map is only displayed in the node for addresses in the US)?

Log in or register to post comments

Comment #19

ray007 commented 9 June 2007 at 17:32

I have work in progress on a gmap cck field (see http://drupal.org/project/gmap_addons) and location-integration is on my list of things to do ... but will take some time.

Log in or register to post comments

Comment #20

sivasamba commented 12 July 2007 at 12:52

Hello Im french Bob Louis.

And I would like to do the same thing like you. I can not geocode mi adresses?

What should I do?

Thanks a lot

Log in or register to post comments

Comment #21

TimDavies commented 12 July 2007 at 15:56

Only just spotted this thread.

I wrote a patch a while back which makes use of the Geonames service as a fallback:

http://drupal.org/node/75459#comment-216146

It seems to work pretty well for me for most countries (although with more accuracy in some than others...)

It could be adapted to also use Google Maps where geonames doesn't provide a suitable response, or vice-versa.

Tim

Log in or register to post comments

Comment #22

ray007 commented 12 July 2007 at 17:34

@obscurity:

Yes, I've already seen this thread.
As I already wrote in another comment, I think we need to introduce the concept of "global geocoding services", and those have a list of countries they support. But until we get word from the maintainers about what changes they'd accept I'll happily live with using google for the countries I need. Seems to work well enough so far.

Log in or register to post comments

Comment #23

ankur commented 12 July 2007 at 18:02

Assigned:

Unassigned

» ankur

I've actually been looking at the patches on this thread over the last month or so and been using them to write something similar. I should have something similar up soon (i.e., within the next week or two).

-Ankur

Log in or register to post comments

Comment #24

nashINATOR commented 24 July 2007 at 17:57

Hey Ray!!
Your patch looks unbelievably awesome. But I have a problem, a severe handicap. I am a noob!!! I cant seem to figure out how to patch or implement the patch.
Someone please help!!!
Cheers
Nash

Log in or register to post comments

Comment #25

nashINATOR commented 25 July 2007 at 04:43

Title:

refactor google geocoding

» Much accomplished

After much internal debate, and the admission to not knowing any php (limited php rather) i decided to look at the code for my self.
Well I took the us file and restructured it for nz. It works. The geocoding i mean but thats as far as it gets. I cant seem to get google maps to get the location information and display a map in the node. Maybe i need to understand the google maps module better. On the other hand i got it to work with the see map links module. (which means it opens in a new page and at the google website).
I would be eager to get some help re displaying a map within the node that gets map data from location module.
Cheers
Nash

Ps: if anyone requires the code for customising location to geocode your location contact me and i will fill you in. Basically what is to consider is does maps.google.com know where you are? Yes? then it will work. Oh! and i got my locations module to work for New Zealand

Log in or register to post comments

Comment #26

ankur commented 2 August 2007 at 02:04

Title:	Much accomplished	» refactor google geocoding
Status:	Needs review	» Fixed

I've committed a fix for this issue. Google geocoding now takes place in only one function and you only have to enter a Google API key once. I will also look into adding additional countries for which Google Maps has recently begun offering geocoding web services. ray007 and BobLouis, thanks for your patches.

-Ankur

Log in or register to post comments

Comment #27

(not verified) commented 16 August 2007 at 02:04

Status:

Fixed

» Closed (fixed)

Log in or register to post comments

Comment #28

rich86 commented 20 September 2007 at 17:34

Hi, I'm sorry to reopen this issue but I'm slightly confused about its status. I tried using the file at the top of this page but it doesn't seem to provide any geocode details for uk data.

Log in or register to post comments

Comment #29

summit commented 13 November 2007 at 22:21

Status:

Closed (fixed)

» Active

SUbscribing. I have the same behaviour as stated for uk data. But for me it is Spanish dat which is not provided.

Greetings,
Martijn

Log in or register to post comments

Comment #30

raymondllee commented 24 November 2007 at 00:56

Subscribing, I have the same issue as #28 for UK addresses

Log in or register to post comments

Comment #31

bdragon commented 21 January 2008 at 03:32

Component:

Code

» Data update

Changing component to Data update.

Log in or register to post comments

Comment #32

catch

he/him

English

commented 22 February 2008 at 12:18

Whole bunch of geocoding issues marked as duplicate of this one: http://drupal.org/node/66887

Log in or register to post comments

Comment #33

scott.mclewin commented 12 March 2008 at 15:01

subscribing. We do essentially this with a bespoke patch for www.folkjam.org and would really like to have a google geocode fallback for all locations.