Youtube parser

link to project page is missing, see http://drupal.org/node/1011698

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

• Run coder to check your style, some issues were found (please check the Drupal coding standards):
  

  Severity minor, Drupal Commenting Standards, Internationalization, Drupal Security Checks, Drupal SQL Standards, Drupal Coding Standards
  
  sites/all/modules/pareview_temp/test_candidate/youtube_parser.module:
   +17: [normal] The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.
  
  Status Messages:
   Coder found 1 projects, 1 files, 1 normal warnings, 0 warnings were flagged to be ignored
  

• README.txt is missing, see the guidelines for in-project documentation.
• Remove "version" from the info file, it will be added by drupal.org packaging automatically.
• Remove "project" from the info file, it will be added by drupal.org packaging automatically.
• Comments: there should be a space after "//".
  

  youtube_parser.module:53:  //kpr($info_array);
  

• ./youtube_parser.module: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming
  

  function youtube_parse_get_video_key($embedCode) {
  

• ./youtube_parser.module: The description for the @param/@return documentation is either missing or not formatted correctly. See http://drupal.org/node/1354#functions
  

  13- */
  36- */
  50- */
  70- */
  84- */
  98- */
  113- */
  128- */
  142- */
  

This automated report was generated with PAReview.sh, your friendly project application review script. Please report any bugs to klausi.

Yes, since this is an API only module, developer documentation is incredibly important. Note that also the http://drupal.org/project/feeds_youtube module parses video information from the MRSS namespace. Can you think of a way to integrate with it?

Hi,

an automated review shows no issues.

Manual review:

• There are still files in your master branch. You should replace them as described in http://drupal.org/node/1127732 at step 5.
• There is a abandoned ";" in your .info file. No big thing, but you may want to remove it for a clean look.
• Your indentations are not consistent (sometimes 4 spaces instead of 2). Please have a look.
• The following is really not meant as an offence or to discourage you but I think it's worth mentioning:
  • Walking through the review queue and searching through existing projects, there is already pretty much stuff dealing with youtube. Are you sure there is no module already offering what you present here or that you could contribute to, be it with a feature request or patch proposal? I am aware that you implement an API here, but it's hard to imagine no one else did before as youtube related stuff is a feature with already much attention.
  • Honestly spoken: Your module is tiny. That is no bad thing at all by default, but not very helpful in getting an idea on how familiar you are with the Drupal API, coding standards etc. The more as there is no hook implementation, no install routine or anything else that could give more evidence on this. I would really like to suggest thinking about an alternative as your first contribution, but this is only my personal opinion. Again, please don't feel harassed!

HTH, cheers, dave

Late-add:

Why do you apply with more than one project anyway?

Please decide which one you want to be your "approval project".

Cool, multiple new contributors.

It would be preferable (can't find evidence it's required) that each developer has his own d.o account. And then everyone who would need the git vetted user role can go through this approval process with a project. Note that this would not not be required for everyone - you can add colaborators to projects, git vetted or not.

Hi again, adding to my comment on your other project. And subscribing to Niklas' post.

Please don't get me wrong. But IMO we would rather need more reviewers in the queue than several projects just for one account to become approved (also refering to what I stated regarding module complexity here). As I mentioned before: Why not join the forces and help us all getting faster through the process? Everyone - that does also mean applicants - is explicitely encouraged to help reviewing as good as he can (there are lots of documents on how to do reviews). Please!

Thanks :)

Alright. svipsa decided that the other module is the one to be reviewed.

added link to project page and git repository