Fivestar values not saved to the field storage when rating in view mode [#1327878]

I have nodes where comments are allowed, users put rating in the comments, and then the averages is display in the node - typical stuff.

I created a views list of these results, using the table format, and I wanted to be able to sort by average rating.

The list shows correctly and the table cell title is clickable for 'asc' and 'desc.' However, when you click it, nothing happens - doesn't change.

Am I doing something wrong? Bug? The stars appear, but is the database column definition actually numeric that can be sorted on?

Comment	File	Size	Author
#7	fivestar-1327878-4.patch	2.05 KB	ericduran
#3	fivestar-1327878-4.patch	2.05 KB	plach
#2	fivestar-1327878-3.patch	2.06 KB	plach

Comments

Comment #1

acarpio commented 4 November 2011 at 18:47

I'm having the same issue and also wondering if I'm doing something wrong or it is a bug.

I'm using last dev releases for views, fivestar and all other modules required, developing localhost.

I will appreciate any help.

Comment #2

plach

he/him

Italian

Venezia

commented 5 November 2011 at 18:53

Title:	Fivestar in views results not sortable	» Fivestar values not saved to the field storage when rating in view mode
Priority:	Normal	» Major
Status:	Active	» Needs review

Status	File	Size
new	fivestar-1327878-3.patch	2.06 KB

Views is unable to sort by rating because when voting in view mode (through the ajax widget) the result is stored only in the votingapi tables and not into the field storage. The attached patch should fix this use case (existing votes will need to be re-entered).

Comment #3

plach

he/him

Italian

Venezia

commented 5 November 2011 at 18:58

Status	File	Size
new	fivestar-1327878-4.patch	2.05 KB

Cleaner patch

Comment #4

acarpio commented 6 November 2011 at 08:20

This patch is working for me: views is sorting as expected, both Asc and Desc.

Thanks so much, plach.

Comment #5

Gastonia commented 7 November 2011 at 03:21

thanks for the patch! will this be included into the next dev release?

Comment #6

ericduran commented 9 November 2011 at 22:10

Status:

Needs review

» Needs work

This looks great. Can we add some test?

Also one minor thing :

+++ b/includes/fivestar.field.incundefined
@@ -145,6 +145,16 @@ function _fivestar_field_target($entity, $field, $instance, $item, $langcode) {
+  $langcode = LANGUAGE_NONE;

The language shouldn't be hard-coded into LANGUAGE_NONE.