1.) Menu descriptions do not need t()
-> the description string is always send through t()

2.) default values of variables in t(), if they are strings.

3.) Options of a seclect list
are translated via t()

4.) Little improvement on strings_
e.g. description for checkbox:
'if checked' -> don't explain UI to the user
User must not do anything: everything a user does, the person does on there own.
removed some duplicate blanks

CommentFileSizeAuthor
#1 fixed_translation-1328842-1.patch15.61 KBThomas_Zahreddin

Comments

Thomas_Zahreddin’s picture

Thomas_Zahreddin commented
Version: 6.x-1.9 » 6.x-1.20
Status: Active » Needs review
StatusFileSize
new fixed_translation-1328842-1.patch15.61 KB

patch based on forward 6.x-1.20 (first version in the issue was wrong, sorry)

also i think the patch fixes most errors, but in this way t() is often kind of missused, the translation only works proper for the default values.

john.oltman’s picture

john.oltman commented
Version: 6.x-1.20 » 6.x-1.21
Assigned: Unassigned » john.oltman
Status: Needs review » Fixed

Thomas, thanks for the patch. I committed some items from your list - #1 hook_menu description fix, and #3 translate options of a select. The others would affect people with string overrides installed, so I'll look to handle those better in the D8 version with token support and translation cleanup. I agree that t() is misused in some cases and that can get cleaned up in D8 - the D6 version already has thousands of users so don't want to destabilize the install base.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.