Popup Confirm Survey is a small module, the only purpose of which is to popup a survey confirmation box and redirect to the survey content type. The survey content type can be set from configuration section. The popup confirmation is created as a block, so admister privileged users can easily configure the required pages as well. We have used the overlay method (eg: lightbox, highslide etc) to show the confirmation popup.

GIT Path : git clone --branch master Drupaldevassyst@git.drupal.org:sandbox/Drupaldevassyst/1328204.git popup_confirm_survey

Sandbox Project link : http://drupal.org/sandbox/Drupaldevassyst/1328204

Drupal Version : 6.x

CommentFileSizeAuthor
#12 popup_confirm_survey-result.txt17.33 KBraynimmo

Comments

raynimmo’s picture

raynimmo commented
Status: Needs review » Needs work

Master Branch
It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

I checked out your code after working out the correct clone path, which is actually git clone --branch master http://git.drupal.org/sandbox/Drupaldevassyst/1328204.git popup_confirm_survey.

Code Errors
You should really run the Coder module on "minor" setting to help catch the errors within your code. The coding standards
have even more information in this area.

When I ran it through coder with settings at Severity minor, Drupal Commenting Standards, Internationalization, Drupal Security Checks, Drupal SQL Standards, Drupal Coding Standards it found a large amount of errors in your code.

Coder found 1 projects, 4 files, 362 normal warnings, 18 minor warnings, 0 warnings were flagged to be ignored

drupaldev@assyst’s picture

drupaldev@assyst commented

Hi,

Thanks for your comments.

Completed the changes as per your suggestion and created new version branch.

git clone --branch dev1 Drupaldevassyst@git.drupal.org:sandbox/Drupaldevassyst/1328204.git popup_confirm_survey

Best Regards,
Team Assyst

raynimmo’s picture

raynimmo commented

You should have a read of the release naming conventions and possibly rename the branch to 6.x-1.x if it is targetted at Drupal 6.

git checkout -b 6.x-1.x
git push -u origin 6.x-1.x

Also, the git clone line you are referencing is incorrect. That is for you when you are committing files to your branches as it contains your user login credentials. For other people to clone your project they would have to enter;
git clone --branch 6.x-1.x http://git.drupal.org/sandbox/Drupaldevassyst/1328204.git popup_confirm_survey.

If in doubt about Git commands have a read through the Git documentation.

drupaldev@assyst’s picture

drupaldev@assyst commented

Hi,

Thank you very much for your valuable comments.
We had renamed the branch as you suggested and the new git URL is given below
git clone --branch 6.x-1.x http://git.drupal.org/sandbox/Drupaldevassyst/1328204.git popup_confirm_survey

Best Regards,
Team Assyst

drupaldev@assyst’s picture

drupaldev@assyst commented

Hi,

Kindly confirm, whether we need to do anything more for making this project Live.

Thanks & Best Regards,
Assyst Team

raynimmo’s picture

raynimmo commented

if your project is in need of review then you should set it status to 'needs review'

Also, just noticed that you have another module application in the issue queue. Generally only one application per user is allowed, you should either close this one or #1331840 Twitter Tweets Module.

drupaldev@assyst’s picture

drupaldev@assyst commented
Status: Needs work » Needs review
raynimmo’s picture

raynimmo commented
Status: Needs review » Needs work

Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards):

FILE: ...\sites\default\modules\reviews\popup_confirm_survey\css\reset.css
--------------------------------------------------------------------------------
FOUND 15 ERROR(S) AFFECTING 15 LINE(S)
--------------------------------------------------------------------------------
 13 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 14 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 15 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 16 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 17 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 18 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 19 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 22 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 25 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 28 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 33 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 38 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 41 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 46 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 47 | ERROR | Spaces must be used to indent lines; tabs are not allowed
--------------------------------------------------------------------------------


FILE: ...\sites\default\modules\reviews\popup_confirm_survey\css\styles.css
--------------------------------------------------------------------------------
FOUND 32 ERROR(S) AFFECTING 32 LINE(S)
--------------------------------------------------------------------------------
  18 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  19 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  20 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  21 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 104 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 105 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 106 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 107 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 108 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 109 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 110 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 111 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 112 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 113 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 114 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 115 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 129 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 148 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 149 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 152 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 153 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 154 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 157 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 158 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 159 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 160 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 163 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 164 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 167 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 168 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 175 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 176 | ERROR | Spaces must be used to indent lines; tabs are not allowed
--------------------------------------------------------------------------------


FILE: ...\sites\default\modules\reviews\popup_confirm_survey\js\scripts.js
--------------------------------------------------------------------------------
FOUND 114 ERROR(S) AFFECTING 113 LINE(S)
--------------------------------------------------------------------------------
   6 | ERROR | Spaces must be used to indent lines; tabs are not allowed
   7 | ERROR | Spaces must be used to indent lines; tabs are not allowed
   9 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  10 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  11 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  12 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  13 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  14 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  15 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  16 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  17 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  18 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  19 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  20 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  21 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  22 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  22 | ERROR | Expected 0 spaces before closing bracket; 1 found
  23 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  24 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  25 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  26 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  27 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  28 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  29 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  30 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  31 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  32 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  33 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  34 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  35 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  36 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  37 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  38 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  39 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  40 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  41 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  42 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  43 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  44 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  45 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  46 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  47 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  48 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  49 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  50 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  51 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  53 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  54 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  55 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  56 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  57 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  58 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  59 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  60 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  61 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  62 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  63 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  64 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  66 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  67 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  68 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  69 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  70 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  71 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  72 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  73 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  74 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  75 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  76 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  77 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  78 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  79 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  80 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  81 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  82 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  83 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  84 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  85 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  86 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  87 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  88 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  89 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  90 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  91 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  92 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  93 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  94 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  95 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  96 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  97 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  98 | ERROR | Spaces must be used to indent lines; tabs are not allowed
  99 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 100 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 101 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 102 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 103 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 104 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 105 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 111 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 112 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 116 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 117 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 118 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 119 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 120 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 121 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 122 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 123 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 124 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 126 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 127 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 128 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 129 | ERROR | Spaces must be used to indent lines; tabs are not allowed
 130 | ERROR | Spaces must be used to indent lines; tabs are not allowed
--------------------------------------------------------------------------------


FILE: ...fault\modules\reviews\popup_confirm_survey\popup_confirm_survey.install
--------------------------------------------------------------------------------
FOUND 36 ERROR(S) AND 3 WARNING(S) AFFECTING 20 LINE(S)
--------------------------------------------------------------------------------
  2 | ERROR   | You must use "/**" style comments for a file comment
  2 | ERROR   | There must be no blank line following an inline comment
 11 | WARNING | Format should be * Implements hook_foo().
 15 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 15 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 19 | WARNING | Format should be * Implements hook_foo().
 23 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 23 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 24 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 24 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 25 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 25 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 26 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 26 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 27 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 27 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 28 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 28 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 29 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 29 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 29 | ERROR   | Whitespace found at end of line
 33 | WARNING | Format should be * Implements hook_foo().
 39 | ERROR   | Whitespace found at end of line
 40 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 40 | ERROR   | The first index in a multi-value array must be on a new line
 40 | ERROR   | The first index in a multi-value array must be on a new line
 40 | ERROR   | The first index in a multi-value array must be on a new line
 40 | ERROR   | The first index in a multi-value array must be on a new line
 41 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 41 | ERROR   | A whitespace must prefix the item assignment operator =>
 41 | ERROR   | There must be a single space before an operator statement
 42 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 42 | ERROR   | Expected 1 space between comma and "'length'"; 0 found
 43 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 43 | ERROR   | Whitespace found at end of line
 44 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 46 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 46 | ERROR   | Whitespace found at end of line
 48 | ERROR   | Whitespace found at end of line
--------------------------------------------------------------------------------


FILE: ...efault\modules\reviews\popup_confirm_survey\popup_confirm_survey.module
--------------------------------------------------------------------------------
FOUND 563 ERROR(S) AND 15 WARNING(S) AFFECTING 307 LINE(S)
--------------------------------------------------------------------------------
   2 | ERROR   | You must use "/**" style comments for a file comment
   3 | ERROR   | There must be no blank line following an inline comment
   5 | ERROR   | You must use "/**" style comments for a function comment
   6 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
   6 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
   6 | ERROR   | There must be no space between the Array keyword and the
     |         | opening parenthesis
   7 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
   7 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
   8 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
   8 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
  11 | ERROR   | Missing function doc comment
  12 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  12 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
  14 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  14 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
  14 | ERROR   | There must be no space between the Array keyword and the
     |         | opening parenthesis
  15 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  16 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  16 | WARNING | A comma should follow the last multiline array item. Found: )
  17 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  17 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
  19 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  19 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
  20 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  20 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
  22 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  22 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
  23 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  23 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
  27 | WARNING | Format should be * Implements hook_foo().
  30 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  30 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
  30 | ERROR   | There must be no space between the Array keyword and the
     |         | opening parenthesis
  32 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  32 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
  32 | ERROR   | There must be no space between the Array keyword and the
     |         | opening parenthesis
  33 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  34 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  34 | ERROR   | There must be no space between the Array keyword and the
     |         | opening parenthesis
  35 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  36 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  37 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  39 | ERROR   | Whitespace found at end of line
  39 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  40 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  40 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
  42 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  42 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
  42 | ERROR   | There must be no space between the Array keyword and the
     |         | opening parenthesis
  43 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  44 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  44 | ERROR   | There must be no space between the Array keyword and the
     |         | opening parenthesis
  45 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  46 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  47 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  49 | ERROR   | Whitespace found at end of line
  49 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  50 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  50 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
  52 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  52 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
  52 | ERROR   | There must be no space between the Array keyword and the
     |         | opening parenthesis
  53 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  54 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  54 | ERROR   | There must be no space between the Array keyword and the
     |         | opening parenthesis
  55 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  56 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  57 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  59 | ERROR   | Whitespace found at end of line
  59 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  60 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  60 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
  62 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  62 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
  62 | ERROR   | There must be no space between the Array keyword and the
     |         | opening parenthesis
  63 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  64 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  65 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  66 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  66 | ERROR   | There must be no space between the Array keyword and the
     |         | opening parenthesis
  67 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  68 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  69 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  69 | ERROR   | There must be no space between the Array keyword and the
     |         | opening parenthesis
  70 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  71 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  72 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  74 | ERROR   | Whitespace found at end of line
  74 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  75 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  75 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
  77 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  77 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
  81 | WARNING | Format should be * Implements hook_foo().
  83 | ERROR   | There must be no space between the Array keyword and the
     |         | opening parenthesis
  84 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  84 | ERROR   | Line indented incorrectly; expected 2 spaces, found 1
  85 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  85 | ERROR   | Line indented incorrectly; expected at least 4 spaces, found 2
  85 | ERROR   | There must be no space between the Array keyword and the
     |         | opening parenthesis
  86 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  86 | ERROR   | Line indented incorrectly; expected at least 4 spaces, found 3
  86 | WARNING | A comma should follow the last multiline array item. Found: )
  87 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  87 | ERROR   | Line indented incorrectly; expected at least 4 spaces, found 2
  89 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  89 | ERROR   | Line indented incorrectly; expected at least 4 spaces, found 2
  90 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  90 | ERROR   | Inline control structures are not allowed
  91 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  91 | ERROR   | Use "elseif" in place of "else if"
  92 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  92 | ERROR   | Line indented incorrectly; expected at least 4 spaces, found 3
  92 | ERROR   | There must be no space between the Array keyword and the
     |         | opening parenthesis
  93 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  93 | ERROR   | Line indented incorrectly; expected 4 spaces, found 3
  94 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  94 | ERROR   | Line indented incorrectly; expected 6 spaces, found 4
  95 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  95 | ERROR   | Line indented incorrectly; expected at least 8 spaces, found 5
  96 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  96 | ERROR   | Line indented incorrectly; expected 8 spaces, found 5
  97 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  97 | ERROR   | Line indented incorrectly; expected at least 10 spaces, found
     |         | 6
  97 | ERROR   | There must be no space between the Array keyword and the
     |         | opening parenthesis
  98 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  98 | ERROR   | Line indented incorrectly; expected at least 10 spaces, found
     |         | 7
  99 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  99 | ERROR   | Line indented incorrectly; expected at least 10 spaces, found
     |         | 7
 101 | ERROR   | Whitespace found at end of line
 101 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 102 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 102 | ERROR   | Line indented incorrectly; expected at least 10 spaces, found
     |         | 6
 103 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 104 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 104 | ERROR   | Break statement indented incorrectly; expected 6 spaces, found
     |         | 5
 105 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 107 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 107 | ERROR   | Line indented incorrectly; expected at least 4 spaces, found 3
 108 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 115 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 115 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 121 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 121 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 123 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 123 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 129 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 129 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 136 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 136 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 138 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 138 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 138 | ERROR   | There must be no space between the Array keyword and the
     |         | opening parenthesis
 139 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 140 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 141 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 141 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 143 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 143 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 143 | ERROR   | There must be no space between the Array keyword and the
     |         | opening parenthesis
 144 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 145 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 146 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 146 | ERROR   | There must be no space between the Array keyword and the
     |         | opening parenthesis
 147 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 148 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 148 | WARNING | A comma should follow the last multiline array item. Found: )
 149 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 151 | ERROR   | Whitespace found at end of line
 151 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 152 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 152 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 154 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 154 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 154 | ERROR   | There must be no space between the Array keyword and the
     |         | opening parenthesis
 155 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 156 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 157 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 157 | ERROR   | There must be no space between the Array keyword and the
     |         | opening parenthesis
 158 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 159 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 160 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 160 | ERROR   | There must be no space between the Array keyword and the
     |         | opening parenthesis
 161 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 162 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 164 | ERROR   | Whitespace found at end of line
 164 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 165 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 165 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 167 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 167 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 169 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 169 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 176 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 176 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 176 | ERROR   | There must be no space between the Array keyword and the
     |         | opening parenthesis
 177 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 177 | ERROR   | There must be no space between the Array keyword and the
     |         | opening parenthesis
 178 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 178 | ERROR   | There must be no space between the Array keyword and the
     |         | opening parenthesis
 179 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 179 | WARNING | A comma should follow the last multiline array item. Found:
     |         | NULL
 180 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 182 | ERROR   | Whitespace found at end of line
 182 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 183 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 185 | ERROR   | Whitespace found at end of line
 185 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 186 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 186 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 194 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 194 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 197 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 197 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 198 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 198 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 199 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 199 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 200 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 200 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 202 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 202 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 210 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 210 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 210 | ERROR   | Variable "curTime" is camel caps format. do not use mixed case
     |         | (camelCase), use lower case and _
 212 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 212 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 212 | ERROR   | Variable "loadTime" is camel caps format. do not use mixed
     |         | case (camelCase), use lower case and _
 213 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 213 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 213 | ERROR   | Variable "callFrom" is camel caps format. do not use mixed
     |         | case (camelCase), use lower case and _
 215 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 215 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 215 | ERROR   | Variable "surveyStatus" is camel caps format. do not use mixed
     |         | case (camelCase), use lower case and _
 217 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 217 | ERROR   | Line indented incorrectly; expected 2 spaces, found 1
 219 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 219 | ERROR   | Line indented incorrectly; expected at least 4 spaces, found 2
 219 | ERROR   | Variable "surveyStatus" is camel caps format. do not use mixed
     |         | case (camelCase), use lower case and _
 221 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 221 | ERROR   | Line indented incorrectly; expected 4 spaces, found 2
 221 | ERROR   | Variable "surveyStatus" is camel caps format. do not use mixed
     |         | case (camelCase), use lower case and _
 222 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 222 | ERROR   | Line indented incorrectly; expected at least 6 spaces, found 3
 222 | ERROR   | Variable "loadTime" is camel caps format. do not use mixed
     |         | case (camelCase), use lower case and _
 224 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 224 | ERROR   | Inline control structures are not allowed
 225 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 225 | ERROR   | Variable "loadTime" is camel caps format. do not use mixed
     |         | case (camelCase), use lower case and _
 225 | ERROR   | Variable "loadTime" is camel caps format. do not use mixed
     |         | case (camelCase), use lower case and _
 227 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 227 | ERROR   | Inline control structures are not allowed
 227 | ERROR   | Variable "loadTime" is camel caps format. do not use mixed
     |         | case (camelCase), use lower case and _
 228 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 228 | ERROR   | Variable "loadTime" is camel caps format. do not use mixed
     |         | case (camelCase), use lower case and _
 229 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 230 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 232 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 232 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 232 | ERROR   | Variable "loadTime" is camel caps format. do not use mixed
     |         | case (camelCase), use lower case and _
 232 | ERROR   | Variable "loadTime" is camel caps format. do not use mixed
     |         | case (camelCase), use lower case and _
 234 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 234 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 235 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 235 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 235 | ERROR   | Variable "loadTime" is camel caps format. do not use mixed
     |         | case (camelCase), use lower case and _
 242 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 242 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 242 | ERROR   | Variable "spendTime" is camel caps format. do not use mixed
     |         | case (camelCase), use lower case and _
 243 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 243 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 243 | ERROR   | Variable "curTime" is camel caps format. do not use mixed case
     |         | (camelCase), use lower case and _
 244 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 244 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 244 | ERROR   | Variable "callFrom" is camel caps format. do not use mixed
     |         | case (camelCase), use lower case and _
 246 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 246 | ERROR   | Line indented incorrectly; expected 2 spaces, found 1
 247 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 247 | ERROR   | Line indented incorrectly; expected at least 4 spaces, found 2
 247 | ERROR   | Variable "spendTime" is camel caps format. do not use mixed
     |         | case (camelCase), use lower case and _
 249 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 249 | ERROR   | Line indented incorrectly; expected 4 spaces, found 2
 250 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 250 | ERROR   | Line indented incorrectly; expected at least 6 spaces, found 3
 250 | ERROR   | Variable "spendTime" is camel caps format. do not use mixed
     |         | case (camelCase), use lower case and _
 251 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 251 | ERROR   | Line indented incorrectly; expected 4 spaces, found 2
 252 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 252 | ERROR   | Line indented incorrectly; expected at least 6 spaces, found 3
 252 | ERROR   | Variable "spendTime" is camel caps format. do not use mixed
     |         | case (camelCase), use lower case and _
 252 | ERROR   | Variable "spendTime" is camel caps format. do not use mixed
     |         | case (camelCase), use lower case and _
 253 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 253 | ERROR   | Line indented incorrectly; expected at least 6 spaces, found 3
 253 | ERROR   | Variable "spendTime" is camel caps format. do not use mixed
     |         | case (camelCase), use lower case and _
 254 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 255 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 257 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 257 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 258 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 258 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 258 | ERROR   | Variable "spendTime" is camel caps format. do not use mixed
     |         | case (camelCase), use lower case and _
 266 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 266 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 266 | ERROR   | Variable "selValue" is camel caps format. do not use mixed
     |         | case (camelCase), use lower case and _
 268 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 268 | ERROR   | Line indented incorrectly; expected 2 spaces, found 1
 268 | ERROR   | Variable "selValue" is camel caps format. do not use mixed
     |         | case (camelCase), use lower case and _
 269 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 269 | ERROR   | Line indented incorrectly; expected at least 4 spaces, found 2
 270 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 272 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 272 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 272 | ERROR   | Variable "selValue" is camel caps format. do not use mixed
     |         | case (camelCase), use lower case and _
 272 | ERROR   | Variable "selValue" is camel caps format. do not use mixed
     |         | case (camelCase), use lower case and _
 274 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 274 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 275 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 275 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 275 | ERROR   | Variable "selValue" is camel caps format. do not use mixed
     |         | case (camelCase), use lower case and _
 282 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 282 | ERROR   | Line indented incorrectly; expected 2 spaces, found 1
 283 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 283 | ERROR   | Line indented incorrectly; expected at least 4 spaces, found 2
 285 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 285 | ERROR   | Line indented incorrectly; expected at least 4 spaces, found 2
 286 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 288 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 288 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 292 | WARNING | Format should be * Implements hook_foo().
 295 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 295 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 297 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 297 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 297 | ERROR   | There must be no space between the Array keyword and the
     |         | opening parenthesis
 299 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 299 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 299 | ERROR   | There must be no space between the Array keyword and the
     |         | opening parenthesis
 300 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 301 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 302 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 303 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 304 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 305 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 306 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 308 | ERROR   | Whitespace found at end of line
 308 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 309 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 309 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 311 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 311 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 311 | ERROR   | There must be no space between the Array keyword and the
     |         | opening parenthesis
 312 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 313 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 314 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 315 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 316 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 317 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 318 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 320 | ERROR   | Whitespace found at end of line
 320 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 321 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 321 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 323 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 323 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 323 | ERROR   | There must be no space between the Array keyword and the
     |         | opening parenthesis
 324 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 325 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 326 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 327 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 328 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 329 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 331 | ERROR   | Whitespace found at end of line
 331 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 332 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 332 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 334 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 334 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 334 | ERROR   | There must be no space between the Array keyword and the
     |         | opening parenthesis
 335 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 336 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 337 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 338 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 339 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 340 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 341 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 342 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 342 | ERROR   | There must be no space between the Array keyword and the
     |         | opening parenthesis
 343 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 343 | WARNING | A comma should follow the last multiline array item. Found:
     |         | TRUE
 344 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 346 | ERROR   | Whitespace found at end of line
 346 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 347 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 347 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 349 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 349 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 349 | ERROR   | There must be no space between the Array keyword and the
     |         | opening parenthesis
 350 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 351 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 352 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 353 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 354 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 355 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 356 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 357 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 357 | ERROR   | There must be no space between the Array keyword and the
     |         | opening parenthesis
 358 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 358 | WARNING | A comma should follow the last multiline array item. Found:
     |         | TRUE
 359 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 361 | ERROR   | Whitespace found at end of line
 361 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 362 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 362 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 364 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 364 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 364 | ERROR   | There must be no space between the Array keyword and the
     |         | opening parenthesis
 365 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 366 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 367 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 368 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 369 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 370 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 372 | ERROR   | Whitespace found at end of line
 372 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 373 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 373 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 375 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 375 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 377 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 377 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 384 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 384 | ERROR   | Line indented incorrectly; expected 2 spaces, found 1
 385 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 385 | ERROR   | Line indented incorrectly; expected at least 4 spaces, found 2
 386 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 388 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 388 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 389 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 389 | ERROR   | Line indented incorrectly; expected 2 spaces, found 1
 390 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 390 | ERROR   | Line indented incorrectly; expected at least 4 spaces, found 2
 390 | ERROR   | There must be no space between the Array keyword and the
     |         | opening parenthesis
 391 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 391 | ERROR   | Line indented incorrectly; expected at least 4 spaces, found 3
 391 | WARNING | A comma should follow the last multiline array item. Found: ]
 392 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 392 | ERROR   | Line indented incorrectly; expected at least 4 spaces, found 2
 393 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 393 | ERROR   | Line indented incorrectly; expected at least 4 spaces, found 2
 394 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 394 | ERROR   | Line indented incorrectly; expected 4 spaces, found 2
 395 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 395 | ERROR   | Line indented incorrectly; expected at least 6 spaces, found 3
 395 | ERROR   | There must be no space between the Array keyword and the
     |         | opening parenthesis
 396 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 396 | ERROR   | Line indented incorrectly; expected at least 6 spaces, found 4
 397 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 397 | ERROR   | Line indented incorrectly; expected at least 6 spaces, found 4
 397 | WARNING | A comma should follow the last multiline array item. Found:
     |         | $normal_path
 398 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 398 | ERROR   | Line indented incorrectly; expected at least 6 spaces, found 3
 399 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 399 | ERROR   | Line indented incorrectly; expected at least 6 spaces, found 3
 400 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 401 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 401 | ERROR   | Line indented incorrectly; expected 4 spaces, found 2
 402 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 402 | ERROR   | Line indented incorrectly; expected at least 6 spaces, found 3
 402 | ERROR   | There must be no space between the Array keyword and the
     |         | opening parenthesis
 403 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 403 | ERROR   | Line indented incorrectly; expected at least 6 spaces, found 4
 403 | WARNING | A comma should follow the last multiline array item. Found: ]
 404 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 404 | ERROR   | Line indented incorrectly; expected at least 6 spaces, found 3
 405 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 406 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 408 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 408 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 409 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 409 | ERROR   | Line indented incorrectly; expected 2 spaces, found 1
 410 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 410 | ERROR   | Line indented incorrectly; expected at least 4 spaces, found 2
 410 | ERROR   | There must be no space between the Array keyword and the
     |         | opening parenthesis
 411 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 411 | ERROR   | Line indented incorrectly; expected at least 4 spaces, found 3
 411 | WARNING | A comma should follow the last multiline array item. Found: ]
 412 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 412 | ERROR   | Line indented incorrectly; expected at least 4 spaces, found 2
 413 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 413 | ERROR   | Line indented incorrectly; expected at least 4 spaces, found 2
 414 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 414 | ERROR   | Line indented incorrectly; expected 4 spaces, found 2
 415 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 415 | ERROR   | Line indented incorrectly; expected at least 6 spaces, found 3
 415 | ERROR   | There must be no space between the Array keyword and the
     |         | opening parenthesis
 416 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 416 | ERROR   | Line indented incorrectly; expected at least 6 spaces, found 4
 417 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 417 | ERROR   | Line indented incorrectly; expected at least 6 spaces, found 4
 417 | WARNING | A comma should follow the last multiline array item. Found:
     |         | $normal_path
 418 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 418 | ERROR   | Line indented incorrectly; expected at least 6 spaces, found 3
 419 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 419 | ERROR   | Line indented incorrectly; expected at least 6 spaces, found 3
 420 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 421 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 421 | ERROR   | Line indented incorrectly; expected 4 spaces, found 2
 422 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 422 | ERROR   | Line indented incorrectly; expected at least 6 spaces, found 3
 422 | ERROR   | There must be no space between the Array keyword and the
     |         | opening parenthesis
 423 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 423 | ERROR   | Line indented incorrectly; expected at least 6 spaces, found 4
 423 | WARNING | A comma should follow the last multiline array item. Found: ]
 424 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 424 | ERROR   | Line indented incorrectly; expected at least 6 spaces, found 3
 425 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 426 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 434 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 434 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 434 | ERROR   | Variable "nodeType" is camel caps format. do not use mixed
     |         | case (camelCase), use lower case and _
 436 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 436 | ERROR   | Line indented incorrectly; expected 2 spaces, found 1
 436 | ERROR   | Variable "nodeType" is camel caps format. do not use mixed
     |         | case (camelCase), use lower case and _
 437 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 437 | ERROR   | Line indented incorrectly; expected at least 4 spaces, found 2
 437 | ERROR   | Variable "buttonValue" is camel caps format. do not use mixed
     |         | case (camelCase), use lower case and _
 438 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 438 | ERROR   | Line indented incorrectly; expected at least 4 spaces, found 2
 438 | ERROR   | Variable "buttonValue" is camel caps format. do not use mixed
     |         | case (camelCase), use lower case and _
 438 | ERROR   | Variable "buttonValue" is camel caps format. do not use mixed
     |         | case (camelCase), use lower case and _
 438 | ERROR   | Variable "buttonValue" is camel caps format. do not use mixed
     |         | case (camelCase), use lower case and _
 440 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 440 | ERROR   | Line indented incorrectly; expected 4 spaces, found 2
 441 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 441 | ERROR   | Line indented incorrectly; expected 6 spaces, found 3
 441 | ERROR   | Variable "nodeType" is camel caps format. do not use mixed
     |         | case (camelCase), use lower case and _
 442 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 442 | ERROR   | Line indented incorrectly; expected at least 8 spaces, found 4
 442 | ERROR   | Variable "buttonValue" is camel caps format. do not use mixed
     |         | case (camelCase), use lower case and _
 443 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 443 | ERROR   | Break statement indented incorrectly; expected 5 spaces, found
     |         | 4
 444 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 445 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 452 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 452 | ERROR   | Line indented incorrectly; expected at least 2 spaces, found 1
 452 | ERROR   | Variable "nodeType" is camel caps format. do not use mixed
     |         | case (camelCase), use lower case and _
 454 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 454 | ERROR   | Line indented incorrectly; expected 2 spaces, found 1
 454 | ERROR   | Variable "nodeType" is camel caps format. do not use mixed
     |         | case (camelCase), use lower case and _
 455 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 455 | ERROR   | Line indented incorrectly; expected 4 spaces, found 2
 456 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 456 | ERROR   | Line indented incorrectly; expected 6 spaces, found 3
 456 | ERROR   | Variable "nodeType" is camel caps format. do not use mixed
     |         | case (camelCase), use lower case and _
 457 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 457 | ERROR   | Line indented incorrectly; expected 8 spaces, found 4
 458 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 458 | ERROR   | Line indented incorrectly; expected 10 spaces, found 5
 459 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 459 | ERROR   | Line indented incorrectly; expected at least 12 spaces, found
     |         | 6
 462 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 462 | ERROR   | Line indented incorrectly; expected at least 12 spaces, found
     |         | 6
 463 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 463 | ERROR   | Break statement indented incorrectly; expected 7 spaces, found
     |         | 6
 465 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 465 | ERROR   | Line indented incorrectly; expected 10 spaces, found 5
 466 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 466 | ERROR   | Line indented incorrectly; expected 12 spaces, found 6
 467 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 467 | ERROR   | Line indented incorrectly; expected at least 14 spaces, found
     |         | 7
 468 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 470 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 470 | ERROR   | Break statement indented incorrectly; expected 7 spaces, found
     |         | 6
 471 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 472 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 472 | ERROR   | Break statement indented incorrectly; expected 5 spaces, found
     |         | 4
 473 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
 474 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
--------------------------------------------------------------------------------

Please ensure you set it back to 'needs review' once you have addressed the issues highlighted here.

drupaldev@assyst’s picture

drupaldev@assyst commented
Status: Needs work » Needs review

Hi,

The changes that we had made is not getting reflected in the git branch. We had deleted the current branch and created a new one with same name. I hope now all the changes are pushed to the new branch

Git url : git clone --branch 6.x-1.x http://git.drupal.org/sandbox/Drupaldevassyst/1328204.git popup_confirm_survey

Iam really sorry for the mistake happened from our end.

Thanks and Best Regards,
Assyst Team.

bfr’s picture

bfr commented
Status: Needs review » Needs work

Review of the 6.x-1.x branch:

This automated report was generated with PAReview.sh, your friendly project application review script. Go and review some other project applications, so we can get back to yours sooner.

drupaldev@assyst’s picture

drupaldev@assyst commented
Status: Needs work » Needs review

Hi,

We had made the changes as listed above. Please have a look on this.

Thanks & Best Regards,
Assyst Team

raynimmo’s picture

raynimmo commented
Status: Needs review » Needs work
StatusFileSize
new popup_confirm_survey-result.txt17.33 KB

The automated review scripts still have quite a lot of issues with your code. Check the attached text file and be sure to set it back to 'needs review' once you are satisfied you have addressed all of the issues highlighted.

Possibly use the online tests before setting it back for review next time.

The automated report was generated with PAReview.sh, your friendly project application review script.

Source: http://ventral.org/pareview - PAReview.sh online service

drupaldev@assyst’s picture

drupaldev@assyst commented
Status: Needs work » Needs review

Hi,

Updated the script as per standards. Now there is no errors or warnings showing with PAReview.sh online service.

Review of the 6.x-1.x branch:
<ul>
</ul>
<i>This automated report was generated with <a href="/sandbox/klausi/1320008">PAReview.sh</a>, your friendly project application review script. Go and <a href="/project/issues/projectapplications?status=8">review some other project applications</a>, so we can get back to yours sooner.</i>
<br /><i>Source: http://ventral.org/pareview - PAReview.sh online service</i>

Thanks & Best Regards,
Assyst Team.

raynimmo’s picture

raynimmo commented

You should add a link to your project page to the main description at the top of this queue to facilitate easy access for reviewers. The only way to get to the project page is by clicking your username and then selecting it from the list of projects at the bottom of your profile. You should have a read of the Issue Summary Guidelines.

Automated Review

The automated tools are changing on a daily basis and while it may not have shown any errors previously it may now help to highlight some that it missed after its own codebase has been expanded upon and updated. I would advise you to check your own code against them on a regular basis or when you notice they have posted updated files.

There are still files other than README.txt in the master branch, make sure to remove them. See also step 5 in http://drupal.org/node/1127732

Automated Review of the 6.x-1.x branch:

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project.

For the current report please read http://ventral.org/pareview/httpgitdrupalorgsandboxdrupaldevassyst132820...

Manual Review

Your .info file has no 'core' value specified, for Drupal 6 you should add core = 6.x

You have a .project file in your repo, this was possibly added by your text editor. You should removed this from your repo unless it is required by your module.

Git commit messages
Your main listing of commits to the git repository offers very little in the way of documentation about what each commit is actually changing. Have a read of Commit messages - providing history and credit before you next push a commit to the repo.
Module file
The scan highlighted a few issues with regards to the correct implementation of the documentation blocks. You need to ensure that there are no blank lines between your function documentation and the the actual function code below it. Have a read of the Doxygen and comment formatting conventions with regards to functions
Install file
Again, nothing major to note in your install file apart from the minor formatting issues within the documentation blocks. Again though, check within the Doxygen and comment formatting conventions with regards to functions with special attention to the correct format for @return parameters.
JavaScript
As already pointed out in the automated review, your JavaScript has a number of issues related to the correct spacing and formatting to adhere to the JavaScript Coding Standards.

You implement a $(document).ready() call within your JavaScript when you should be using Drupal Behaviors.

Stylesheets
You should have a read of the Drupal CSS Coding Standards. Your reset.css file, although small, commits somewhat of a faux pas in my opinion. In the file you specifically set a reset that affects quite a lot of elements within the page, this may be to reset things within your popup but you should make the rules more specific so that you are not affecting the current site theme with any overides.

Also your styles.css could do with some improved formatting with regards to spacing and attribute alphabetization.

Licensing issues
jquery.countdown.min.js appears to be 3rd party code. 3rd party code is not generally allowed on Drupal.org and should be deleted. This policy is described in the getting involved handbook. It also appears in the terms and conditions you agreed to when you signed up for Git access, which you may want to re-read, to be sure you're not violating other terms.

The Libraries API module is a recommended method for adding 3rd party dependencies without directly including the code on Drupal.org.

Make sure to set your status back to 'needs review' once you have addressed the issues higlighted here. It would alsoi be advantageous if you used the online PAReview service at http://ventral.org/pareview/ before you next change the status.

raynimmo’s picture

raynimmo commented
Status: Needs review » Needs work
drupaldev@assyst’s picture

drupaldev@assyst commented
Status: Needs work » Needs review

Hi,

Thank you very much for your valuable comments.

We had changed the project files and other changes as per your suggestion. The Automated Review tool is showing still there are some other files rather than Readme.txt with the master branch. But we can't able to find any other unused files with the checkout on master branch.

There are still files other than README.txt in the master branch, make sure to remove them. See also step 5 in http://drupal.org/node/1127732

Please do some help for the above.

Thanks and Best Regards
Assyst Team

drupaldev@assyst’s picture

drupaldev@assyst commented

Hi,

There are still files other than README.txt in the master branch, make sure to remove them. See also step 5 in http://drupal.org/node/1127732

The issue has been resolved and now only the README.txt file is with master branch.

Thanks & Best Regards
Assyst Team

drupaldev@assyst’s picture

drupaldev@assyst commented
Issue summary: View changes

GIT Path and Drupal Version added

drupaldev@assyst’s picture

drupaldev@assyst commented

Hi,

Is there any latest update for the module review?

Thanks,
Assyst Team

raynimmo’s picture

raynimmo commented
Status: Needs review » Needs work

The automated review tools are still finding a number or errors within your code. They are mainly complaining about a lack of spacing within your CSS declarations and whitespace at the end of lines within your JavaScript.

Automated Review

Git checkout of branch 6.x-1.x fail

  • Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.

    • This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

    See the full report at http://ventral.org/pareview/httpgitdrupalorgsandboxdrupaldevassyst132820...

    I will try and find some time to do a manual review tomorrow but I am currently setting to 'needs work'.

    drupaldev@assyst’s picture

    drupaldev@assyst commented

    Hi,

    Resolved the issues reported by online tool.

    Can you please clarify the issue with git checkout. I had done the same from my end as Non-maintainer and works fine for me. The url is below

    git clone --branch 6.x-1.x http://git.drupal.org/sandbox/Drupaldevassyst/1328204.git popup_confirm_survey

    Thanks,
    Assyst Team

    drupaldev@assyst’s picture

    drupaldev@assyst commented
    Status: Needs work » Needs review
    tyler.frankenstein’s picture

    tyler.frankenstein commented
    Status: Needs review » Needs work

    Automated Review

    http://ventral.org/pareview/httpgitdrupalorgsandboxdrupaldevassyst132820...

    Came back clean.

    Manual Review

    I downloaded the jquery.countdown.min.js to the js folder in this module's directory. I then installed the module via drush on a fresh localhost copy of Drupal 6.24. Next, I granted permissions to access the popup confirm survey.

    I then created a content type called 'Survey' with a machine name of 'survey', followed by creating two page Nodes, one for Survey path, and one for Survey access denied page. I then went to the module configuration page and set node/1 to Survey path, and node/2 to Survey access denied.

    Then I added the module's block to the header region of the Garland theme. At this point the survey pops up and I am presented with a form and two radio buttons, 'yes, continue with the survey' and 'no, not this time.' No matter what radio button I choose and hit submit, the popup just keeps coming back and has basically locked user #1 out of the drupal site, this was bad.

    If a user didn't know how to use drush or access the system table in the database, they would basically be locked out of their drupal site. I had to use drush to disable and uninstall the module to get the site to respond to user #1 again.

    At this point the experience has not been very good. I would suggest the module configuration page be a bit more descriptive, I'm not sure if I am entering the right information. I was following the README instructions, and up until I added the module's block to the header region of Garland it was going OK. But once it locked me out (on a fresh D6 install), I decided to go no further with testing, this module may need some work, or the README needs to be more descriptive.

    Next, I looked over your module and install code. It looked fine from my understanding of Drupal coding standards. Basically, there needs to be more information on the project page as well as in the README, in my opinion.

    I would also suggest trying to reproduce the 'lock-out' scenario I described above and figure out why that is happening. If it is user error (i.e. myself entering wrong data into the module's config forms) you need to protect against that and inform the user and/or provide clearer directions on the configuration page.

    klausi’s picture

    klausi
    he/him||they/them
    Primary language German
    Location 🇦🇹 Vienna
    commented
    Status: Needs work » Closed (won't fix)

    Closing due to lack of activity. Feel free to reopen if you are still working on this application.

    klausi’s picture

    klausi
    he/him||they/them
    Primary language German
    Location 🇦🇹 Vienna
    commented
    Issue summary: View changes

    Sandbox project link added

    avpaderno’s picture

    avpaderno
    he/him
    Primary language Italian
    Location Brescia, 🇮🇹 🇪🇺
    commented
    Title: Popup Confirm Survey » [D6] Popup Confirm Survey
    Issue summary: View changes