Hi, using 7.x-2.x-dev and Context UI. Using the Context module to set an "active menu", but the nicemenus does not get the 'active-trail' class (or any active CSS class).

Is there a solution?

CommentFileSizeAuthor
#11 context_active_menu-1331264-11.patch1.52 KBaltrugon
#9 context_active_menu-1331264-9.patch2.1 KBduaelfr
#5 context_active_menu-1331264-4.patch1.77 KBaltrugon
#3 context_active_menu-1331264-3.patch1.62 KBaltrugon

Comments

Anonymous’s picture

Anonymous (not verified) commented

They're trying to solve this on the Context UI side,
#586396: Context Active menu problem

Anonymous’s picture

Anonymous (not verified) commented

Solution: in nice_menus.module, inside theme_nice_menus_build()

      $context_active = FALSE;
      if (module_exists('context')) {
        if ($contexts = context_active_contexts()){
          foreach ($contexts as $context){
            if (isset($context->reactions['menu'])) {
              if ($menu_item['link']['link_path'] == $context->reactions['menu']) {
                $context_active = TRUE;
              }   
            }   
          }   
        }
      }    
      
      if (($trail && in_array($mlid, $trail)) || $context_active) {
        $class .= ' active-trail';
      }
altrugon’s picture

altrugon commented
StatusFileSize
new context_active_menu-1331264-3.patch1.62 KB

Taking the solution mentioned on comment #2 as a guide I have created a patch that not only set the class "active-trail" but also the class "active" for the link.

This patch has been created from the master branch that is the recommended release 7.x-2.0.

altrugon’s picture

altrugon commented
Status: Active » Needs review
altrugon’s picture

altrugon commented
StatusFileSize
new context_active_menu-1331264-4.patch1.77 KB

Classic, I upload the patch and then apply it from here and it doesn't work.

Second try, and this one solves a problem with undefined index that the previous patch had.

BarisW’s picture

BarisW commented
Status: Needs review » Reviewed & tested by the community

Cool. Patch works great. Thanks!

Anonymous’s picture

Anonymous (not verified) commented

#5 worked for me!

vordude’s picture

vordude commented
Status: Reviewed & tested by the community » Needs work

I'm inclined to think we could be better off in adding an active class where one belongs instead of creating specific code that works with 1 other specific contributed module? (albeit a popular one)

duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented
Status: Needs work » Needs review
StatusFileSize
new context_active_menu-1331264-9.patch2.1 KB

@vordude I agree but waiting for the better solution, this one works ;)

@altrugon Your patch does not seems to activate selected menu parents. Here is a new improved patch based on yours.

osopolar’s picture

osopolar
Primary language German
Location 🇩🇪 GER 🌐
commented

Maybe this fixes this issue: #835090: Context Reaction: Set menu trail

altrugon’s picture

altrugon commented
Version: 7.x-2.x-dev » 7.x-2.1
StatusFileSize
new context_active_menu-1331264-11.patch1.52 KB

I can't believe this hasn't been fixed yet, my last post was submitted in 2011 and neither Nice Menu or Context have solved it yet :(

Anyhow here goes another patch against Nice Menu 7.x-2.1 that is the stable release at this moment.

xiukun.zhou’s picture

xiukun.zhou commented
Status: Needs review » Fixed

Thanks a lot to altrugon, DuaelFr, morningtime and everyone else for the great work on the patches, testing, reviews and reporting.

It's more time this got committed and I went ahead and had this rolled at: 7.x-2.x: 6969cde.

Marking this as fixed.

Please let me know if you would have any other questions, comments, issues or concerns on any of these changes, I would be glad to provide more information.
Thanks again to everyne for the help and great work on this issue.

Cheers!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.