Vocabulary hierarchy in path

Thanks for the quick response and the patch. Looks good with one issue, however I don't think the issue relates to the workbench_access module.

I updated the alias patterns to use [node:workbench-access-section-hierarchy]/[node:title] but when I create a page instead of the alias being written as parent/child/section/node it is written as parentchildsection/node so it appears Pathauto is stripping the '/' from the alias when it's being created.

I think the cause of this is outside the workbench_access module though since the value returned from workbench_access_tokens is correct and if I replace '/' with '-' in the implode call on the sections hierarchy the '-' is preserved in the alias with the result being parent-child-section/node.

I'm going to dig around and will file a bug report in Pathauto once I pinpoint the cause.

Thanks,
Pablo

Scratch that as being a problem with pathauto. Just looking through the pathauto code and read something that prompted me to look into the config a little more where I just had to disable removal of the '/' in the alias and it works perfectly.

Thanks again.

Cheers,
Pablo

Hi again. I think I've found a small bug in the patch in #2 but it is an easy fix. Unfortunately I don't have source control set up yet so I can't generate a patch file but I've provided the updated code and an outline of the bug below.

Here is the problem code, from the 'workbench-access-section-hierarchy' case in the switch statement in the workbench_access_tokens function:

foreach ($hierarchy as $value) {
  $list[] = $value['name'];
}
$list[] = $name;

The problem arises when a node is created in a section that is the root of a vocabulary. In this case the section will be printed twice in the alias since it gets assigned once as part of the hierarchy, and again as the section name once the iteration of the hierarchy is complete.

The fix for this is just to wrap the foreach in a check to see if the hierarchy has more than one element:

if (count($hierarchy) > 1) {
  foreach ($hierarchy as $value) {
    $list[] = $value['name'];
  }
}
$list[] = $name;

I created a clean instance of Drupal with only workbench access and pathauto, as well as the necessary underlying modules, installed, and was able to reproduce it there using the default 'Tags' vocabulary.

I'm not sure if this is the best practice approach as I'm still relatively new to coding standards and structure in Drupal but it seems to fix the problem. Look forward to your response as to whether this is the correct fix.

Thanks,
Pablo

Hi again @Dave Reid and @agentrickard.

I discovered this week that my suggested fix in #11 above was erroneous.

The problem stems from the fact that when using the name of a vocabulary as the section assignment for a node, the call to workbench_access_get_parents returns the vocabulary name as its own parent. After the iteration through the hierarchy the name of the vocabulary is appended to the $list variable and the result is the duplication of the vocabulary name.

The fix for this could be applied in one of two places, so I'm looking for advice as to which you think it should be:

1. workbench_access_tokens() function in workbench_access.tokens.inc

If the fix is applied here, one would need to modify the following:

foreach ($hierarchy as $value) {
  $list[] = $value['name'];
}

to this:

foreach ($hierarchy as $value) {
  if ($access_id != $value['name']) {
    $list[] = $value['name'];
  }
}

2. workbench_access_get_parents() function in workbench_access.module

If the fix is applied here, one would need to modify the following:

if (isset($info['children']) && in_array($access_id, $info['children']) && isset($active['active'][$id])) {

to this:

if ($access_id != $id && isset($info['children']) && in_array($access_id, $info['children']) && isset($active['active'][$id])) {

Both of these methods yield the same end result but I lean toward #2 as being the correct fix since the vocabulary name is not its own parent and so should not be returned as part of the $parents array when workbench_access_get_parents is called.

Thoughts?

Thanks,
Pablo

Awesome! Look forward to seeing it, Dave.

Cheers,
Pablo

Hi richardhayward. The solution I've implemented and which has worked fine for us thus far (both on creation and updating of content) has been as follows:

1. Apply patch from http://drupal.org/node/1319988#comment-5175432

2. Apply patch from http://drupal.org/node/1332512#comment-5210518

3. Apply one of the changes from http://drupal.org/node/1332512#comment-5520420. I use change #2 from this post.

Then I use the following pattern in Pathauto configuration to create the correct URL:

[node:workbench-access-section-hierarchy]/[node:title]

This will resolve the 'unassigned' issue, and will also ensure the correct hierarchy structure in the url.

Not sure what the status is of these changes being packaged up into an official release, but until that happens this should at least resolve the issue for you.

Hope that helps.

Thanks,
Pablo

@agentrickard, the helper function you reference, does this address the issue of hierarchy in the path in a different manner? Or does it just address the path as it's presented in the Workbench Information block?

Thanks,
Pablo

@blainelang, I don't think there has been an update on this issue. I'm currently in the process of upgrading out of date modules in our Drupal instance and I had to follow the steps I outlined in #17 above (http://drupal.org/node/1332512#comment-6309158) to have things work correctly.

I've PM'd Dave Reid to see what needs to happen to get these changes into a future release.

Cheers,
Pablo

Setting this issue to properly reflect the 'Code' component rather than 'Miscellaneous'.