Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.The main motivation behind this patch is to get rid of this hack, which generates errors on my testsite form time to time:
// Multistep is set to TRUE as a hack to allow in_block to be accessed
// when voting via ajax in a block - there may be a better way to do this.
$form['#multistep'] = TRUE;
I also think this code is easier to grasp.
Added themable block. Only drawback I've found so far is that the "Older polls" link only shows up after a page refresh, but I think that's ok. The "cancel vote button" and "# votes" which was hidden before in the block can preferably be hidden with css instead.
If I get a review I commit this.
| Comment | File | Size | Author |
|---|---|---|---|
| advpoll_simplify_block.patch | 11.51 KB | anders.fajerson |
Comments
Comment #1
ChrisKennedy commentedOh you hate that multistep hack so much :P You might read the discussion about it in the FormAPI 3 patch (http://drupal.org/node/138706).
Anyway, this patch looks fine to me. It needs to be re-rolled after the rich text change though.
Comment #2
anders.fajerson commentedI don't hate it, my server does :P
Re-rolled and commited, hopefully without errors...
Comment #3
(not verified) commented