Hi there,

I'm just doing my first major D7 Simplenews installation, congrats on a great job everyone.

Found a small bug though. I have a Newsletter Testing subscription that I do a full send of a newsletter before it goes out to customers. After checking it's all good, I then reset the sent status in the database table, switch to the other subscription, and do another full send.

In Simplenews 7.x when switching the subscription radios on the node edit form, the new subscription is not reflected in the db table simplenews_newsletter - tid. I have to change it via phpmyadmin to get the new subscription list to queue in the spool.

Comments

simon georges’s picture

simon georges commented
Version: 7.x-1.0-alpha1 » 7.x-1.x-dev
berdir’s picture

berdir
Primary language German
Location Switzerland
commented

The simplenews_newsletter category certainly should be updated to reflect changes on the node, will need to investigate why this doesn't happen. Sounds like an easy to thing to extend our tests with.

I actually think that changing the category should reset the sent status, any reason not to?

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Closed (duplicate)

Confirmed and fixed, including tests, in #497108: Send newsletter when node is published.

Note that it's currently not clear what should happen to the state and subscriber count if mails were already sent. The current patch in the linked issue doesn't touch these values.

You're welcome to open a issue about that topic to discuss it, e.g. if a change should automatically re-set these values.