Love the responsive gpanels.

Is it possible to have stacked gpanels?

- Two column stacked
- Three column 25/50/25 stacked
- Three column 33/33/33 stacked
- Four column stacked

and support for a One column panel.

CommentFileSizeAuthor
#6 panelayout.png10.73 KBpiwicasso

Comments

Jeff Burnz’s picture

Can you explain what you mean by stacked?

mowgli’s picture

I am thinking of the Panels module. Maybe the terminology is not the same, but what I have in mind is a "vertical" gpanel where the blocks in it are stacked vertically one on top of the other.

Currently the "Three column 33/33/33" gpanel would have the blocks lined up horizontally by default. Is it possible to have them lined up vertically?

Jeff Burnz’s picture

I get what you mean, however a 33/33/33 would be one column right - but only 33% width of the page, or am I still not really understanding what you mean (a picture would be worth a thousand words here).

I can see the usefulness of stacked gpanels, interesting idea.

mowgli’s picture

This page show pictures of stacked layouts:

https://github.com/perusio/panels_extra_layouts

Jeff Burnz’s picture

Yeah, thats a good link, so more like a grid pattern, or the classic stacked Panels-like layouts. I think this is a great idea and will certainly put some thought behind it.

piwicasso’s picture

StatusFileSize
new10.73 KB

Gpanel is the coolest unique feature of AT. I second the request for "stacked gpanels". Here is another picture of the stacked layouts taken directly from the Panels module (Mini Panels):

Jeff Burnz’s picture

From that list http://drupal.org/files/panelayout.png, which ones would people be most interested in?

Petemoss’s picture

I vote for the following, in order of top preference:

1. Flexible
2. Two column 50/50 stacked
3. Three column 25/50/25 stacked
4. Three column 33/33/33 stacked
5. Two column 50/50 bricks
6. Four column stacked

Thanks Jeff for a great theme.

truegal’s picture

I am interested in

- Three column 25/50/25 stacked
- Three column 33/33/33 stacked
- Two column 50/50 stacked
- Two column 50/50 bricks
- Flexible
- One column
- Four column stacked

piwicasso’s picture

My top choices:

- Three column 25/50/25 stacked
- Three column 33/33/33 stacked
- Two column 50/50 stacked
- Two column 50/50 bricks
- Four column stacked
- Flexible

The following are not in the Panels picture, but Two column 33/66 and Two column 66/33 are in AT ... so would like them to be stacked as well :

- Two column 33/66 stacked
- Two column 66/33 stacked

Thanks a million.

mowgli’s picture

From the Panels picture:

  • Three column 25/50/25 stacked
  • Three column 33/33/33 stacked
  • Two column 50/50 stacked
  • Two column 50/50 bricks
  • Four column stacked
  • Flexible

Not in the Panels picture, but would like these AT gpanels to be stacked :

  • Three column 25/25/50 stacked
  • Three column 50/25/25 stacked
  • Two column 33/66 stacked
  • Two column 66/33 stacked

Many thanks.

Jeff Burnz’s picture

The one I will veto is the Flexible layout, I don't want to build a UI or support one, Gpanels were always meant to be this really lite-weight thing that did not rely on anything but Drupal core and a bit of CSS. I want to keep it simple.

That would make our list:

  • Two column 50/50 stacked
  • Two column 33/66 stacked
  • Two column 66/33 stacked
  • Two column 50/50 bricks
  • Three column 33/33/33 stacked
  • Three column 25/50/25 stacked
  • Three column 25/25/50 stacked
  • Three column 50/25/25 stacked
  • Four column stacked

9 additional layouts, phew, you guys don't ask for much eh?

This will explode the size of the info file, even though its commented out for the most part, I wonder if we move all the actual region definitions to the example file and you have to do a two step process of copying them to the info file?

truegal’s picture

I think the documentation should be updated at several places.

I am all for moving the region definitions in the info file of adaptivetheme_subtheme to the README.TXT of the adaptivetheme/gpanels directory.

1) The README.TXT of adaptivetheme/gpanels should remind users to add those regions to the info of their themes (listing ALL region definitions to help the users).

2) Each gpanel php file (for example, 3col-25-25-50.php) in adaptivetheme/gpanels should say something like:

* How to use a Gpanel:
 * 2. Copy and paste the matching region definition from the adaptivetheme/gpanels/README.TXT to your theme info file.

3) The README.TXT of adaptivetheme should remind users to add the regions of gpanels to their theme info file, and redirect them to the README of adaptivetheme/gpanels.

4) The info of adaptivetheme_subtheme should still keep the comment for gpanels;----------// Gpanel Regions, and maybe add another comment below it saying something like: ;----------// See the README.TXT of adaptivetheme/gpanels directory for region definitions, and copy and paste them here.

piwicasso’s picture

The list of new gpanels looks good.

The info file can be long and hard to read. I don't see any problem in moving the region definitions as long as it is well documented as suggested by #13.

A variation of step 2) in #13 is to move each region definition to the corresponding gpanel php in adaptivetheme/gpanels . That way, the users see the code at the same place, copy and paste both the gpanel html/php and region definition at the same time.

; 3 col 25-25-50 : copy and paste to your theme info file
regions[three_25_25_50_first]  = 3col 25-25-50 Gpanel col 1
regions[three_25_25_50_second] = 3col 25-25-50 Gpanel col 2
regions[three_25_25_50_third]  = 3col 25-25-50 Gpanel col 3

<!-- Three column 25-25-50 Gpanel : copy and paste to your theme page.tpl.php -->
<?php if ($page['three_25_25_50_first'] || $page['three_25_25_50_second'] || $page['three_25_25_50_third']): ?>
  <div class="three-25-25-50 gpanel clearfix">
    <?php print render($page['three_25_25_50_first']); ?>
    <?php print render($page['three_25_25_50_second']); ?>
    <?php print render($page['three_25_25_50_third']); ?>
  </div>
<?php endif; ?>
Jeff Burnz’s picture

Component: Code » CSS/HTML

I have done some thinking about this issue and have come up with a plan that works in tandem with the Responsive Panels features I am building, see this issue #1332796: Make Panels layouts responsive

I have built 14 Panels layouts - some are responsive overrides for existing panels layouts and some are new. They are all stacked but for most the Top and Bottom panes/regions are optional (they only appear if you use them).

This is what I want to do with Gpanels as well - there will 14 identical Gpanels layouts that are essentially the same as the Panels layouts.

The Panels layouts and Gpanels layouts all have identical HTML, classes and CSS and the new system injects the CSS into the themeName.responsive.layout.css file, so there is no longer a seperate stylesheet for Gpanels - it is now automated to be aware of your media queries.

Hopefully I can get this out as a working demo/dev in about a week, or maybe sooner.

See this comment for a screenshot of the new layouts: http://drupal.org/node/1332796#comment-5584368

Jeff Burnz’s picture

Version: 7.x-2.1 » 7.x-3.x-dev
Assigned: Unassigned » Jeff Burnz
Category: feature » task

All done, its in the 7.x-3.x dev version awaiting your download for testing.

Please see the above comment for some more details. In short I have nuked the responsive gpanels css file and instead all responsive CSS is written automatically by the theme to themeName.responsive.layout.css in the public file dir.

This wont work with your 7.x-2.x theme btw, unless you make some changes to the classes used in your Gpanels. The only real class change is exchanging "gpanel" for "at-panel", seems annoying and trivial but I need a generic class I could use accross all panel types (Panels module layouts and Gpanels), other than that I have followed what we discussed here, such as moving the region definitions into each Gpanel php file and removed them all from the info file.

Jeff Burnz’s picture

Status: Active » Needs review

ops, needs review and testing!

Jeff Burnz’s picture

Seeking feedback #1447426: Design and build UI for Responsive Panels Layout Options

Remember - this UI will control not only Panels layouts but all Gpanels layouts as well, making them configurable per device orientation.

Jeff Burnz’s picture

Status: Needs review » Fixed

Big update into 7.x-3.x, this is fixed well and truly, you got your stacked Gpanels, and Panels layouts as well, all with responsive capability and a UI for setting them up. Phew... who says I don't support my projects!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.