Closed (fixed)
Project:
Millennium OPAC Integration
Version:
6.x-2.0
Component:
Miscellaneous
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
10 Nov 2011 at 20:51 UTC
Updated:
28 Nov 2011 at 20:50 UTC
On line 179 of millennium.cron.inc in version 6.x-2.0 this check will always return TRUE:
if (sizeof($fetched["found"] > 0 )) {
and thus the variable $sequential_tot_notfound never gets larger than 50. Thus this check on line 209 never happens if your max import setting is greater than 50:
// Do rollover when no records were found in this cron run after 5% the estimated database size
if ($last_tried_itemnum > $rollover_limit && $sequential_tot_notfound >= $max_to_import) {
watchdog("Millennium", "Crawl will start over, as it has detected no records after #@recnum", array("@recnum" => $rollover_limit));
_millennium_crawl_restart();
}
Instead it should be
if (sizeof($fetched["found"]) > 0) {
The issue also appears to exist in 6.x-2.x-dev.
Comments
Comment #1
janusman commentedYikes! Great catch!
I'll fix it in DEV ASAP!
Thanks!
Comment #2
janusman commentedFixed in both branches! Thanks again.
Comment #3
janusman commented