Closed (duplicate)
Project:
Subscriptions
Version:
5.x-2.0-beta9
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
4 Apr 2007 at 23:38 UTC
Updated:
20 Jan 2008 at 15:30 UTC
Jump to comment: Most recent
Comments
Comment #1
leoklein commented+1 on this.
The reason why this is important is that the author of the post may be "updating" it with something as trivial as a spelling correction.
Comment #2
kmillecam commented+1 from me too.
Sometimes we go into a document 10 or 15 times before it's "perfect". With the current code, my users get 10 or 15 notifications for each node (because of our crazy editing style).
Thanks,
Kevin
Comment #3
mcsolas commentedI figure that editing style is very common.. or at least a few : )
Any word on progress. When I did something similar I called the column "Notified" & when the email fires, you have to set it to 0/false for that users|subscription|thread relationship.
Comment #4
kimangroo commented+1 here as well. Actually I though the subscription module did that already! I've only just started using it now. On a busy site, repeated emails would have me running away from that site as fast as possible.
Comment #5
salvissubscribing
(please don't change the title!)
Comment #6
kimangroo commentedOops sorry! To be honest I don't really know how this section of the site works... What's with the priority, assigned and status stuff... I know for me the priority is very high! ;)
Comment #7
Anonymous (not verified) commentedIsn't this here a duplicate of the following:
http://drupal.org/node/76468
I know that it only relates to 4.7, but there is a patch mentioned for Drupal 5.1...
Comment #8
Anonymous (not verified) commentedI have tried the patch, but it did not work (at least not on my installation). This is very unfortunate as there seems to be a lot of demand for this or a similar feature - compare the following postings:
http://drupal.org/node/86741
"Currently users can get bombarded on busy sites."
http://drupal.org/node/76468
"If the editor has 20 goes at updating a page because he is not quite sure how to do it, members ger 20 notifications and then write to me to complain!"
http://drupal.org/node/142454
"...would be great so it reduces the amount of mail load."
To me this seems like a very important feature and you don't need busy sites to make this a big problem. Even 10-15 daily comments on a thread (=10-15 emails where just one would have been enough) are enough to really annoy users. I would love to do the programming, but my PHP is very limited. Anything else I could do to make this happen?
Comment #9
mcsolas commentedStrictly from a scale factor like you say - I was quite surprised there has been no cut off switch installed.
That cut off is why the drupal forums themselves probably dont allow people to subscribe to threads.
I figure the subscription system also can reduce the load on the server.
1. people go directly to the page they want to see
2. they only come back when they need to
Presently, without this, you have to visit your own tracker page. It has to scan then entire drupal database to check if a thread has been updated for you. That page must take massive amounts more processor cycles to calculate...
Comment #10
chx commentedYou can now easily set up sending intervals.
Comment #11
Anonymous (not verified) commentedThank you for the work on this - it looks really helpful and my users will love this feature. Nevertheless, it does not really fix the bug - to quote mscolas
Comment #12
jaysmall commentedHere's a slightly different use case:
Site contains events associated with venues. Venues are categorized in a taxonomy.
I want users to be able to, in effect, subscribe to specific venues by selecting their taxonomy terms. Then they'll be notified either when we update the venue details OR post new events associated with a venue, because we'll associate both with the venue's taxonomy term.
Users could, obviously, subscribe to more than one venue term. And we could wind up adding many events every week -- again, the potential for bombarding users is very real.
We don't expect lots and lots of edits of the same nodes, but lots of time-sensitive new node creations. Also, we'd like the users to have a predictable volume of incoming messages from the site.
Ideally, users could say, "I want to receive only one message per [day | week | month] with all my current notifications from this site rolled into one message at the time of the send."
Possible? Impossible? I'd sure love to have access to that kind of "My Agent email" capability within Subscriptions.
Comment #13
jaysmall commentedI guess I should clarify the difference between the original feature request and what I'm asking for.
Original request: limit to one e-mail notification per *subscription* (either via cron or instantly when subscribed content is updated) until user logs in and checks the updated content.
My request: one e-mail notification per *user* per selected interval containing all notifications from all subscriptions for that user. Doesn't reset on log-in because the user requests notifications on a selected interval (1x day|week|month) of anything new since the last send, not since last log-in.
Make sense?
Comment #14
Anonymous (not verified) commentedYour description does make sense, but I would suggest having that as a separate feature request - as you say yourself it is not entirely what the original posting was about.
Comment #15
salvisThis is essentially how it's supposed to work now. Please open a new issue if it doesn't.
The present feature request is about a different strategy, which might also be useful.
Comment #16
jaysmall commentedUpon further testing, Salvis, you are correct -- my use case is the way the 2.x version appears to work now. Thanks for the responses!
Comment #17
mcsolas commentedI would contribute code-wise but I am completely at a loss when dealing with php. Im a coldfusion coder / application designer who at one point downloaded every open source forum application I could find, tore them apart, analyzed the db structures and went to design a forum system using only 5 tables (ran in coldfusion). I know what Im talking about here when it comes to the design level.
Without these email notifications, after posting requesting help on issues I really need to solve, I find myself pinging tracker 5-10 times a day. I feel bad even, because each page load has to scan the entire node table.. takes quite a while sometimes, so I know I am 'wasting' precious server resources, but I also need to solve my problems and keep working..
The thing is that you have no choice here but to rely on tracker to keep track of drupal org site activity.
(slightly off topic - check my posts re: tracker, there is some pretty crucial changes that could be made there as well)
imo those tracker queries are a massive waste of server resources because in most cases, I would have either
a. not visited the site ( no email means no threads updates, keep waiting )
b. gone directly to the node in question, skipping the full table "tracker" query
This cutoff switch isnt hard to implement. It will require a single new column in the "subscriptions" table "notified" which is either {true|false}.
When an email fires "onNodeUpdate", the row is set to true.
When the user returns and creates a new session, all rows set to that users id are set to false
Please if anyone has questions about how and where the logic goes, I offer my time to help you sort this out, just ask I will be most happy to try and make even more specific suggestions ( although remember, im not familiar with php, I can only help at the design level ).
Comment #18
mcsolas commentedDidnt mean to change the issue title
Comment #19
oc commented+1 this is a good idea, to allow a lower traffic notification of just a single update before the user logs in again.
Comment #20
gustav commentedThere now is a patch for this at http://drupal.org/node/210548