Comments

benys’s picture

I added translations in table.

benys’s picture

fix warning

benys’s picture

jose reyero’s picture

Status: Needs review » Needs work

This still produces some warnings. Try filtering by type.

We need to isset() all of the properties before replacing them. Also could we use a list of translated names for all the replacements instead of translating every time with i18n_string() ?

Otherwise the patch looks good.

benys’s picture

I cached translaslated type names.

Could you report me some warnings and notices?

Ashraf Amayreh’s picture

Is this patch for translating content type names? Also, would it translate the content type names on the node/add page? I've been redirected to i18n to translate my content type names but can't seem to find this functionality. Any help appreciated.

Ashraf Amayreh’s picture

Nevermind. It was i18n_node (multilingual content) module that did that.

jose reyero’s picture

Status: Needs work » Needs review

Setting to needs review for the testbot.

Status: Needs review » Needs work

The last submitted patch, i18n_node_translate_types_in_admin_content_1.patch, failed testing.

OnkelTem’s picture

Title: Types names in admin/content not translated » Types names in admin/structure/types are not translated
Version: 7.x-1.1 » 7.x-1.5
Component: Miscellaneous » Node
Category: task » bug
Status: Needs work » Active

Content types along with content type's hints are not translated on admin/structure/types page.

Can this be achieved via altering query from node.module:695:

  $query = db_select('node_type', 'nt')
    ->addTag('translatable')
    ->addTag('node_type_access')
    ->fields('nt')
    ->orderBy('nt.type', 'ASC');

Why this was considered as a task?

jose reyero’s picture

Category: bug » task

@OnkelTem,
Sure, and you'll be the first one using that tag for something useful. However this module aims to translate stuff at 'display time' only so we wouldn't take that patch.

And it is a task because IMHO there's nothing wrong with that page being in default language, never intended to be other way.

I think admin pages are ok the way they are (default language), not sure this is worth the work.

jose reyero’s picture

Status: Active » Closed (won't fix)

Closing this one.