Download & Extend

Types names in admin/content not translated

Project:Internationalization
Version:7.x-1.1
Component:Miscellaneous
Category:task
Priority:normal
Assigned:Unassigned
Status:needs work

Issue Summary

I added form hook to translate type nodes.

AttachmentSizeStatusTest resultOperations
i18n_node_translate_types_in_admin_content.patch1.13 KBIdleFAILED: [[SimpleTest]]: [MySQL] 1,845 pass(es), 15 fail(s), and 3 exception(s).View details | Re-test

Comments

#1

I added translations in table.

AttachmentSizeStatusTest resultOperations
i18n_node_translate_types_in_admin_content.patch1.45 KBIdleFAILED: [[SimpleTest]]: [MySQL] Invalid patch format in i18n_node_translate_types_in_admin_content_0.patch.View details | Re-test

#2

fix warning

AttachmentSizeStatusTest resultOperations
i18n_node_translate_types_in_admin_content.patch1.45 KBIdleFAILED: [[SimpleTest]]: [MySQL] Invalid patch format in i18n_node_translate_types_in_admin_content_1.patch.View details | Re-test

#3

AttachmentSizeStatusTest resultOperations
i18n_node_translate_types_in_admin_content.patch1.89 KBIdleFAILED: [[SimpleTest]]: [MySQL] Invalid patch format in i18n_node_translate_types_in_admin_content_2.patch.View details | Re-test

#4

Status:needs review» needs work

This still produces some warnings. Try filtering by type.

We need to isset() all of the properties before replacing them. Also could we use a list of translated names for all the replacements instead of translating every time with i18n_string() ?

Otherwise the patch looks good.

#5

I cached translaslated type names.

Could you report me some warnings and notices?

AttachmentSizeStatusTest resultOperations
i18n_node_translate_types_in_admin_content_1.patch2.39 KBIdleFAILED: [[SimpleTest]]: [MySQL] 1,845 pass(es), 15 fail(s), and 3 exception(s).View details | Re-test

#6

Is this patch for translating content type names? Also, would it translate the content type names on the node/add page? I've been redirected to i18n to translate my content type names but can't seem to find this functionality. Any help appreciated.

#7

Nevermind. It was i18n_node (multilingual content) module that did that.

#8

Status:needs work» needs review

Setting to needs review for the testbot.

#9

Status:needs review» needs work

The last submitted patch, i18n_node_translate_types_in_admin_content_1.patch, failed testing.