Nodeconnect widget should work also with other widgets than autocomplete, e.g. radiobuttons.

CommentFileSizeAuthor
#7 nodeconnect_support_select_widget-1341592-7.patch4.64 KBdtarc
#6 nodeconnect_support_select_widget-1341592-6.patch4.71 KBdtarc
#3 nodeconnect_support_other_widgets-1341592-3.patch7.2 KBdtarc

Comments

geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented
Status: Active » Needs review

ok, i implemented this and to keep it reviewable i made a series of commits of it.
get it at the dev branch of my sandbox: http://drupal.org/sandbox/axel.rutz/1341736

as i was at it i added a fix for #1101868: The "add a new" button fails if field is required or has unmatched text

after applying these patches i have a minor issue:
"edit" button does not do the right thing.
but too late now, i'll go to bed.

Fidelix’s picture

Fidelix commented

I really need this working with the autocomplete_deluxe widget
Does your implementation work with it, axel.rutz?

Thanks for the work, btw

dtarc’s picture

dtarc commented
StatusFileSize
new nodeconnect_support_other_widgets-1341592-3.patch7.2 KB

This patch adds a nodeconnect add button for node references with select widget. It does not add a nodeconnect edit button. Support for add/edit of node references with autocomplete widget is not affected.

This patch is based on some code in the sandbox linked to in comment #1. It also has additions to nodeconnect_return_node_form_alter() which I needed in order to make it work.

We will likely need to support nodeconnect edit for node references with select fields in this project I am working on. If I do build that I will ad an updated patch.

socialnicheguru’s picture

socialnicheguru commented

patch does not apply cleanly

dtarc’s picture

dtarc commented

The patch does apply to the alph2 release but does not apply to the dev snapshot since this commit -- http://drupalcode.org/project/nodeconnect.git/commitdiff/156f1ae309c0c34...

I'll reroll a new patch. Also, I've noticed the edit bug mentioned in #1, I'll try to fix that too.

dtarc’s picture

dtarc commented
StatusFileSize
new nodeconnect_support_select_widget-1341592-6.patch4.71 KB

New patch rerolled. This patch adds support for the select widget. It enables the add button on all select widgets and enables the edit button on single value select widget. The edit button does not get displayed for multiple value select widgets (UI issues would need to be sorted before this can happen.

This patch depends on the patch in comment #5 of #1558574: Move addition of add/edit form elements to their own functions
http://drupal.org/files/nodeconnect_abstraction_form_additions-1558574-5...

These patches are being broken up in the hopes that they will be committed sooner. If the maintainers would like I can bundle these two patches up together.

dtarc’s picture

dtarc commented
StatusFileSize
new nodeconnect_support_select_widget-1341592-7.patch4.64 KB

Rerolling the patch from #6 with a debug statement removed.