Optimize element_children() [#1345204]

Comment	File	Size	Author
#9	drupal-optimize-element_children-1345204-9.patch	779 bytes	mikeytown2

#6	drupal-optimize-element_children-1345204-5.patch	596 bytes	mikeytown2

#1	drupal-optimize-element_children-1345204-1.patch	598 bytes	mikeytown2

File	Size
drupal-optimize-element_children-1345204-1.patch	598 bytes

Comment #2

mikeytown2 CreditAttribution: mikeytown2 commented 17 November 2011 at 20:46

Log in or register to post comments

Comment #3

Peter Bowey CreditAttribution: Peter Bowey commented 18 November 2011 at 04:18

Query: How does this patch measure up in light of the comments by sun?
See: http://drupal.org/node/639974#comment-3666548

Log in or register to post comments

Comment #4

mikeytown2 CreditAttribution: mikeytown2 commented 18 November 2011 at 07:27

That comment was directed towards 7.x.
This patch flattens out element_children() by in-lining element_child(). Code wise they will always output the same; just element_child doesn't get called thousands of times now.

Log in or register to post comments

Comment #6

mikeytown2 CreditAttribution: mikeytown2 commented 22 November 2011 at 02:18

File	Size
drupal-optimize-element_children-1345204-5.patch	596 bytes

Another round of optimizations to the code here :)

Stock:
Total Self: 92ms
Total Cumulative: 460ms
element_children() calls: 2,470

Patch #1:
Total Self: 67ms
Total Cumulative: 74ms
element_children() calls: 2,482

This Patch:
Total Self: 39ms
Total Cumulative: 39ms
element_children() calls: 2,482

Log in or register to post comments

Comment #7

fabsor CreditAttribution: fabsor commented 6 February 2012 at 14:16

Status:

Needs review

» Reviewed & tested by the community

I tried this to, and I get an even better return from this, closer to about 800ms on a site with a lot of modules, including vertical tabs and node relationships. This is a pretty extreme example, but there are a lot of those out there.

This is completely unintrusive, so I don't see why we can't get this into core.

Log in or register to post comments

Comment #8

Gábor Hojtsy

he/him

Hungarian

Hungary

CreditAttribution: Gábor Hojtsy commented 16 April 2012 at 13:23

Status:

Reviewed & tested by the community

» Needs work

1. Was this already applied to Drupal 7?
2. Can we get some inline documentation about what is going on there? The issue comments explain here what is being inlined, but the code might easy be cryptic after the commit to the uninitiated.

Log in or register to post comments

Comment #9

mikeytown2 CreditAttribution: mikeytown2 commented 16 April 2012 at 19:17

Status:

Needs work

» Needs review

File	Size
drupal-optimize-element_children-1345204-9.patch	779 bytes

element_children() in D7 vs D6 are miles apart from each other, but the call to element_child() has been inlined in the D7 code, so you can say this has already been applied to Drupal 7.

Updated patch to add in a comment about in-lined code.