- consistent usage
- does not have the overhead of a function call

CommentFileSizeAuthor
#7 length.patch11.03 KBdroplet
#4 length.patch10.58 KBdroplet
length_instead_size.patch10.61 KBdroplet

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +JavaScript
sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Issue tags: -JavaScript

length_instead_size.patch queued for re-testing.

Status: Reviewed & tested by the community » Needs work
Issue tags: +JavaScript

The last submitted patch, length_instead_size.patch, failed testing.

droplet’s picture

droplet commented
Status: Needs work » Needs review
StatusFileSize
new length.patch10.58 KB
sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Reviewed & tested by the community

.size() is a pointless function, which does nothing else than to return this.length.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Nice little clean-up. Committed to 8.x. Thanks.

droplet’s picture

droplet commented
Version: 8.x-dev » 7.x-dev
Assigned: Unassigned » droplet
Status: Fixed » Needs review
Issue tags: +Needs backport to D7, +JavaScript clean-up
StatusFileSize
new length.patch11.03 KB
nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs review » Reviewed & tested by the community

All in order

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 7.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.