Under PHP 5.3, I'm seeing the following PHP warnings, which I've tracked down to the Ooyala module:

Deprecated function: Call-time pass-by-reference has been deprecated in drupal_load() (line 1105 of /www/drupal/includes/bootstrap.inc).

This warning prevented Drush from working as expected, so it's not only a coding style issue.

CommentFileSizeAuthor
#9 ooyala_call_by_reference-1347856.patch679 bytesquicksketch
#1 ooyala-1347856-1-call_time_reference.patch1.54 KBarithmetric

Comments

arithmetric’s picture

arithmetric commented
Status: Active » Needs review
StatusFileSize
new ooyala-1347856-1-call_time_reference.patch1.54 KB

Attached is a patch to remove the problem code.

jyee’s picture

jyee commented

I didn't find this patch until just now, but I had made the exact same changes manually and they removed the warnings.

deviantintegral’s picture

deviantintegral commented
Status: Needs review » Fixed

Patch looks great to me. Committed to 7.x-1.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Media Crumb’s picture

Media Crumb commented

*whoops*

Media Crumb’s picture

Media Crumb commented
Status: Closed (fixed) » Active

I'm seeing this same issue under the Ooyala Channels module. Anyone else have this problem and/or know how to fix it?

Media Crumb’s picture

Media Crumb commented

Fixed. I'll add a patch when I get home. Sorry for reopening.

quicksketch’s picture

quicksketch
he/him
commented

@MediaCrumb: Could you post your patch? Does this affect the current 2.x versions?

quicksketch’s picture

quicksketch
he/him
commented
Version: 7.x-1.x-dev » 7.x-2.0-beta6
Issue summary: View changes
Status: Active » Fixed
StatusFileSize
new ooyala_call_by_reference-1347856.patch679 bytes

I found this call-by-reference in the 7.x-2.x branch of Ooyala project in the Ooyala Channels module. I didn't see any other call-by-references, so hopefully this resolves the instance that's causing trouble.

Committed to the 7.x-2.x branch. I couldn't find issues in the 6.x-2.x branch.

Media Crumb’s picture

Media Crumb commented

That was the same patch I had quick. So sorry I forgot to post it. Been using it since November with no issues.

quicksketch’s picture

quicksketch
he/him
commented

Thanks @MediaCrumb for the confirmation. :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.