Tags view doesn't adopt correct vocabulary

I'm a raulmuroc's colleague.

We tried repeating same steps we did in D6:

- Configuring path and defining vocabulary in statuses_tags view.
- Define vocabulary in statuses module settings.

When I click in a term it redirects correctly to the term url but a 404 error appears.

We tried in a clean install of drupal 7.9. Same error.

Are we missing a step?

There is another step which is to modify the argument for the statuses_tags view to tell it which vocabulary to use. FBSS does this for you in D6 but that appears to be broken in D7.

EDIT: Oops, I misread your message. I'm not sure why it wouldn't work once you've configured the view. I haven't personally tested the Tags submodule in the D7 branch very much so I don't know what's broken and what's working.

Hi IceCreamYou,

Let us know if we can help with anything.

There are various problems here. I haven't looked at the Views stuff at all. Looks like first of all the view will never execute because the Feed display is missing a plugin. But also a lot of the custom handlers are probably going to be broken.

Yes, is not only because the feed. We deleted that feed display which prevents the view to run properly. The term page doesn't work yet so as you said there is probably more.

Hi IceCreamYou,

Do you have already planned when to solve this issue?

We would like to help but I'm afraid we are not familiar enough with D7 (we have been working for 2 weeks now). Anyway if you can give any direction would be greatly appreciated and we will give it a try.

Thanks

Do you have already planned when to solve this issue?

I basically can't do any more development until at least the 21st due to my schedule. I have some time over the following 3 weeks but I haven't set priorities for that time.

Fundamentally the problem here is probably that the statuses_tags_views_handler_argument_has_this_tag.inc Views handler isn't working. Unfortunately Views 3 isn't documented but the general approach to fixing it would be to look at other Views argument handlers and try to see what they do differently. The issue is going to be that the current code uses D6-style queries (i.e. manually writing SQL) whereas the D7 version should use the query builder API. Pretty much any custom Views handler provided by Statuses that tries to change the view's query probably has this problem because I really haven't gone through and updated any of them.

Thanks,

We have a lot to do before looking into this but anyway We will let you know any advance.

A question: I have a 'problem', probably for my unexperience creating patches. I cannot test patches at all. When I call command "git apply -v *.patch" it always returns "error: while searching for" therefore "patch doesn't apply", do you know what could be? I make the patch all over the correct git process as shown at: http://drupal.org/node/707484 .

I don't know. I've never seen that error before. Google is unhelpful but try using the --ignore-whitespace and --verbose options and see if that tells you anything.

Your patch adds a bunch of trailing whitespace. You should remove that. Also your solution to the problem looks like it just makes the view return no results at all. Remember that this handler is applied to the {statuses} table, so you can't just get rid of the subquery to the {statuses_tags} table.

As Isaac mentioned in #2, correct vocabulary for validation criteria is not assigned to has_this_tag argument, So the validation fails every time and its shows page not found.

Here is the patch for it.

Note: To get this working you need to delete the feed display, since feed style plugin is not ready #1490566: Views RSS support missing

oops! forget to mention important note, to get this view working you need to apply the patch provided in the issue #1484278: Views handlers broken (still use D6 API) #39 for statuses tags views handlers.

I haven't tried this but the patch looks fine to me so if someone can confirm that it works then it can be committed

Seems this patch not solved the following issue:
Strict warning: Declaration of statuses_tags_views_handler_argument_has_this_tag::query() should be compatible with views_handler_argument::query($group_by = false) in _registry_check_code() (line 3046 of /opt/development/test/includes/bootstrap.inc).
Strict warning: Declaration of statuses_tags_views_handler_argument_has_this_tag_id::query() should be compatible with views_handler_argument::query($group_by = false) in _registry_check_code() (line 3046 of /opt/development/test/includes/bootstrap.inc).

D7 with php 5.4

Seems this patch not solved the following issue:
Strict warning: Declaration of statuses_tags_views_handler_argument_has_this_tag::query() should be compatible with views_handler_argument::query($group_by = false) in _registry_check_code() (line 3046 of /opt/development/test/includes/bootstrap.inc).
Strict warning: Declaration of statuses_tags_views_handler_argument_has_this_tag_id::query() should be compatible with views_handler_argument::query($group_by = false) in _registry_check_code() (line 3046 of /opt/development/test/includes/bootstrap.inc).

Did you got this error before applying patch in #16.

And also don't forget to apply the patch here(Else use the current dev version, all the views handlers are fixed and committed in dev) and clear the cache.

@mathankumarc: Let's commit this.

Committed to dev.