Preserve available_options_php keys

Makes sense to me, thanks!

(Skip this, see comment #5)

This created a problem for us in 7.x-2.8 because the values being stored in the field table used to be literal, but now they are numerical keys. Used to be "Orange", "Green", etc., and now are 0, 1, 2, etc.

When the Node is loaded for view the real value of the field isn't available, all we get is the numerical key value.

Is there a way to make both of them work? For now we've just removed this patch from 7.x-2.8 and everything else works fine.

(Skip this, see comment #5)

Nevermind, we just need to update all of our Select (or Other) fields to have Keys. In Drupal Select fields of type Text, it will automatically add the Key if you don't specify it.

What you enter into a Drupal Select widget "Allowed values list":
Option 1
After saving field:
Option 1|Option 1

I believe this module needs that now, otherwise new entries will get numerical keys by default, which could change overtime if you add/re-arrange the options. For instance, you add or re-order the fields, and suddenly a field with value 1 now displays something else.

A sample before and after (if you don't manually set keys) looks like:

entity_type bundle     deleted entity_id revision_id language delta field_foo_value field_foo_format
node        foo_record 0       136511    136669      und      0     Option 1        NULL
node        foo_record 0       136512    136670      und      0     0               NULL

Actually, the problem is that this fix simply assumed that if no key was specified, then it must be PHP. I've added a fix which checks for the possibility of no specified key, and no PHP. Tested and it works.

commited

The committed code has caused a bug it seems: #1532316: #1356112 caused regression in the default options for select widget with optgroups.