Closed (fixed)
Project:
Forum Access
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
29 Nov 2011 at 23:07 UTC
Updated:
15 Dec 2011 at 03:20 UTC
Jump to comment: Most recent file
Comments
Comment #2
salvisThe testbot says "fatal: unable to find filename in patch at line 1".
The testbot requires patches to be in -p1 format, like this:
Also, patches need to be tested against the tip of the branch.
Comment #3
smokrisRevised patch attached.
Comment #4
salvisIt's nice that it passed, but actually, it should not have passed...
The fact that it passed means that either it didn't make any difference, or that our tests fail to test this aspect. I've added the missing tests. The first patch (without your #3) must fail, and the second (with your #3 should then pass...
Comment #5
salvisNice! Committed to the -dev version — thanks!
Comment #6
smokrisAwesome. Thanks, @salvis.