- Fixes install file. Wrong table name and wrong use of (un)install functions
- Replaced use of the view id with the view name (dont know why this was done in the first place?)
- Fixed term form validation
- Fix wrong taxonomy paths

CommentFileSizeAuthor
several-fixes.patch10.14 KBDocc

Comments

jeff.maes’s picture

Great job! Thanks!

1800collect’s picture

I am getting several errors when trying your patch:

can't find file to patch at input line 5
Perhaps you should have used the -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/includes/tvi.admin.inc b/includes/tvi.admin.inc
|index 0210b4f..0fadba3 100755
|--- a/includes/tvi.admin.inc
|+++ b/includes/tvi.admin.inc
--------------------------
File to patch: 
Skip this patch? [y] y
Skipping patch.
8 out of 8 hunks ignored
can't find file to patch at input line 116
Perhaps you should have used the -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/includes/tvi.query.inc b/includes/tvi.query.inc
|index 382b7e6..fad4d5f 100755
|--- a/includes/tvi.query.inc
|+++ b/includes/tvi.query.inc
--------------------------
File to patch: 
Skip this patch? [y] y
Skipping patch.
3 out of 3 hunks ignored
patching file tvi.install
Reversed (or previously applied) patch detected!  Assume -R? [n] y
patching file tvi.js
Reversed (or previously applied) patch detected!  Assume -R? [n] y
patching file tvi.module
Reversed (or previously applied) patch detected!  Assume -R? [n] y

Edit: I manually applied the patch and it seems to be working fine. I'll report back if something breaks.

I had to apply another patch as I was getting an error, that wasn't related to this patch called: Notice: Trying to get property of non-object in tvi_render_view() (line 203 of

The patch that fixes it. With your patch it moved it down to line 203, while his was at line 200: http://drupal.org/node/1224784

Edit: I don't know if it is related to your patch, but I am now getting this error all of a sudden:

Notice: Undefined variable: display in tvi_get_view_info() (line 264..... of tvi.module)

kevinquillen’s picture

Pushed to dev, will release in alpha2.

kevinquillen’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.