I just found that Finder does not work with the choice of format style "table" in a view. Could you take a look please?

Thanks very much for the great work!

CommentFileSizeAuthor
#13 1358178 -finder-style-checkbox.png16.36 KBphilipz

Comments

danielb’s picture

I am aware of this already and don't think I can fix it, unless someone can suggest how. I thought it should have just worked automatically, but it didn't, and the html that Views gives me is not table/grid, just plain divs.
You are also given the option to theme the results, so this is not the sort of issue that will get you stuck completely, but it is annoying.

danielb’s picture

Category: task » feature
Status: Active » Postponed (maintainer needs more info)

I'll leave this open for a while as postponed, if anyone can suggest a solution, please reply!

Rechi’s picture

It seems that the finder always uses the entity:teaser view mode instead of an table view mode. Maybe this is helpfull, even just for theming using an node.tpl file.

Sylense’s picture

Apparently finder does not display ANY other format other than unformatted. I don't even think it is truly outputting the unformatted display because the results typically have the "views-row" div surround them. It does not output any of the wrappers, only the fields themselves within the "view-content" div. This was not the case in older versions of the finder module. This must be a bug

ayesh’s picture

Title: Style "table" in a view ! » Finder is not respecting View's display style
Component: Miscellaneous » Code
Category: feature » bug

Unfortunately, Finder is not taking any style option from Views in the results page.

danielb’s picture

Status: Postponed (maintainer needs more info) » Closed (won't fix)

Thanks for that new info! I'm closing this issue out of spite.

danielb’s picture

Well that isn't fair of me, resetting the settings.

ayesh’s picture

Title: Finder is not respecting View's display style » Style "table" in a view!
Category: bug » feature
Status: Closed (won't fix) » Postponed (maintainer needs more info)

Million apologies. I thought there should be something in Finder that breaks the Views styling.
And I'm always thankful to you for your great contributions.

danielb’s picture

Nah it's not a simple case of overlooking something, it is the design of the module - it provides it's own views style plugin. Don't worry about me, I rage at traffic too.
I was hoping someone could provide a magic solution, but I fear there will be no solution at all.

hlopes’s picture

I've messed around a bit and found that if you comment line 604 at includes/finder.inc , it will inherit the view display.
Doing so will throw an error on the same file, line 777. Comment that line (and the block it belongs to, as it's a cycle that once commented wouldn't do anything useful) and it should work (well, kinda...).

I think the original line was something like

  $view->display_handler->set_option('style_plugin', 'finder'); 

And line 777 is something like

  $results['results'][]['#markup'] = $result->{$result->display_key};

My guess is that it should verify if choices->views display == inherit and override if false.

Oh, and this is under 7.x.dev

danielb’s picture

Status: Postponed (maintainer needs more info) » Active

Unfortunately for a lot of finder's functionality it must use it's own style plugin. Perhaps we need to determine what those functionalities are to go ahead with this.

danielb’s picture

Status: Active » Needs review

I've gone ahead and under 'style' added a checkbox to pretty much do what HLopes said in post #10. I've marked the feature as experimental as I am still worried some things will break, though I haven't been able to prove that yet.

philipz’s picture

StatusFileSize
new16.36 KB

I downloaded latest dev release and I can't see the checkbox. Is this where I should see it?

flefle’s picture

Category: feature » support
Priority: Normal » Major
Status: Needs review » Needs work

Cześć,
first of all thank you danielb for the great module.
I've found why all this happens @ "7.x.2.x-dev".
On row 777 of finder.inc the following code is processing the output:

$results['results']['#prefix'] = $this->find['results_prefix'];
foreach ($this->find['results'] as $result) {
            $results['results'][]['#markup'] = $result->{$result->display_key} ;         
}
$results['results']['#suffix'] = $this->find['results_suffix'];

There are 'Display output', 'Style output' and 'Row style output' TPL files at views.
Only the style tpl is processed leaving out the row tpl processing. The variables and the coding structure is a bit complicated so I've quickly managed to recode the standard views row output like:

$results['results']['#prefix'] = $this->find['results_prefix'];
$i = 1;
foreach ($this->find['results'] as $result) {
            $order = ($i%2) ? 'odd' : 'even';
            $results['results'][]['#markup'] = '<div class="views-row views-row' . $i . ' views-row-' .  $order . '">' . $result->{$result->display_key} . '</div>';
            $i++;
}
$results['results']['#suffix'] = $this->find['results_suffix'];

Except of that, the finder module is really sensitive about the tpl file names of the fields. I've couldn't use the last (most specific tpl file) and had to experiment which file is accepted.

BTW: line 604 & 777 changes evoke an broken syntax at autocomplete search however when calling via url the search the results are OK.

Hope this helps.

Regs,
Francis

danielb’s picture

Category: support » feature
Priority: Major » Normal
Status: Needs work » Needs review

a major support request that needs work...

w

t

f

plus you've pasted outdated code

flefle’s picture

Priority: Normal » Minor
Status: Needs review » Reviewed & tested by the community

What do you mean by outdated? I've just used the dev module from 27th March (it was updated before short time ago) with the same issues. Id did work out for me. Sorry for incorrect message setting, no need to talk like that.

danielb’s picture

Priority: Minor » Normal
Status: Reviewed & tested by the community » Needs review

Please go away.

danielb’s picture

Priority: Minor » Normal
flefle’s picture

Priority: Normal » Minor
Status: Needs review » Closed (fixed)

I will go away after I've done explaining you that such behavior is not right and exaggerated. I didn't requested or pushed you to work on this issue but find a solution also as I found another bug and provided you a patch file for handling that. After I was really friendly and helping I think that you must be a real idiot while talking like that.
You are not the only one who is developing modules and contributing to the community so please come down. The idea behind Drupal is to take and give.
In case that you don't want to work on this project, close it, have a nice life, be calm and happy. But please, please don't torture yourself and others while reacting in such manner.

While talking about the solution proposals, this issue could be solved in my opinion via two ways:
1. Find a way how the standard views tpl's would be accessed and used via the view.
2. Make a hook_theme where the result would be rendered trough those new - custom files within finder module. It could also call the original views files for instance while composing the file names regarding the field names or view name at rows and style.

danielb: if you will try to swear, send me away or whatever else you have to know that I will ignore that and that I don't care. Grow up!

Thank you for the great module anyway.
PS: I'm a contributor to this project and you are the maintainer.

danielb’s picture

- a fix for this issue was committed yesterday
- finder has always provided a theme function where you can completely control the results output
- stop continually changing issue settings, you make it difficult to organise and track the work, it makes you incredibly aggravating
- don't tell me how to talk, how to live my life, or "how it is", it is my number one pet peeve and much nastier than anything I could think of to say to you

I started working on a major new feature for this module today, but now I'm told to close the project, that does seem very attractive right now.