Porting a module for Drupal 7

I think this should be needs review. I will try to install and report back

I got this when I applied the patch

skype_status$ patch -p1 < port*
patching file inc/skype_status.admin.inc
patching file inc/skype_status.admin.js
patching file inc/skype_status.ajax.inc
patching file inc/skype_status.ajax.js
patching file skype_status.info
Hunk #1 succeeded at 1 with fuzz 2.
patching file skype_status.install
patching file skype_status.module
patching file views/skype_status.views.inc
patching file views/skype_status_handler_field_user.inc

Edit:

I did want to note that the .info file was not updated to Drupal 7

I am okay with looking into this patch, the only thing I see so far that looks odd are the new lines being added in many places. I don't believe that follows Drupal coding standards.

I get lots of errors:

Warning: simplexml_load_string(): namespace error : Namespace prefix rdf for about on Status is not defined in simplexml_load_string() modules/all/skype_status/skype_status.module). =>

Warning: simplexml_load_string(): namespace error : Namespace prefix rdf for about on Status is not defined in simplexml_load_string() (line 61 of /var/aegir/platforms/7/modules/all/skype_status/skype_status.module). =>
... (Array, 6 elements)
Krumo version 0.2.1a
| http://krumo.sourceforge.net

Warning: simplexml_load_string(): in simplexml_load_string() (line 61 of /var/aegir/platforms/7/modules/all/skype_status/skype_status.module). =>
... (Array, 6 elements)
Krumo version 0.2.1a
| http://krumo.sourceforge.net

Warning: simplexml_load_string(): ^ in simplexml_load_string() (line 61 of /var/aegir/platforms/7/modules/all/skype_status/skype_status.module). =>
... (Array, 6 elements)
Krumo version 0.2.1a
| http://krumo.sourceforge.net

Warning: simplexml_load_string(): Entity: line 4: parser error : expected '>' in simplexml_load_string() (line 61 of /var/aegir/platforms/7/modules/all/skype_status/skype_status.module). =>
... (Array, 6 elements)
Krumo version 0.2.1a
| http://krumo.sourceforge.net

Warning: simplexml_load_string(): 1 in simplexml_load_string() (line 61 of /var/aegir/platforms/7/modules/all/skype_status/skype_status.module). =>
... (Array, 6 elements)
Krumo version 0.2.1a
| http://krumo.sourceforge.net

Warning: simplexml_load_string(): ^ in simplexml_load_string() (line 61 of /var/aegir/platforms/7/modules/all/skype_status/skype_status.module). =>
... (Array, 6 elements)
Krumo version 0.2.1a
| http://krumo.sourceforge.net

Notice: Trying to get property of non-object in skype_status_getstatus() (line 63 of /var/aegir/platforms/7/modules/all/skype_status/skype_status.module). =>
... (Array, 5 elements)
Krumo version 0.2.1a
| http://krumo.sourceforge.net
[Click to expand. Double-click to show path.] Called from /var/aegir/platforms/7/modules/all/skype_status/skype_status.module, line 63
Notice: Trying to get property of non-object in skype_status_getstatus() (line 64 of /var/aegir/platforms/7/modules/all/skype_status/skype_status.module). =>
... (Array, 5 elements)
Krumo version 0.2.1a
| http://krumo.sourceforge.net
[Click to expand. Double-click to show path.] Called from /var/aegir/platforms/7/modules/all/skype_status/skype_status.module, line 64
Notice: Undefined index: render element in theme() (line 974 of /var/aegir/platforms/7/servers/drupal-7.x-dev.4.29.12/includes/theme.inc). =>
... (Array, 5 elements)
Krumo version 0.2.1a
| http://krumo.sourceforge.net
[Click to expand. Double-click to show path.] Called from /var/aegir/platforms/7/servers/drupal-7.x-dev.4.29.12/includes/theme.inc, line 974
Warning: Missing argument 2 for theme_skype_status_image(), called in /var/aegir/platforms/7/servers/drupal-7.x-dev.4.29.12/includes/theme.inc on line 1051 and defined in theme_skype_status_image() (line 134 of /var/aegir/platforms/7/modules/all/skype_status/skype_status.module). =>
... (Array, 6 elements)
Krumo version 0.2.1a
| http://krumo.sourceforge.net
[Click to expand. Double-click to show path.] Called from /var/aegir/platforms/7/modules/all/skype_status/skype_status.module, line 134
Warning: Missing argument 3 for theme_skype_status_image(), called in /var/aegir/platforms/7/servers/drupal-7.x-dev.4.29.12/includes/theme.inc on line 1051 and defined in theme_skype_status_image() (line 134 of /var/aegir/platforms/7/modules/all/skype_status/skype_status.module). =>
... (Array, 6 elements)
Krumo version 0.2.1a
| http://krumo.sourceforge.net
[Click to expand. Double-click to show path.] Called from /var/aegir/platforms/7/modules/all/skype_status/skype_status.module, line 134
Warning: rawurldecode() expects parameter 1 to be string, array given in rawurldecode() (line 135 of /var/aegir/platforms/7/modules/all/skype_status/skype_status.module). =>
... (Array, 7 elements)
Krumo version 0.2.1a
| http://krumo.sourceforge.net

Notice: Undefined variable: buttonstyle in theme_skype_status_image() (line 136 of /var/aegir/platforms/7/modules/all/skype_status/skype_status.module). =>
... (Array, 6 elements)
Krumo version 0.2.1a
| http://krumo.sourceforge.net
[Click to expand. Double-click to show path.] Called from /var/aegir/platforms/7/modules/all/skype_status/skype_status.module, line 136
Notice: Undefined variable: status in theme_skype_status_image() (line 136 of /var/aegir/platforms/7/modules/all/skype_status/skype_status.module). =>
... (Array, 6 elements)
Krumo version 0.2.1a
| http://krumo.sourceforge.net
[Click to expand. Double-click to show path.] Called from /var/aegir/platforms/7/modules/all/skype_status/skype_status.module, line 136
Notice: Undefined variable: buttonstyle in theme_skype_status_image() (line 137 of /var/aegir/platforms/7/modules/all/skype_status/skype_status.module). =>
... (Array, 6 elements)
Krumo version 0.2.1a
| http://krumo.sourceforge.net
[Click to expand. Double-click to show path.] Called from /var/aegir/platforms/7/modules/all/skype_status/skype_status.module, line 137
Notice: Array to string conversion in rdf_preprocess_image() (line 775 of /var/aegir/platforms/7/servers/drupal-7.x-dev.4.29.12/modules/rdf/rdf.module). =>
... (Array, 8 elements)
Krumo version 0.2.1a
| http://krumo.sourceforge.net
[Click to expand. Double-click to show path.] Called from /var/aegir/platforms/7/servers/drupal-7.x-dev.4.29.12/modules/rdf/rdf.module, line 775
Recoverable fatal error: Argument 1 passed to drupal_attributes() must be an array, string given, called in /var/aegir/platforms/7/servers/drupal-7.x-dev.4.29.12/includes/theme.inc on line 1679 and defined in drupal_attributes() (line 2296 of /var/aegir/platforms/7/servers/drupal-7.x-dev.4.29.12/includes/common.inc). =>
... (Array, 9 elements)
Krumo version 0.2.1a
| http://krumo.sourceforge.net
[Click to expand. Double-click to show path.] Called from /var/aegir/platforms/7/servers/drupal-7.x-dev.4.29.12/includes/common.inc, line 2296
Warning: Invalid argument supplied for foreach() in drupal_attributes() (line 2297 of /var/aegir/platforms/7/servers/drupal-7.x-dev.4.29.12/includes/common.inc). =>
... (Array, 9 elements)
Krumo version 0.2.1a
| http://krumo.sourceforge.net
[Click to expand. Double-click to show path.] Called from /var/aegir/platforms/7/servers/drupal-7.x-dev.4.29.12/includes/common.inc, line 2297
Warning: implode(): Invalid arguments passed in implode() (line 2301 of /var/aegir/platforms/7/servers/drupal-7.x-dev.4.29.12/includes/common.inc). =>
... (Array, 10 elements)
9: implode() (Array, 1 element)
8: drupal_attributes() (Array, 2 elements)
file (String, 24 characters ) includes/common.inc:2301
args (Array, 1 element)
0 (String, 1 characters ) s
7: theme_image() (Array, 2 elements)
file (String, 23 characters ) includes/theme.inc:1679
args (Array, 1 element)
0 (Array, 7 elements)
path (String, 1 characters ) s
width (String, 1 characters ) s
height (String, 1 characters ) s
alt (String, 1 characters ) s
title (String, 1 characters ) s
attributes (String, 1 characters ) A
theme_hook_suggestions (Array, 0 elements)
6: theme() (Array, 2 elements)
file (String, 23 characters ) includes/theme.inc:1051
args (Array, 5 elements)
0 (String, 5 characters ) image
1 (String, 60 characters ) sites/all/modules/contrib-social-1/skype_status...
2 (String, 17 characters ) Skype Status for
3 (String, 17 characters ) Skype Status for
4 (Array, 1 element)
style (String, 12 characters ) border:none;
5: theme_skype_status_image() (Array, 2 elements)
file (String, 71 characters ) /var/aegir/platforms/7/modules/all/skype_status...
/var/aegir/platforms/7/modules/all/skype_status/skype_status.module:139
args (Array, 1 element)
0 (Array, 1 element)
(String, 9 characters ) undefined
4: theme() (Array, 2 elements)
file (String, 23 characters ) includes/theme.inc:1051
args (Array, 4 elements)
0 (String, 18 characters ) skype_status_image
1 (String, 9 characters ) undefined
2 (Array, 2 elements)
num (NULL)
text (NULL)
3 (String, 10 characters ) bigclassic
3: skype_status_ajax_call() (Array, 2 elements)
file (String, 76 characters ) /var/aegir/platforms/7/modules/all/skype_status...
args (Array, 4 elements)
0 (String, 9 characters ) undefined
1 (String, 10 characters ) bigclassic
2 (String, 9 characters ) undefined
3 (String, 10 characters ) bigclassic
2: call_user_func_array() (Array, 1 element)
args (Array, 2 elements)
0 (String, 22 characters ) skype_status_ajax_call | (Callback) skype_status_ajax_call();
1 (Array, 4 elements)
0 (String, 9 characters ) undefined
1 (String, 10 characters ) bigclassic
2 (String, 9 characters ) undefined
3 (String, 10 characters ) bigclassic
1: menu_execute_active_handler() (Array, 2 elements)
file (String, 21 characters ) includes/menu.inc:516
args (Array, 0 elements)
0: main() (Array, 2 elements)
file (String, 12 characters ) index.php:21
args (Array, 1 element)
q (String, 33 characters ) skype_status/undefined/bigclassic
Krumo version 0.2.1a
| http://krumo.sourceforge.net

Error message

Notice: Use of undefined constant SKYPE_STATUS_IMAGE_PATH - assumed 'SKYPE_STATUS_IMAGE_PATH' in include_once() (line 3 of /var/aegir/platforms/7/modules/all/skype_status/skype_status.module).
Notice: Use of undefined constant SKYPE_STATUS_AJAX_URL - assumed 'SKYPE_STATUS_AJAX_URL' in include_once() (line 5 of /var/aegir/platforms/7/modules/all/skype_status/skype_status.module).

Notice: Use of undefined constant SKYPE_STATUS_IMAGE_PATH - assumed 'SKYPE_STATUS_IMAGE_PATH' in include_once() (line 3 of /var/aegir/platforms/7/modules/all/skype_status/skype_status.module).
Notice: Use of undefined constant SKYPE_STATUS_AJAX_URL - assumed 'SKYPE_STATUS_AJAX_URL' in include_once() (line 5 of /var/aegir/platforms/7/modules/all/skype_status/skype_status.module).

As per the last comment

I have a major rewrite of Skype Status for Drupal 7 available as a sandbox project for further feedback and testing. I am also attaching a patch against the master branch just in case, though IMO it is too big for review.

The code has been committed to the original project.