Views access handler is broken for fields that don't have profile privacy controls enabled

I think there's a mistake in the logic in _profile_privacy_views_field_access(), towards the bottom:

  if (isset($account->{'private_' . $field->name}) && $field->privacy) {
    $access = profile_privacy_get_field_access($account, $field);
  }
  elseif (PROFILE_PRIVATE == $field->visibility) {
    $access = FALSE;
  }
  else {
    // Field was set as PROFILE_HIDDEN in Profile module config, so check
    // whether it's overridden in the view.
    if (!$handler->options['profile_privacy_show_hidden']) {
      $access = FALSE;
    }
  }

The last ELSE clause, checks to see if the View field settings for showing regardless of the field being private is set. But the second clause sets access to FALSE if it is private. That doesn't make sense. The check for the override should be in the middle clause, and the remaining ELSE should simply be $access = TRUE, because in that case, there are NO profile_privacy settings, and the field is public.

Patch