Due dates: Support CCK fields in the follow-up form

Sorry about the missing -p in the patch. I wasn't aware that -up this was the preferred switch. Thanks for pointing that out. I'm using PHPEclipse and as far as I can tell there is no -p option. I'll have to adjust my procedure for creating patches.

Hook form_alter did a good job of adding the CCK elements in the follow up form, but then I found that there was no way to save the CCK data. In the current code for Beta2, the function project_comment_save() copies each element of issue information from the edit object into the node object, then passes that to node_save. The extra CCK data doesn't get copied from $edit to $node, so that's where I found I had to alter the code.

Looking at the code from http://drupal.org/node/74995, it seems like the $arg parameter should contain the CCK data?

From there, it looks like project_issue_update() gets called. This is different form the code I was looking at, because you won't go through node_save(), meaning you won't invoke hook_update(). This will result in the CCK data never getting to content.module. (This may also mean you loose out on other nodeapi update calls as well, but I'm not sure.) Not having invested too much time in the code, it looks like if you want to support CCK in the follow-up form, you'll want to either go back to node_save, or add some CCK handling code in the function project_issue_comment().

Then the only other thing to watch for is the call to _content_widget_invoke('process form values', $node); I found I had to include this call because the node_save() call doesn't invoke submit, so the CCK data for date wasn't ready to be saved.

Hope that helps. I understand if you are hesitant to add CCK handling code in there, but it does seem like it should be a pretty easy add for a lot of bang, and won't affect functionality if CCK isn't enabled. Someone with more experience in CCK might have more to add.

Thanks again!

I've run into another issue where the CCK cache information gets set with the CCK field being null when inserting an issue. This is happening in the project_issue node form, not the follow up form. This appears to be independent of this issue, but I thought I'd mention it here just in case. I've created an issue over on CCK, but because other node types work fine, I'm wondering if there could be something different in the node work flow that might be causing this.

The issue can be found here: http://drupal.org/node/137435

I've updated the issue above with some information that I've found in regards to the due dates not saving when creating a new issue. It seems that the issue is the call to node_load() in project_mail_notify().

Here's the quick for reference: http://drupal.org/node/137435#comment-236528

@dww, please let me know what you think. I realize that this is a low priority right now, so let me know what I can do to help. Thanks!

Sounds good.

Just as an aside, I didn't create that patch against head, so that's probably the problem. My bad. (It was more an exploration of the problem at that point, and I was trying to keep from confusing myself by mixing the new code.)

I didn't re-read this last comment before posting my other issue: http://drupal.org/node/140940

This is a feature request to pass the $body of the emails through the theme. If we take the approach you outlined, then this is not needed for CCK fields, but this still might be a nice feature that is easy to implement.

As for not holding the patch up, I've got it working enough for my purposes now, so we might as well do it right, I supposed. The comments in http://drupal.org/node/140473 seem to be the right way to go.

Additionally, I also have need of project issue data in views, so I'm willing to lend a hand there. This is off topic, but here are the things I'm hoping it will let me do:

• Add a project field to issues in the calendar view.
• Adjust my list of upcoming due dates by filtering out things that are already done.
• Create a list of due dates that are past due.

Again, off topic, but fun. Let me know where you will be pursuing this and I'll do whatever I can to help.

Here's a cleaned up version of this patch against HEAD. If you still see problems, just yell at me and I'll redo it.

It seems that http://drupal.org/node/140473 might be the place to handle the viewing of the og and cck differences, so I didn't try to take a crack at that part.

Doh! Sorry about that.

Code seems pretty good to me, but someone else might want to weigh in. The only thing I wasn't 100% sure about where I placed the cck fields in the logic of project_issue_form. I think I got it right, but that was the only spot where I wasn't 100%.