CCK + project issue results in empty cache data

Well, I think I've tracked down why this is happening. I did some backtraces and some drupal_set_messages to track down the nodeapi workflow and noticed that there is an extra node_load being called before hook_nodeapi (load) is called. Here's the quick walk through of what happens:

1. node_form_submit calls node_submit
2. node_form_submit calls node_save
3. node_save saves the basic node info
4. node_save then calls node_invoke with a parameter of insert, which results in project_issue_insert being called. At the end of project_issue_insert it calls project_mail_notify (see below)
5. node_save then calls node_invoke_nodeapi (insert)

The issue seems to be that the first line of project_mail_notify() is a call to node_load to get the project issue information. I think what's happening is that at this point in the code, we haven't invoked nodeapi() to save the extra information to the database. As a result, when we call node load, we call node_invoke_nodeapi(), then content_nodeapi(), then content_load(). The function content_load() sees that this is the first time we are loading this node and caches the empty cck information. Once we're done there, we return to node_save and call the nodeapi invoke, resulting in an empty cache, even though the data was saved.

Note that content_update includes a call to cache_clear_all(), which removes the problem when updating.

It seems like the issue is that there is no place to add the call to project_mail_notify to ensure that all the data was saved. Moving it to project_issue_issue_nodeapi() may help by moving the the call to node_load in that function to after the module_invoke_nodeapi() call.

A quick and dirty fix might be to add a call to cache_clear_all() in content_insert or project_issue_insert(), but both of these options seem messy. There might actually be an argument for a kind of hook_notify function in Drupal 6 that would be called directly from node_save after the nodeapi functions are invoked. This would make sure that everything had been saved and would also allow other modules to leverage this functionality. That's probably outside the scope of this issue, but I'd be willing to help write up an issue if others thought this was something useful moving forward. Can anyone think of a better place for this fix to happen?

To the wonderful maintainers of CCK, feel free to move this issue into the project_issue project if that makes more sense. I'll be posting a small note in the due date cck + project_issue issue listed above to notify others of what I've found.

Again, I know this is a bit off the beaten path, but hopefully it saves someone else out there some time.

Thanks for the response,

I can say that adding the following line at the bottom of project_issue_insert() in issue.inc, after project_mail_notify(), fixed the problem for me:

  cache_clear_all('content:'. $node->nid .':'. $node->vid, 'cache_content');

Obviously this is not the correct fix, but I was able to confirm that this works. I'll see what derek has to say and clean this from your queue if he doesn't get a chance to get to it. I'd be tempted to make this over to project_issue, but I'll let him do it.

That seemed to work fine for me. The due date seems showing up correctly during insert. There doesn't seem to be anything missing from the edit version of the node object as opposed to the loaded node. There shouldn't be, that was my only concern.

I'm going to create an additional minor issue in regards to getting cck information to show up in the email.

I think this one is RTBC.