Hello,
I use yours module views_slideshow and I thank you for yours works.
I use jQuery Cycle plugin, and I set that there's 3 element on one slide
I've a problem when I enable Hide controls if there is only one slide, the controls disappear everytime.
I've crete a patch to resolve this problem. I hope that it's usefull
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | views_slideshow-hide-controls-if-there-is-only-one-slide-1372894-7.patch | 1.54 KB | duaelfr |
| #5 | 1372894-views_slideshow-hide-controls-if-there-is-only-one-slide.patch | 1.94 KB | barraponto |
| hide_control_one_slide.patch | 1013 bytes | ts145nera |
Comments
Comment #1
swirtI have the same issue. I have the slideshow set to show 3 images on a slide, and in my test case there are 9 images total. If I set the option to hide the controls if there is only one slide, the controls are not output to the html, ever.
I believe the behavior in my case should be that there are controls output if there are more than 3 images in the collection (since the slide displays three at a time) and here should be no controls if there are 3 or fewer images.
Comment #2
swirtUpdate: I used the patch above and it all works as it should now. Thanks ts145nera.
This really should be added to the module.
Comment #3
pomliane commentedComment #4
mustanggb commentedRelated/Duplicate: #1452684: "Hide controls if there is only one slide" not working with "Items per slide"
Comment #5
barrapontoI find mogtofu's patch in #1452684: "Hide controls if there is only one slide" not working with "Items per slide" to be more concise, I'm rebasing to latest dev.
Comment #6
jonhattanPatch in #5 RTBC.
Comment #7
duaelfrThis patch needs to be rerolled (new patch following)
Comment #8
duaelfrRerolled on the last dev version.
Please commit :)
Comment #9
wangqizhong commentedThanks a lot to barraponto, DuaelFr, mogtofu33, ts145nera and everyone else for the great work on the patches, testing, reviews and reporting.
It's more time this got committed and I went ahead and had this rolled at:
7.x-3.x: 54b815f
Marking this as fixed.
Please let me know if you would have any other questions, comments, issues or concerns on any of these changes, I would be glad to provide more information.
Thanks again to everyone for the help and great work on this issue.
Cheers!